Page MenuHomeFreeBSD

vm_phys_early_alloc(): Align to PAGE_SIZE; Review callers' alignment
AcceptedPublic

Authored by olce on Jan 23 2025, 5:16 PM.
Tags
None
Referenced Files
F170924662: D48637.id.diff
Mon, Sep 7, 3:35 PM
Unknown Object (File)
Fri, Sep 4, 8:44 PM
Unknown Object (File)
Fri, Sep 4, 11:44 AM
Unknown Object (File)
Wed, Sep 2, 4:23 PM
Unknown Object (File)
Tue, Aug 25, 8:45 PM
Unknown Object (File)
Fri, Aug 21, 11:05 AM
Unknown Object (File)
Sat, Aug 15, 9:04 PM
Unknown Object (File)
Thu, Aug 13, 12:35 AM

Details

Reviewers
markj
dougm
alc
Summary

Switch alignment of vm_phys_early_alloc() to PAGE_SIZE as it is the most
used one.

Review all calling points and change those where greater alignment is
really needed to use vm_phys_early_alloc_ex().

In particular, in PowerPC's moea64_page_array_startup(), reduce the
requested alignment to what the hardware actually requires
('moea64_large_page_size') instead of the size of the page array portion
for a full domain.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62305
Build 59189: arc lint + arc unit

Event Timeline

olce requested review of this revision.Jan 23 2025, 5:16 PM
olce edited the summary of this revision. (Show Details)

Explicitly mention the change in moea64_page_array_startup() in the commit message.

Impacts of vm_phys_early_alloc_ex()'s change of signature.

Fix a small typo "bug" in mmu_radix_page_array_startup() (a 0 instead of a -1
for the domain value; however, this code is under #ifdef notyet, so not
active).

This revision is now accepted and ready to land.Feb 18 2025, 9:05 PM