Page MenuHomeFreeBSD

vm: simplify conditional for dumping startup pages
ClosedPublic

Authored by bnovkov on May 3 2024, 8:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 17, 2:42 PM
Unknown Object (File)
Thu, Jun 13, 6:29 PM
Unknown Object (File)
Thu, Jun 13, 6:29 PM
Unknown Object (File)
Thu, Jun 13, 6:29 PM
Unknown Object (File)
Mon, Jun 3, 7:24 AM
Unknown Object (File)
Mon, May 27, 2:15 AM
Unknown Object (File)
Sat, May 25, 5:32 PM
Unknown Object (File)
May 15 2024, 8:47 AM

Details

Summary

This patch introduces the MINIDUMP_STARTUP_PAGE_TRACKING symbol and uses it to simplify several instances of a complex check for adding startup pages to minidumps.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thanks for this. Seems good to me, with one question inline.

Edit: you missed the update of vmparam.h for 32-bit arm.

sys/vm/vm_page.c
623

Why is this condition different than the others?

Add missing arm vmparam.h updates.

sys/vm/vm_page.c
623

I wanted to avoid adding another #if MINIDUMP_PAGE_TRACKING && MINIDUMP_STARTUP_PAGE_TRACKING, so I've moved the #if MINIDUMP_STARTUP_PAGE_TRACKING block under the MINIDUMP_PAGE_TRACKING block defined on line 598.

The condition is still the same, but less verbose.

mhorne added inline comments.
sys/vm/vm_page.c
623

Thanks, I see now.

This revision is now accepted and ready to land.May 9 2024, 5:07 PM