vm: simplify conditional for dumping startup pages
ClosedPublic
Actions

Authored by bnovkov on May 3 2024, 8:26 PM.

Details

Reviewers

markj
mhorne
andrew
manu

Commits

rG0a44b8a56d23: vm: Simplify startup page dumping conditional

Summary

This patch introduces the MINIDUMP_STARTUP_PAGE_TRACKING symbol and uses it to simplify several instances of a complex check for adding startup pages to minidumps.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bnovkov created this revision.May 3 2024, 8:26 PM

Herald added a reviewer: andrew. · View Herald TranscriptMay 3 2024, 8:26 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: riscv, jhibbits, emaste, imp. · View Herald Transcript

bnovkov requested review of this revision.May 3 2024, 8:26 PM

bnovkov added a child revision: D45044: uma: retire UMA_MD_SMALL_ALLOC.May 3 2024, 8:31 PM

Thanks for this. Seems good to me, with one question inline.

Edit: you missed the update of vmparam.h for 32-bit arm.

sys/vm/vm_page.c
623	Why is this condition different than the others?

Add missing arm vmparam.h updates.

bnovkov added inline comments.May 8 2024, 4:55 PM

sys/vm/vm_page.c
623	I wanted to avoid adding another `#if MINIDUMP_PAGE_TRACKING && MINIDUMP_STARTUP_PAGE_TRACKING`, so I've moved the `#if MINIDUMP_STARTUP_PAGE_TRACKING` block under the `MINIDUMP_PAGE_TRACKING` block defined on line 598. The condition is still the same, but less verbose.