In D44566#1188985, @saper_saper.info wrote:Is it possible that this broke grub2-bhyve built for older FreeBSD 15-CURRENT? https://lists.freebsd.org/archives/freebsd-current/2025-August/008456.html
Could we add something to RELNOTES/UPDATING to say this happened? Did we bump FreeBSD version for this one?
(a rebuilt ghub2-bhyve with libvmmapi.so.7 works fine)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Yesterday
Yesterday
bnovkov added a comment to D44566: libvmmapi: Add support for setting up and configuring guest NUMA domains.
bnovkov committed rGba487345f85f: UPDATING: Add an entry covering recent libvmmapi ABI changes (authored by bnovkov).
UPDATING: Add an entry covering recent libvmmapi ABI changes
Thu, Aug 7
Thu, Aug 7
Fri, Aug 1
Fri, Aug 1
riscv: Add cvitek SoC files to the build
bnovkov committed rGe9dd9f95f82f: riscv: Add the sdhci_fdt driver to the build (authored by bnovkov).
riscv: Add the sdhci_fdt driver to the build
bnovkov committed rG25b9b0b6bec9: riscv: Add driver for cvitek reset controller (authored by bnovkov).
riscv: Add driver for cvitek reset controller
bnovkov committed rGe07254d1483f: riscv: Add driver for the cvitek reboot controller (authored by bnovkov).
riscv: Add driver for the cvitek reboot controller
bnovkov committed rG7a9a15eaf917: if_dwc: Add support for cvitek ethernet controller (authored by bnovkov).
if_dwc: Add support for cvitek ethernet controller
bnovkov committed rG89e650eacc9b: sdhci: Add driver for the cvitek sdhci controller (authored by bnovkov).
sdhci: Add driver for the cvitek sdhci controller
bnovkov committed rG19643b415b2b: if_dwc: Ignore clk_set_assigned errors if "assigned_clocks" is not specified (authored by bnovkov).
if_dwc: Ignore clk_set_assigned errors if "assigned_clocks" is not specified
db/hash.c: Fix flag check in hash_seq
Thu, Jul 31
Thu, Jul 31
bnovkov committed rG3a686b851f8f: dbm_nextkey: Always return an error if we've reached the end of the database (authored by bnovkov).
dbm_nextkey: Always return an error if we've reached the end of the database
bnovkov added inline comments to D51635: dbm_nextkey: Always return an error if we've reached the end of the database.
bnovkov updated the diff for D51635: dbm_nextkey: Always return an error if we've reached the end of the database.
Address @markj 's comments.
Wed, Jul 30
Wed, Jul 30
bnovkov updated the diff for D51635: dbm_nextkey: Always return an error if we've reached the end of the database.
Remove stray newline.
db/hash.c: Allow O_WRONLY in dbm_open
Tue, Jul 29
Tue, Jul 29
Add O_WRONLY check in hash_get and add corresponding tests.
Mon, Jul 28
Mon, Jul 28
Address @markj 's comments.
Sun, Jul 27
Sun, Jul 27
In D46607#1165023, @markj wrote:Looks ok to me with the man page nits fixed.
bnovkov committed rGc7a1776752ec: bhyve/tpm_ppi_qemu: Cast address of the TPP3 field to uint32_t (authored by bnovkov).
bhyve/tpm_ppi_qemu: Cast address of the TPP3 field to uint32_t
bhyve/acpi: Mark dsdt_line as 'printflike'
bnovkov committed rGf1d705d4f431: bhyve: Add support for specifying guest NUMA configuration (authored by bnovkov).
bhyve: Add support for specifying guest NUMA configuration
bnovkov committed rG08c7dd2fbe4f: libvmmapi: Add support for setting up and configuring guest NUMA domains (authored by bnovkov).
libvmmapi: Add support for setting up and configuring guest NUMA domains
vmm: Add support for guest NUMA emulation
bnovkov committed rGcf571e08503d: domainset(9): Split domainset validation logic into a separate function (authored by bnovkov).
domainset(9): Split domainset validation logic into a separate function
bnovkov committed rGaae23170c8b5: libutil: Move cpuset(1) domain policy parsing code into libutil (authored by bnovkov).
libutil: Move cpuset(1) domain policy parsing code into libutil
Rework and clarify interactions between the -m flag and individual domain memory sizes.
Sat, Jul 26
Sat, Jul 26
Closing this since it was superseded by D49531.
Fri, Jul 25
Fri, Jul 25
dbm: Add tests for dbm_open
bnovkov committed rG108e2d1137aa: db/hash.c: Do not return an error when opening a missing database with O_CREAT (authored by bnovkov).
db/hash.c: Do not return an error when opening a missing database with O_CREAT
Thu, Jul 24
Thu, Jul 24
Jul 19 2025
Jul 19 2025
In D44567#1172416, @markj wrote:Have you tried booting a Linux guest with NUMA configured?
Address @markj's comments
bnovkov added inline comments to D44566: libvmmapi: Add support for setting up and configuring guest NUMA domains.
bnovkov updated the diff for D44566: libvmmapi: Add support for setting up and configuring guest NUMA domains.
Address @markj 's comments and fix an edge case where VM_LOWMEM_LIMIT == 0 .
Jul 16 2025
Jul 16 2025
pt: Include missing sys/lock.h header
hwt(4): Add Intel Processor Trace backend
bnovkov committed rG636823cfd260: makefs: Correct license text in 'makefs_msdos_tests.sh' (authored by bnovkov).
makefs: Correct license text in 'makefs_msdos_tests.sh'
bnovkov committed rG483ef23ebb72: release: Consistently use variables for invoking certain tools (authored by bnovkov).
release: Consistently use variables for invoking certain tools
makefs: Fix undefined behaviour in ffs.c
bnovkov committed rGceab09e3dbc2: release: Add a helper script for common tools (authored by bnovkov).
release: Add a helper script for common tools
Jul 13 2025
Jul 13 2025
Address @markj 's comments.
bnovkov added inline comments to D44566: libvmmapi: Add support for setting up and configuring guest NUMA domains.
bnovkov updated the diff for D44566: libvmmapi: Add support for setting up and configuring guest NUMA domains.
Address @markj 's comments:
- Remove cpu affinity tracking
I have reworked the acpi.c changes in a way that simplifies tracking cpu affinities (and allows us to get rid of libvmmapi cpu affinity interfaces).
Address @markj 's comments and rework acpi.c changes:
- acpi.c now tracks each 'vCPUid->domain' mapping
- New mappings can be added using acpi_add_vcpu_affinity
- Manpage fixes
Jul 12 2025
Jul 12 2025
Jul 11 2025
Jul 11 2025
One minor thing that wasn't mentioned here (and is likely be brought up in future C++ reviews) is the order of C++ includes. More specifically, should the C++ standard library includes come before or after /usr/include files?
Jul 7 2025
Jul 7 2025
I left a couple of comments about a few things that stood out in the first pass, I will likely have more as I dive into the internals.
Jul 3 2025
Jul 3 2025
Address @markj 's comments.
bnovkov added inline comments to D44566: libvmmapi: Add support for setting up and configuring guest NUMA domains.
bnovkov updated the diff for D44566: libvmmapi: Add support for setting up and configuring guest NUMA domains.
Address @markj 's comments.
Address @markj 's comments:
- Move domainset parsing code to the ioctl handler
- Add COMPAT handlers for pre-15.0 memory segments
bnovkov updated the diff for D46608: kern_domainset: Split domainset validation logic into a separate function.
Fix style issues and make domainset_empty_vm public.
Jul 1 2025
Jul 1 2025
Jun 30 2025
Jun 30 2025
bnovkov updated the diff for D51039: release: Consistently use variables for invoking certain tools.
Address @markj 's comments.
Jun 26 2025
Jun 26 2025
In D51038#1165125, @emaste wrote:It's OK to omit the license boilerplate and have just the SPDX now too, i.e. remove Redistribution and use ... SUCH DAMAGE. Just noticed since this file only has three lines of content now.
Remove license boilerplate
bnovkov updated the diff for D51039: release: Consistently use variables for invoking certain tools.
Correct include path in vmimage.subr
bnovkov added inline comments to D51039: release: Consistently use variables for invoking certain tools.
bnovkov updated the diff for D51039: release: Consistently use variables for invoking certain tools.
Address @markj 's comments - fix include path
Jun 25 2025
Jun 25 2025