Page MenuHomeFreeBSD
Differential D51491

db/hash.c: Do not return an error when opening a missing database with O_CREAT
ClosedPublic
Actions

Authored by bnovkov on Jul 24 2025, 3:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 12:28 PM
Unknown Object (File)
Mon, Oct 13, 12:28 PM
Unknown Object (File)
Sun, Oct 12, 11:52 PM
Unknown Object (File)
Sun, Oct 12, 12:22 PM
Unknown Object (File)
Wed, Oct 8, 8:38 PM
Unknown Object (File)
Thu, Oct 2, 6:14 AM
Unknown Object (File)
Fri, Sep 26, 5:28 AM
Unknown Object (File)
Sep 18 2025, 4:17 AM
View All 28 Files
Subscribers
imp

Details

Reviewers
markj
Group Reviewers
Klara
Commits
rG108e2d1137aa: db/hash.c: Do not return an error when opening a missing database with O_CREAT
Summary

dbm_open currently returns an error when opening a missing database
with O_CREAT but creates the request database file. This is caused
by a buggy check in __hash_open which attempts to detect a new
(or empty) database file, but fails to take the O_CREAT flag into
account.

Fix this by expanding the check to include O_CREAT.

Fixes: edcdc752ecdd
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
libc/
db/
hash/
3 lines

Diff 159056

View Options

lib/libc/db/hash/hash.c

Loading...