Page MenuHomeFreeBSD
Differential D51491

db/hash.c: Do not return an error when opening a missing database with O_CREAT
ClosedPublic
Actions

Authored by bnovkov on Jul 24 2025, 3:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 15, 1:32 AM
Unknown Object (File)
Wed, Aug 12, 2:54 PM
Unknown Object (File)
Wed, Aug 12, 1:58 PM
Unknown Object (File)
Wed, Aug 12, 1:57 PM
Unknown Object (File)
Wed, Aug 12, 1:57 PM
Unknown Object (File)
Tue, Aug 11, 7:06 PM
Unknown Object (File)
Tue, Aug 11, 5:01 PM
Unknown Object (File)
Mon, Aug 10, 10:25 AM
View All 81 Files
Subscribers
imp

Details

Reviewers
markj
Group Reviewers
Klara
Commits
rG108e2d1137aa: db/hash.c: Do not return an error when opening a missing database with O_CREAT
Summary

dbm_open currently returns an error when opening a missing database
with O_CREAT but creates the request database file. This is caused
by a buggy check in __hash_open which attempts to detect a new
(or empty) database file, but fails to take the O_CREAT flag into
account.

Fix this by expanding the check to include O_CREAT.

Fixes: edcdc752ecdd
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
libc/
db/
hash/
3 lines

Diff 159056

View Options

lib/libc/db/hash/hash.c

Loading...