Page MenuHomeFreeBSD

dbm_nextkey: Always return an error if we've reached the end of the database
ClosedPublic

Authored by bnovkov on Jul 30 2025, 2:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 1:22 AM
Unknown Object (File)
Sun, Oct 12, 1:22 AM
Unknown Object (File)
Sat, Oct 11, 3:51 PM
Unknown Object (File)
Sat, Oct 11, 3:51 PM
Unknown Object (File)
Sat, Oct 11, 3:51 PM
Unknown Object (File)
Sat, Oct 11, 7:22 AM
Unknown Object (File)
Thu, Oct 9, 5:02 PM
Unknown Object (File)
Wed, Oct 8, 10:05 PM
Subscribers

Details

Summary

POSIX.1 states that dbm_nextkey must return an invalid key
(i.e., key.dptr == NULL) after the end of the database was reached.
The current implementation of hash_seq will incorrectly restart
the key sequence after the end of the database is reached.

Fix this by checking the "current bucket" index when R_NEXT is passed.

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj added inline comments.
lib/libc/db/hash/hash.c
718

Is it legal to call this routine with flag == 0? The check above suggests so, but within libc there are no such calls. Are consumers allowed to call db->seq() directly?

Address @markj 's comments.

lib/libc/db/hash/hash.c
718

Good catch, thanks.
Consumers can call db->seq() directly, I've placed an additional check for flag == 0.

markj added inline comments.
lib/libc/db/hash/hash.c
707

The !flag test is redundant.

This revision is now accepted and ready to land.Jul 31 2025, 3:09 PM