release: Consistently use variables for invoking certain tools

[bnovkov]

Summary

This change cleans up the inconsistent ways of invoking makefs and mkimg
by making sure that these tools are invoked through their corresponding
variables. This was previously only used in a few amd64 and arm64 release
scripts.

Sponsored by: Klara, Inc.
Sponsored by: The FreeBSD Foundation

[bnovkov]

Remove stray Makefile.firecracker change.

[markj]

release/amd64/make-memstick.sh

16

Are you sure the path is right? $scriptdir is /usr/src/release/amd64. It looks like this should be ${scriptdir}/../scripts/tools.subr. Note that install-boot.sh lives outside of the release dir.

[bnovkov]

Address @markj 's comments - fix include path

[bnovkov]

release/amd64/make-memstick.sh

16

whoops, that's a silly mistake, thanks for catching this!

[bnovkov]

Correct include path in vmimage.subr

[markj]

release/tools/vmimage.subr

9

I think this one is still wrong, since tools.subr lives in scripts/ and not tools/. (Though the distinction between the two is not really clear to me.)

[markj]

release/tools/vmimage.subr

9

[bnovkov]

Address @markj 's comments.