Page MenuHomeFreeBSD

vm: Fix error handling in vm_thread_stack_back()
ClosedPublic

Authored by markj on Apr 29 2024, 11:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 4 2024, 8:06 AM
Unknown Object (File)
May 3 2024, 4:17 PM
Unknown Object (File)
Apr 30 2024, 9:58 PM
Unknown Object (File)
Apr 30 2024, 7:57 PM
Unknown Object (File)
Apr 30 2024, 6:01 PM
Unknown Object (File)
Apr 30 2024, 5:46 PM
Unknown Object (File)
Apr 30 2024, 2:00 PM
Unknown Object (File)
Apr 30 2024, 1:53 PM
Subscribers

Details

Summary

vm_object_page_remove() wants to busy the page, but that won't work
here. (Kernel stack pages are always busy.)

Make the error handling path look more like vm_thread_stack_dispose().

Reported by: pho
Fixes: 7a79d0669761 ("vm: improve kstack_object pindex calculation to avoid pindex holes")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib added inline comments.
sys/vm/vm_glue.c
635

This blank line is not needed.

This revision is now accepted and ready to land.Apr 30 2024, 12:19 AM