Page MenuHomeFreeBSD

vm: Fix error handling in vm_thread_stack_back()
ClosedPublic

Authored by markj on Apr 29 2024, 11:56 PM.
Tags
None
Referenced Files
F115005492: D45019.id137860.diff
Sat, Apr 19, 12:55 PM
Unknown Object (File)
Tue, Apr 15, 2:02 AM
Unknown Object (File)
Mar 19 2025, 8:18 AM
Unknown Object (File)
Mar 17 2025, 4:02 AM
Unknown Object (File)
Mar 17 2025, 1:53 AM
Unknown Object (File)
Mar 15 2025, 2:25 PM
Unknown Object (File)
Feb 26 2025, 3:53 PM
Unknown Object (File)
Feb 20 2025, 1:53 AM
Subscribers

Details

Summary

vm_object_page_remove() wants to busy the page, but that won't work
here. (Kernel stack pages are always busy.)

Make the error handling path look more like vm_thread_stack_dispose().

Reported by: pho
Fixes: 7a79d0669761 ("vm: improve kstack_object pindex calculation to avoid pindex holes")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib added inline comments.
sys/vm/vm_glue.c
635

This blank line is not needed.

This revision is now accepted and ready to land.Apr 30 2024, 12:19 AM