sssd
ClosedPublic
Actions

Authored by kiwi on Thu, Jan 9, 8:39 AM.

Details

Reviewers

garga
0mp

Commits

R11:6971a62a23da: security/sudo: Remove dependency on security/sssd

Summary

security/sudo: Remove dependency on security/sssd

security/sssd was removed from ports recently, which broke
the SSSD option. Let's remove the SSSD option and let users
use SSSD2 instead.

PORTREVISION has been bumped so it is easier to tell which
version of the sudo package supports only sssd2.

PR:     283952
Sponsored by:   Klara, Inc.
Approved by:    0mp (mentor)
Approved by:    garga (maintainer)

Test Plan

Port has been portlinted and portclippy(ed).
Tested on poudriere with SSSD2 set or unset

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kiwi requested review of this revision.Thu, Jan 9, 8:39 AM

kiwi created this revision.

kiwi edited the summary of this revision. (Show Details)Thu, Jan 9, 8:47 AM

kiwi edited the test plan for this revision. (Show Details)

Suggestions for the commit message:

security/sudo: Remove broken option SSSD

security/sssd was removed from ports recently, which broke
the SSSD option. Let's remove the SSSD option and let users
use SSSD2 instead.

PORTREVISION has been bumped so it is easier to tell which
version of the sudo package supports only sssd2.

PR:     283952
Sponsored by:   Klara, Inc.
Approved by:    0mp (mentor)

The following comment:

On this patch SSSD2 config knob is still used. Maybe we should consider to renaming to SSSD ?

is targeted at the maintainer and should be addressed before the commit lands upstream.

Otherwise, the commit looks good. Ping me again for the final review when you get the approval of the maintainer (or a timeout).

Note: security/sudo: Remove dependency on security/sssd is not a bad title either.

LGTM

This revision is now accepted and ready to land.Thu, Jan 9, 3:45 PM

kiwi retitled this revision from [PATCH] security/sudo: remove dependency on security/sssd to [PATCH] security/sudo: Remove dependency on security/sssd.Fri, Jan 10, 9:37 AM

kiwi edited the summary of this revision. (Show Details)

Looks solid and the maintainer has approved the change. Ship it!

Closed by commit R11:6971a62a23da: security/sudo: Remove dependency on security/sssd (authored by kiwi). · Explain WhyFri, Jan 10, 12:55 PM

This revision was automatically updated to reflect the committed changes.

kiwi added a commit: R11:6971a62a23da: security/sudo: Remove dependency on security/sssd.

kiwi mentioned this in D48147: [PATCH] security/sudo: Add sssd flavor.Fri, Jan 10, 4:38 PM