Page MenuHomeFreeBSD
Differential D51301

dtrace.1: Document evaltime
ClosedPublic
Actions

Authored by 0mp on Jul 14 2025, 2:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 11:09 PM
Unknown Object (File)
Sat, Oct 11, 1:48 PM
Unknown Object (File)
Sat, Oct 11, 1:48 PM
Unknown Object (File)
Sat, Oct 11, 1:48 PM
Unknown Object (File)
Sat, Oct 11, 1:47 PM
Unknown Object (File)
Sat, Oct 11, 1:47 PM
Unknown Object (File)
Sat, Oct 11, 1:47 PM
Unknown Object (File)
Sat, Oct 11, 5:29 AM
View All 43 Files
Subscribers
imp
ziaee

Details

Reviewers
gnn
christos
markj
dteske
Commits
rG1fe7af063581: dtrace.1: Document evaltime
Summary

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp created this revision.Jul 14 2025, 2:52 PM
Herald added a reviewer: gnn. · View Herald TranscriptJul 14 2025, 2:52 PM
Herald added subscribers: ziaee, imp. · View Herald Transcript
0mp requested review of this revision.Jul 14 2025, 2:52 PM
Harbormaster completed remote builds in B65416: Diff 158469.Jul 14 2025, 2:52 PM
0mp added reviewers: christos, markj, dteske.Jul 14 2025, 2:53 PM
0mp added inline comments.
cddl/contrib/opensolaris/cmd/dtrace/dtrace.1
651

The default on illumos is different, so I think it makes sense to note here that this is FreeBSD's default explicitly.

christos added a comment.Jul 14 2025, 3:05 PM

In the first paragraph it is not immediately clear (to me at least) what this variable actually does. I especially get quite confused with what "newly started child process" means. Does it refer to the command defined in -c cmd? Or is it something else? I think the wording needs some improvement there.

cddl/contrib/opensolaris/cmd/dtrace/dtrace.1
631
660
0mp updated this revision to Diff 158481.Jul 14 2025, 3:18 PM
0mp marked 2 inline comments as done.
  • Address feedback
  • Turn the process create mode list into a table. Looks better and is a bit more concise.
Harbormaster completed remote builds in B65424: Diff 158481.Jul 14 2025, 3:18 PM
0mp added a comment.Jul 14 2025, 3:18 PM
In D51301#1171643, @christos wrote:

In the first paragraph it is not immediately clear (to me at least) what this variable actually does. I especially get quite confused with what "newly started child process" means. Does it refer to the command defined in -c cmd? Or is it something else? I think the wording needs some improvement there.

Good point! I've tried to address that in the new revision.

christos added inline comments.Jul 14 2025, 3:21 PM
cddl/contrib/opensolaris/cmd/dtrace/dtrace.1
631–633
0mp updated this revision to Diff 158482.Jul 14 2025, 3:36 PM
0mp marked an inline comment as done.
  • Address feedback
Harbormaster completed remote builds in B65425: Diff 158482.Jul 14 2025, 3:36 PM
0mp added inline comments.Jul 14 2025, 3:36 PM
cddl/contrib/opensolaris/cmd/dtrace/dtrace.1
631–633

Yeah, perhaps it makes no sense to distinguish between evaluating and instrumenting.

christos accepted this revision.Jul 14 2025, 3:46 PM
This revision is now accepted and ready to land.Jul 14 2025, 3:46 PM
ziaee added inline comments.Jul 14 2025, 3:50 PM
cddl/contrib/opensolaris/cmd/dtrace/dtrace.1
630

Is this the same d(7) youve been writing a manual on? If so, Xr would be helpful!

0mp added inline comments.Jul 14 2025, 4:33 PM
cddl/contrib/opensolaris/cmd/dtrace/dtrace.1
630

Good idea!

Closed by commit rG1fe7af063581: dtrace.1: Document evaltime (authored by 0mp). · Explain WhyJul 14 2025, 4:40 PM
This revision was automatically updated to reflect the committed changes.
0mp added a commit: rG1fe7af063581: dtrace.1: Document evaltime.

Revision Contents
Changeset List

PathSize
cddl/
contrib/
opensolaris/
cmd/
dtrace/
48 lines

Diff 158486

View Options

cddl/contrib/opensolaris/cmd/dtrace/dtrace.1

Loading...