Page MenuHomeFreeBSD
Feed Advanced Search

Fri, Oct 15

mhorne accepted D32493: Add userland boot profiling to TSLOG.
Fri, Oct 15, 8:22 PM
mhorne added a comment to D32493: Add userland boot profiling to TSLOG.

Thanks, I love the simplicity of this.

Fri, Oct 15, 4:48 PM
mhorne added inline comments to D29959: xen/devices: purge uses of intr_machdep.h.
Fri, Oct 15, 4:10 PM
mhorne committed R10:aa794b82ef88: arm, arm64, riscv: adjust top-level nexus comment (authored by mhorne).
arm, arm64, riscv: adjust top-level nexus comment
Fri, Oct 15, 3:27 PM
mhorne committed R10:d925085dcdbd: riscv: fix VM_MAXUSER_ADDRESS checks in asm routines (authored by mhorne).
riscv: fix VM_MAXUSER_ADDRESS checks in asm routines
Fri, Oct 15, 3:27 PM
mhorne committed R10:43f5da70cc96: riscv: handle page faults in the unmappable region (authored by mhorne).
riscv: handle page faults in the unmappable region
Fri, Oct 15, 3:27 PM
mhorne committed R10:89f1b82a859f: libpmc: fix the 'cycles' event alias on x86 (authored by mhorne).
libpmc: fix the 'cycles' event alias on x86
Fri, Oct 15, 3:27 PM
mhorne committed R10:3c01f7415067: libpmc: add some AMD pmu counter aliases (authored by mhorne).
libpmc: add some AMD pmu counter aliases
Fri, Oct 15, 3:27 PM
mhorne committed R10:fc7febf483a4: minidump: De-duplicate the progress bar (authored by mhorne).
minidump: De-duplicate the progress bar
Fri, Oct 15, 3:27 PM
mhorne committed R10:5794f8c75ef1: minidump: De-duplicate is_dumpable() (authored by mhorne).
minidump: De-duplicate is_dumpable()
Fri, Oct 15, 3:26 PM

Wed, Oct 13

mhorne added a comment to D32321: Add support of ARM CMN-600 controller, PMU access functions only. Add support of PMU counters of ARM CMN-600 controller..

A few minor comments, I've looked mainly at hwpmc_cmn600.c so far.

Wed, Oct 13, 7:53 PM
mhorne added a comment to D32320: Allocate event for DMC-620 and CMN-600 controllers PMU. Add events supported by DMC-620 and CMN-600 controllers PMU..

Is there a review for a dmc620 driver still to come?

Wed, Oct 13, 7:29 PM
mhorne added inline comments to D32477: kenv: allow static hints to disable loader hints.
Wed, Oct 13, 6:07 PM
mhorne added a comment to D32477: kenv: allow static hints to disable loader hints.

Seems good to me. One thing missing is loader_hints.disabled needs an entry in the config(5) man page.

Wed, Oct 13, 6:01 PM

Tue, Oct 12

mhorne accepted D32445: riscv: Implement pmap_mapdev_attr.
Tue, Oct 12, 1:48 PM
mhorne accepted D29959: xen/devices: purge uses of intr_machdep.h.

This seems fine, these drivers use the xen_intr_ interfaces rather than anything contained in the header. Just one question about pcifront.c.

Tue, Oct 12, 1:19 AM

Mon, Oct 11

mhorne updated the diff for D31929: boottrace(1): small wrapper utility.

Log events as BOOTTRACE rather than RUNTTRACE. We will use the switch to multi-user mode as the mark between boot and run-time tracing.

Mon, Oct 11, 3:45 PM
mhorne added a comment to D30187: boottrace: trace annotations for startup and shutdown.

Hi Colin, thanks for the comments and apologies that it has taken some time for me to update this patch.

Mon, Oct 11, 3:12 PM
mhorne updated the diff for D30187: boottrace: trace annotations for startup and shutdown.

Simplify the trace calls somewhat with the BOOTTRACE() macro. Now, printf-like arguments are supported.

Mon, Oct 11, 3:04 PM
mhorne updated the diff for D30184: boottrace: a simple boot and shutdown-time tracing facility.

Rebase and update after a few rounds of cleanups and testing.

Mon, Oct 11, 3:02 PM
mhorne added a comment to D30006: xen/intr: adjust xen_intr_handle_upcall() to match interrupt filter.

@mhorne I think you got mixed up on the direction this is going.

Presently there are two paths which lead to xen_intr_handle_upcall():

  1. apic_vector.S (x86 assembly/raw interrupt vectors) => xen_intr.c/xen_intr_handle_upcall()
  2. xenpci.c/BUS_SETUP_INTR() => xenpci.c/xenpci_intr_filter() => xen_intr.c/xen_intr_handle_upcall()

I want to rearrange this sequence to add a third caller:

  1. apic_vector.S (interrupt) => x86/xen_arch_intr.c/xen_arch_intr_handle_upcall() => xen_intr.c/xen_intr_handle_upcall()
  2. xenpci.c/BUS_SETUP_INTR() => xen_intr.c/xen_intr_handle_upcall()
  3. arm64/xen_arch_intr.c/bus_setup_intr() (D29875) => xen_intr.c/xen_intr_handle_upcall()

There are two reasons for changing like this. First, some bits of x86-specific code are still in xen_intr_handle_upcall(); notably the interrupt counter increment, critical_enter()/critical_exit() calls and lapic_eoi() call. Second, in theory a device_filter_t function has the capability to report stray interrupts, but any such reporting is lost with the present signature of xen_intr_handle_upcall().

Mon, Oct 11, 12:13 AM

Sun, Oct 10

mhorne added a comment to D30006: xen/intr: adjust xen_intr_handle_upcall() to match interrupt filter.

Due to exploring elsewhere the issue of the struct trapframe has shown. I'm uncertain how to handle correctly. In its present form, this should behave identically to the previous version. Issue is there is a problem with the present form and I'm wondering whether the present form is correct.

The behavior of passing the trap frame as the argument is undocumented behavior for bus_setup_intr(). I've also encountered several mentions of peripheral interrupt controllers passing NULL trap frames.

Sun, Oct 10, 6:27 PM

Fri, Oct 8

mhorne committed R10:17f790f49f58: arm, arm64, riscv: adjust top-level nexus comment (authored by mhorne).
arm, arm64, riscv: adjust top-level nexus comment
Fri, Oct 8, 5:17 PM
mhorne closed D32358: arm,arm64,riscv: adjust top-level nexus comment.
Fri, Oct 8, 5:17 PM
mhorne added a comment to D32346: sys: add trap frame compatibility macros.

Okay, let's take a step back here.

Fri, Oct 8, 4:54 PM
mhorne added inline comments to D30554: ofwbus: remove handling of resources from ofwbus.
Fri, Oct 8, 2:46 PM

Thu, Oct 7

mhorne closed D31209: riscv: fix VM_MAXUSER_ADDRESS checks in asm routines.
Thu, Oct 7, 9:19 PM
mhorne committed R10:8babb5582eed: riscv: fix VM_MAXUSER_ADDRESS checks in asm routines (authored by mhorne).
riscv: fix VM_MAXUSER_ADDRESS checks in asm routines
Thu, Oct 7, 9:19 PM
mhorne closed D31208: riscv: handle page faults in the unmappable region.
Thu, Oct 7, 9:19 PM
mhorne committed R10:4a9f2f8b07c2: riscv: handle page faults in the unmappable region (authored by mhorne).
riscv: handle page faults in the unmappable region
Thu, Oct 7, 9:19 PM
mhorne updated the diff for D31208: riscv: handle page faults in the unmappable region.

Add the hex prefix.

Thu, Oct 7, 7:17 PM
mhorne added inline comments to D31208: riscv: handle page faults in the unmappable region.
Thu, Oct 7, 7:15 PM
mhorne updated the diff for D31208: riscv: handle page faults in the unmappable region.

Handle !VIRT_IS_VALID for the usermode case.

Thu, Oct 7, 7:13 PM
mhorne added a comment to D31209: riscv: fix VM_MAXUSER_ADDRESS checks in asm routines.

Add a test case to kern_copyin.c.

Thanks.

It seems the hang cannot be triggered with a call to write(2), so use fcntl(2) as is done in the PR.

Any idea why?

Thu, Oct 7, 6:28 PM
mhorne requested review of D32358: arm,arm64,riscv: adjust top-level nexus comment.
Thu, Oct 7, 6:04 PM
mhorne added a reviewer for D30554: ofwbus: remove handling of resources from ofwbus: PowerPC.

Okay, I was able to boot this on a few devices for arm, arm64, and riscv.

Thu, Oct 7, 5:59 PM
mhorne requested review of D32357: arm: add an interrupt rman to nexus.
Thu, Oct 7, 5:58 PM
mhorne edited P518 devinfo -u on armv7.
Thu, Oct 7, 5:49 PM
mhorne edited P518 devinfo -u on armv7.
Thu, Oct 7, 5:48 PM
mhorne created P518 devinfo -u on armv7.
Thu, Oct 7, 5:47 PM
mhorne created P517 devinfo -u on riscv.
Thu, Oct 7, 4:47 PM
mhorne accepted D32345: sys: add uses of driver_filter_t where appropriate.

Seems fine to me. Is this exhaustive or is it just the drivers you encountered?

Thu, Oct 7, 4:10 PM
mhorne requested changes to D32346: sys: add trap frame compatibility macros.

Overall, I don't like the idea of making changes to working code for the benefit of a feature that is incomplete and has never been enabled. IMO any action on INTR_SOLO requires a more thorough set of changes + testing to make it production ready. It would probably be equally fine to remove it at this point.

Thu, Oct 7, 4:04 PM

Wed, Oct 6

mhorne updated the test plan for D32343: physmem: add ram0 pseudo-driver.
Wed, Oct 6, 8:10 PM
mhorne requested review of D32343: physmem: add ram0 pseudo-driver.
Wed, Oct 6, 8:02 PM

Tue, Oct 5

mhorne updated the diff for D31208: riscv: handle page faults in the unmappable region.

Handle jrtc27's suggestion, add VIRT_IS_VALID() to vmparam.h.

Tue, Oct 5, 6:49 PM
mhorne retitled D31209: riscv: fix VM_MAXUSER_ADDRESS checks in asm routines from riscv: fix bounds checking in copyinout.S routines to riscv: fix VM_MAXUSER_ADDRESS checks in asm routines.
Tue, Oct 5, 6:10 PM
mhorne updated the diff for D31209: riscv: fix VM_MAXUSER_ADDRESS checks in asm routines.

Apply the change to routines in support.S as well.

Tue, Oct 5, 6:09 PM

Mon, Oct 4

mhorne committed R10:a3acb379bdea: rman: fix overflow in rman_reserve_resource_bound() (authored by ehem_freebsd_m5p.com).
rman: fix overflow in rman_reserve_resource_bound()
Mon, Oct 4, 2:19 PM
mhorne committed R10:26337c10f060: boot(9): update to match reality (authored by mhorne).
boot(9): update to match reality
Mon, Oct 4, 2:19 PM
mhorne committed R10:8e43767b3180: rman: fix overflow in rman_reserve_resource_bound() (authored by ehem_freebsd_m5p.com).
rman: fix overflow in rman_reserve_resource_bound()
Mon, Oct 4, 2:13 PM
mhorne committed R10:68628f462093: boot(9): update to match reality (authored by mhorne).
boot(9): update to match reality
Mon, Oct 4, 2:13 PM

Thu, Sep 30

mhorne committed R10:a20c10893eb1: libpmc: add some AMD pmu counter aliases (authored by mhorne).
libpmc: add some AMD pmu counter aliases
Thu, Sep 30, 2:17 PM
mhorne committed R10:937539e0a32c: libpmc: fix the 'cycles' event alias on x86 (authored by mhorne).
libpmc: fix the 'cycles' event alias on x86
Thu, Sep 30, 2:17 PM
mhorne closed D32162: libpmc: add some AMD pmu counter aliases.
Thu, Sep 30, 2:17 PM
mhorne closed D32197: libpmc: fix the 'cycles' event alias on x86.
Thu, Sep 30, 2:17 PM

Wed, Sep 29

mhorne committed R10:31991a5a4585: minidump: De-duplicate is_dumpable() (authored by mhorne).
minidump: De-duplicate is_dumpable()
Wed, Sep 29, 7:43 PM
mhorne committed R10:ab4ed843a303: minidump: De-duplicate the progress bar (authored by mhorne).
minidump: De-duplicate the progress bar
Wed, Sep 29, 7:43 PM
mhorne closed D31885: minidump: De-duplicate the progress bar.
Wed, Sep 29, 7:43 PM
mhorne closed D31884: minidump: De-duplicate is_dumpable().
Wed, Sep 29, 7:43 PM
mhorne closed D32213: freebsd-src-lsp: fix bear '--append' flag.
Wed, Sep 29, 3:44 PM
mhorne committed R9:c85cbe1b3ff3: freebsd-src-lsp: fix bear '--append' flag (authored by mhorne).
freebsd-src-lsp: fix bear '--append' flag
Wed, Sep 29, 3:44 PM
mhorne committed R10:440c645b8f14: sdhci: add a missing newline (authored by mhorne).
sdhci: add a missing newline
Wed, Sep 29, 2:40 PM

Tue, Sep 28

mhorne requested review of D32213: freebsd-src-lsp: fix bear '--append' flag.
Tue, Sep 28, 9:26 PM
mhorne closed D32085: boot(9): update to match reality.
Tue, Sep 28, 2:39 PM
mhorne committed R10:800e74955d4e: boot(9): update to match reality (authored by mhorne).
boot(9): update to match reality
Tue, Sep 28, 2:39 PM
mhorne committed R10:22e68eadc50d: bcm2835_sdhci: don't use DMA for kernel dumps (authored by mhorne).
bcm2835_sdhci: don't use DMA for kernel dumps
Tue, Sep 28, 2:25 PM
mhorne committed R10:a7a54bf8c33f: bcm2835_sdhci: don't use DMA for kernel dumps (authored by mhorne).
bcm2835_sdhci: don't use DMA for kernel dumps
Tue, Sep 28, 2:23 PM
mhorne updated the diff for D32162: libpmc: add some AMD pmu counter aliases.

Drop non-functional 'cycles' alias in favor of D32197.

Tue, Sep 28, 2:05 PM
mhorne requested review of D32197: libpmc: fix the 'cycles' event alias on x86.
Tue, Sep 28, 2:04 PM
mhorne added inline comments to D32162: libpmc: add some AMD pmu counter aliases.
Tue, Sep 28, 1:37 PM

Mon, Sep 27

mhorne requested review of D32162: libpmc: add some AMD pmu counter aliases.
Mon, Sep 27, 7:48 PM
mhorne added a comment to D31312: kern/rman: warn/KASSERT() on garbled reservations.

@ehem_freebsd_m5p.com I committed the KASSERT alongside D30280, so this can be closed (but you will need to do it).

Mon, Sep 27, 5:42 PM
mhorne closed D30280: kern/rman: fix overflow in rman_reserve_resource_bound().
Mon, Sep 27, 5:40 PM
mhorne committed R10:bcddaadbef58: rman: fix overflow in rman_reserve_resource_bound() (authored by ehem_freebsd_m5p.com).
rman: fix overflow in rman_reserve_resource_bound()
Mon, Sep 27, 5:40 PM

Thu, Sep 23

mhorne closed D31494: developers-handbook: update the section on Remote GDB.
Thu, Sep 23, 8:30 PM
mhorne committed R9:f978ca7e8e79: developers-handbook: update the section on Remote GDB (authored by mhorne).
developers-handbook: update the section on Remote GDB
Thu, Sep 23, 8:30 PM
mhorne requested review of D32085: boot(9): update to match reality.
Thu, Sep 23, 7:23 PM
mhorne added a comment to D31494: developers-handbook: update the section on Remote GDB.

Thanks for writing this up @mhorne, much appreciated! I've left a few comments from my experience of setting it up with QEMU + KVM today and the confusion I had while reading the existing documentation, as well as the confusion that I would probably have while reading this.

I wonder if it might make sense to explicitly state that the procedure for virtualization gdb stubs may be different depending on which hypervisor/emulator is being used, and then in follow-up commits (by you or anyone else really) document the procedure for each given hypervisor?

Thu, Sep 23, 5:05 PM
mhorne updated the diff for D31494: developers-handbook: update the section on Remote GDB.
  • Change the flow of the example so that it doesn't require DDB
  • Mention that GDB is enabled in GENERIC on main
  • Add a tip about local vars and optimization levels
  • Other small wording/formatting improvements
Thu, Sep 23, 5:03 PM

Wed, Sep 22

mhorne accepted D31962: linux: For better compatibility, provide compatible endian.h.

Seems straightforward. Are there any manpages that need updating? Should FreeBSD sources still prefer sys/endian.h going forward, and is that mentioned anywhere?

Wed, Sep 22, 5:01 PM
mhorne accepted D32055: pmc: intr pmc.soft(3) update.

Thank you for handling this. One small note which you can fix before commit. Don't forget to bump .Dd, of course :)

Wed, Sep 22, 2:33 PM

Tue, Sep 21

mhorne added a comment to D32053: Allow ddb and dtrace use the DMAP region on arm64.

Why should the DMAP alias be writable? Its protections are supposed to be kept in sync with the corresponding KVA page. You add a comment to this effect in D32026, but I think pmap_change_props_locked() is still missing the code that actually updates the DMAP protections (at least I don't see it).

Tue, Sep 21, 7:27 PM
mhorne updated the diff for D31993: Allow minidumps to be performed on the live system.

Fix the assertions, first cut at a more detailed block comment.

Tue, Sep 21, 6:57 PM
mhorne updated the diff for D31992: minidump: Use the provided dump bitset.

Add helpers to eliminate code churn outside of minidump_machdep.c.

Tue, Sep 21, 6:56 PM
mhorne updated the diff for D31989: minidump: Parameterize minidumpsys().

Make the state pointer const.

Tue, Sep 21, 6:54 PM
mhorne updated the diff for D31884: minidump: De-duplicate is_dumpable().

Move function to vm_phys.c, rename it to vm_phys_is_dumpable().

Tue, Sep 21, 6:53 PM
mhorne added a comment to D32026: Add pmap_change_prot on arm64.

Enabling this will limit the ability to set breakpoints or fbt probes on preloaded modules. On amd64 there is a global write-protect bit that is disabled before these operations, but on arm64 we will need something more fine-grained. Do you have plans to handle this?

Tue, Sep 21, 2:33 PM
mhorne committed R10:806ebc9eba2a: bcm2835_sdhci: don't use DMA for kernel dumps (authored by mhorne).
bcm2835_sdhci: don't use DMA for kernel dumps
Tue, Sep 21, 1:10 PM
mhorne closed D31893: bcm2835_sdhci: don't use DMA for kernel dumps.
Tue, Sep 21, 1:10 PM

Mon, Sep 20

mhorne added a comment to D31893: bcm2835_sdhci: don't use DMA for kernel dumps.

Gentle ping.

Mon, Sep 20, 7:45 PM

Sep 17 2021

mhorne accepted D31995: xen/intr: add check for intr_register_source() errors.

Looks fine to me. I would suggest keeping the KASSERT though, it is free and makes the point of failure more obvious if this condition did occur.

Sep 17 2021, 12:27 PM

Sep 16 2021

mhorne added inline comments to D31993: Allow minidumps to be performed on the live system.
Sep 16 2021, 7:30 PM
mhorne added inline comments to D31990: minidump: reduce the amount direct accesses to page tables.
Sep 16 2021, 6:59 PM
mhorne added a reviewer for D31992: minidump: Use the provided dump bitset: luporl.

This is mostly mechanical. state->dump_bitset should be used inside each minidump_machdep.c, and vm_page_dump everywhere else. The one exception to this is powerpc's dumpsys_scan_pmap() method, which is extended to also accept a bitset argument.

Sep 16 2021, 6:51 PM
mhorne updated the test plan for D31990: minidump: reduce the amount direct accesses to page tables.
Sep 16 2021, 6:47 PM
mhorne added reviewers for D31993: Allow minidumps to be performed on the live system: markj, kib, jhb, stevek.
Sep 16 2021, 6:45 PM
mhorne added reviewers for D31992: minidump: Use the provided dump bitset: markj, kib, jhb, stevek.
Sep 16 2021, 6:44 PM
mhorne added reviewers for D31991: minidump: Use provided msgbuf pointer: markj, kib, jhb, stevek.
Sep 16 2021, 6:43 PM
mhorne added reviewers for D31990: minidump: reduce the amount direct accesses to page tables: markj, kib, jhb, stevek.
Sep 16 2021, 6:42 PM