Page MenuHomeFreeBSD
Feed Advanced Search

Mon, Jun 2

mhorne accepted D50545: mlx.4: Improve specificity for apropos + hw notes.

Seems fine to me, but I am not an authority on the subject matter.

Mon, Jun 2, 6:41 PM
mhorne accepted D50608: uftdi.4: Makeover!.
Mon, Jun 2, 6:37 PM

Wed, May 28

mhorne accepted D50525: HW Relnotes: Improve gve.
Wed, May 28, 6:13 PM
mhorne accepted D50526: HW Relnotes: Remove traces of sio(4).

Please check the commit description before pushing.

Wed, May 28, 6:11 PM
mhorne accepted D50522: HW Relnotes: Remove traces of cy, rc, rp drivers.
Wed, May 28, 6:10 PM
mhorne accepted D50527: HW Relnotes: Remove traces of ar(4).
Wed, May 28, 6:09 PM
mhorne accepted D50541: cdce.4: Improve HARDWARE.

Looks good, I am somewhat

Wed, May 28, 6:06 PM
mhorne accepted D50374: usb/if_mos.c: Fix incorrect SPDX ID.
Wed, May 28, 5:59 PM
mhorne accepted D50540: aue.4: Improve HARDWARE, specificity, and tag spdx.
Wed, May 28, 5:58 PM
mhorne accepted D50529: rtsx.4: Improve hardware, add history and spdx.
Wed, May 28, 5:57 PM
mhorne accepted D50528: scc.4: Improve acronyms + tag SPDX.
Wed, May 28, 5:56 PM
mhorne accepted D50440: pam_xdg.8: Improve usage and standards.
Wed, May 28, 5:55 PM
mhorne accepted D50523: axge.4: Create a HARDWARE section.
Wed, May 28, 5:52 PM

May 20 2025

mhorne added a comment to D48401: bhyvectl.8: Polish.

Approved, please go ahead and commit this.

May 20 2025, 3:36 PM

May 18 2025

mhorne added a comment to D50410: style.mdoc: Ask for maintainable wrapping.

Oh spare me your wounded pride and perceived victimhood.

May 18 2025, 7:54 PM
mhorne added a comment to D48401: bhyvectl.8: Polish.

The subject of line-breaks is infinitely bikesheddable, so I will state my opinion here once more and then never again.

May 18 2025, 4:16 PM
mhorne added a reviewer for D50403: HW Relnotes: Add remaining Cryptographic Accelerators: markj.
May 18 2025, 3:51 PM
mhorne added a comment to D50402: HW Relnotes: Add safexcel to Cryptographic Accelerators.

So, should it also be expanded/applied to the various hardware notes in this commit (not just the template)?

May 18 2025, 3:42 PM

May 17 2025

mhorne accepted D50395: HW Relnotes: Add qat to Cryptographic Accelerators.
May 17 2025, 9:02 PM

May 16 2025

mhorne accepted D50381: qat.4: Cleanup.
May 16 2025, 8:33 PM
mhorne added a comment to D50381: qat.4: Cleanup.

Overall it is a clear improvement.

May 16 2025, 6:20 PM

May 15 2025

mhorne added inline comments to D50369: riscv: enable allwinner RTC.
May 15 2025, 6:20 PM
mhorne requested review of D50369: riscv: enable allwinner RTC.
May 15 2025, 6:17 PM
mhorne committed rG13e520658ec0: fdt_loader_cmd.c: fix compilation with DEBUG (authored by mhorne).
fdt_loader_cmd.c: fix compilation with DEBUG
May 15 2025, 1:54 PM
mhorne accepted D50358: e6000sw.4: Add HISTORY.
May 15 2025, 12:08 PM

May 14 2025

mhorne accepted D50318: build.7: Document pkgbase PKG_FORMAT variable.
May 14 2025, 3:46 PM
mhorne added a comment to D50330: style.mdoc: add subsection for cross-references.

origin is not a good way to reference a package, I know people are used to it, because at somepoint it was the only to get a unique name which reference a package, but it is not the case anymore, with flavors or even with subpackages.

May 14 2025, 2:34 PM

May 13 2025

mhorne accepted D50324: ar40xx: Initial manual page.
May 13 2025, 3:55 PM
mhorne requested review of D50330: style.mdoc: add subsection for cross-references.
May 13 2025, 2:33 PM
mhorne accepted D50322: arswitch.4: Improve title and add HARDWARE.
May 13 2025, 2:17 PM
mhorne added inline comments to D50320: cxgbetool.8: Fix Minor mechanical issues.
May 13 2025, 2:15 PM
mhorne added inline comments to D50323: adm6996fc.4: Improve description for consistency.
May 13 2025, 2:11 PM
mhorne accepted D50321: e6060sw.4: Improve title and add HARDWARE.
May 13 2025, 2:04 PM
mhorne accepted D50320: cxgbetool.8: Fix Minor mechanical issues.
May 13 2025, 2:03 PM

May 12 2025

mhorne added inline comments to D50318: build.7: Document pkgbase PKG_FORMAT variable.
May 12 2025, 11:45 PM
mhorne accepted D50307: arm: Make the pmap_kenter signature like arm64.
May 12 2025, 6:38 PM
mhorne accepted D50274: cdboot.8: Initial manual page.

Approved.

May 12 2025, 4:05 PM
mhorne accepted D50309: subr_devmap: Implement pmap_mapdev with pmap_mapdev_attr.
May 12 2025, 4:03 PM
mhorne accepted D50308: subr_devmap: Add the function name to KASSERT.
May 12 2025, 4:01 PM
mhorne accepted D50307: arm: Make the pmap_kenter signature like arm64.

LGTM with one tweak.

May 12 2025, 4:01 PM
mhorne added a reviewer for D50303: HW Relnotes: Add a section for Etherswitch: adrian.
May 12 2025, 3:53 PM
mhorne accepted D50293: e6000sw.4: Initial manual page.

Approved.

May 12 2025, 3:44 PM
mhorne added a comment to D50301: umb.4: add "cellular modem driver" to title.

Approved.

May 12 2025, 3:35 PM

May 6 2025

mhorne added a comment to D49768: stand: Enable Spleen 32x64 font in the bootloader.

Approved; with @imp and @tsoome's review I think you can proceed.

May 6 2025, 3:19 PM
mhorne accepted D50191: mccomphy: Guard the definition of mcommphy_yt8531_setup_delay().

Thanks.

May 6 2025, 3:06 PM

May 5 2025

mhorne accepted D50126: UPDATING: Strengthen recommendations.
May 5 2025, 3:03 PM

May 2 2025

mhorne accepted D50119: HW Relnotes: Add iwx(4) to Wireless Networks.
May 2 2025, 7:49 PM
mhorne added a comment to D49687: iwx.4: Initial manual page.

Is that sufficient for me to merge this?

May 2 2025, 7:08 PM
mhorne accepted D49687: iwx.4: Initial manual page.
May 2 2025, 7:03 PM
mhorne added inline comments to D49687: iwx.4: Initial manual page.
May 2 2025, 6:53 PM
mhorne accepted D49687: iwx.4: Initial manual page.

Thanks all for the input. Let us proceed here. Having spoken with the interested parties, I plan to handle the follow-up change describing the driver provenance.

May 2 2025, 5:55 PM

May 1 2025

mhorne closed D50074: mccomphy: add support for YT8531.
May 1 2025, 3:02 PM
mhorne committed rGa592b5fd9d9c: mccomphy: add support for YT8531 (authored by jsihv_gmx.com).
mccomphy: add support for YT8531
May 1 2025, 3:02 PM

Apr 30 2025

mhorne accepted D49671: mount(8): Mention -o rw, polish, sync usage.

Approved.

Apr 30 2025, 6:41 PM
mhorne updated the diff for D50074: mccomphy: add support for YT8531.

Add #ifdef FDT conditionals around mii_fdt.h inclusion and the call to mcommphy_yt8531_setup_delay().

Apr 30 2025, 4:36 PM
mhorne added inline comments to D50074: mccomphy: add support for YT8531.
Apr 30 2025, 4:35 PM
mhorne accepted D50016: subr_devmap: Reduce the use of the static devmap.
Apr 30 2025, 12:18 PM

Apr 29 2025

mhorne added inline comments to D50074: mccomphy: add support for YT8531.
Apr 29 2025, 4:39 PM
mhorne added a comment to D50074: mccomphy: add support for YT8531.

@jsihv_gmx.com you might have seen, I merged this functionality but had to revert as it broke the build on amd64 (!FDT). Here is an updated version which addresses this.

Apr 29 2025, 4:37 PM
mhorne requested review of D50074: mccomphy: add support for YT8531.
Apr 29 2025, 4:30 PM
mhorne accepted D50017: sys: Reduce where we include sys/devmap.h.
Apr 29 2025, 2:07 PM
mhorne accepted D50016: subr_devmap: Reduce the use of the static devmap.

Thanks, this is great.

Apr 29 2025, 2:07 PM

Apr 28 2025

mhorne accepted D50015: subr_devmap: Make devmap_ptov static.
Apr 28 2025, 4:11 PM
mhorne accepted D50014: arm/freescale: Stop using devmap_ptov.
Apr 28 2025, 4:09 PM
mhorne accepted D50013: subr_devmap: Use the arm L1_S macro.
Apr 28 2025, 4:05 PM
mhorne accepted D49937: iwlwifi.4: Update modes for recent 802.11ac.

Commit LGTM, if someone confirms the factual accuracy.

Apr 28 2025, 4:01 PM
mhorne accepted D49762: networking.7: Clarifications.

Approved.

Apr 28 2025, 4:00 PM

Apr 24 2025

mhorne accepted D49988: mount.8: Add a single example for single user mode.

Approved.

Apr 24 2025, 4:18 PM

Apr 3 2025

mhorne added a reverting change for rGe69623451ea6: mccomphy: add support for YT8531: rGb847e406e1df: Revert "mccomphy: add support for YT8531".
Apr 3 2025, 2:28 AM
mhorne committed rGb847e406e1df: Revert "mccomphy: add support for YT8531" (authored by mhorne).
Revert "mccomphy: add support for YT8531"
Apr 3 2025, 2:27 AM
mhorne added a reverting change for D45600: Add StarFive JH7110's Ethernet (eqos & mcommphy modifications, a new board specific file): rGb847e406e1df: Revert "mccomphy: add support for YT8531".
Apr 3 2025, 2:27 AM

Apr 2 2025

mhorne committed rGe69623451ea6: mccomphy: add support for YT8531 (authored by jsihv_gmx.com).
mccomphy: add support for YT8531
Apr 2 2025, 4:58 PM
mhorne committed rGcd92dd23241e: eqos: Add StarFive JH7110 variant (authored by jsihv_gmx.com).
eqos: Add StarFive JH7110 variant
Apr 2 2025, 4:58 PM
mhorne closed D45600: Add StarFive JH7110's Ethernet (eqos & mcommphy modifications, a new board specific file).
Apr 2 2025, 4:57 PM

Apr 1 2025

mhorne accepted D45600: Add StarFive JH7110's Ethernet (eqos & mcommphy modifications, a new board specific file).

Okay, I looked through the code again in detail and things seem good to me.

Apr 1 2025, 1:08 AM

Mar 29 2025

mhorne committed rGd2859cd9e33c: uefisign.8: fix indent (authored by mhorne).
uefisign.8: fix indent
Mar 29 2025, 8:48 PM

Mar 28 2025

mhorne accepted D49543: Correctly track index of first free irq map entry.

The one user-visible difference is that if we avoid reusing freed IDs then we can quickly hit PCI_INVALID_IRQ and get a panic. If we reuse freed IDs then we only hit that panic when we leak an IRQ (which is a separate issue I'm talking to @jhb about).

If someone can figure out how to resolve the "returning PCI_INVALID_IRQ from intr_map_irq makes bad things happen" issue then I agree there will be no functional difference.

Never mind, once the bogus PCI IRQ allocation is gone (D49560) there's no panic because intr_map_irq isn't returning into the PCI code.

So no user-visible difference here.

Mar 28 2025, 6:57 PM
mhorne accepted D49515: top: Sync usage and synopsis.
Mar 28 2025, 5:30 PM
mhorne added a comment to D49522: ps.1: Use ISO/IEC byte units.

Approved.

Mar 28 2025, 5:15 PM
mhorne accepted D49523: hier.7: Storage partitions are not filesystems.

Indeed, I did not read it closely enough :)

Mar 28 2025, 5:13 PM
mhorne accepted D49549: kern.opts.mk: Remove EFI from riscv BROKEN OPTIONS.

Aside from the warning, this should be a no-op, as the only thing gated behind this knob on the kernel side is sys/modules/efirt, which still has an additional MACHINE_CPUARCH check around it.

Mar 28 2025, 5:11 PM
mhorne added a comment to D49543: Correctly track index of first free irq map entry.

IMO it is logically preferable to exhaust all unique/unused IDs before issuing one that was previously assigned, then freed. This is how the current code behaves.

Mar 28 2025, 5:04 PM

Mar 25 2025

mhorne accepted D49462: top: Polish key bindings in usage and manual.

FYI, it is difficult to review a change that reorders and rewords a list of entries, at the same time. In the future such a thing should be split.

Mar 25 2025, 9:32 PM
mhorne added a comment to D49494: Handbook 26.6.1 examples should be git -C /usr/src pull.

I verified that there are no other instances of git -C with git grep and tested the command. @mhorne should I merge this?

Mar 25 2025, 9:21 PM
mhorne accepted D49494: Handbook 26.6.1 examples should be git -C /usr/src pull.
Mar 25 2025, 5:02 PM
mhorne requested changes to D49494: Handbook 26.6.1 examples should be git -C /usr/src pull.

git -C /usr/src pull, as you say in the title.

Mar 25 2025, 3:08 PM

Mar 24 2025

mhorne accepted D49487: riscv timer: fix interrupt handing.
Mar 24 2025, 5:34 PM

Mar 21 2025

mhorne accepted D49204: ports.7: Update dialog4ports to portconfig.

Approved.

Mar 21 2025, 5:48 PM
mhorne accepted D48342: UPDATING: Show plural syntax for PORTS_MODULES.

"show two examples in PORTS_MODULES so it's obvious that they're space separated", can you note something like this in the commit message?

Mar 21 2025, 2:59 PM
mhorne accepted D48343: style.mdoc: HARDWARE generates Release Notes.

LGTM, and Approved.

Mar 21 2025, 2:57 PM
mhorne accepted D48513: etdump.1: Polish + xref cd9660(4).

Approved.

Mar 21 2025, 2:55 PM
mhorne added inline comments to D49204: ports.7: Update dialog4ports to portconfig.
Mar 21 2025, 2:46 PM

Mar 19 2025

mhorne added a comment to D49408: rk_grf_gpio.4: Minor polish.

Thank you, I thought it does need it because I'm proposing changing the copyright header?

Mar 19 2025, 4:40 PM
mhorne accepted D49408: rk_grf_gpio.4: Minor polish.

I ask once again to be mindful of your use of the commit trailers here... The commit does not require "approval" from @shurd, but as the author of the man page (its de-facto maintainer), his "Reviewed by" is meaningful.

Mar 19 2025, 2:48 PM

Mar 18 2025

mhorne accepted D49404: Fix commit date for HPS In Memoriam entry.
Mar 18 2025, 5:28 PM
mhorne abandoned D48849: sdhci: refine locking in sdhci_card_task().

Superseded by aaf0a7302d10.

Mar 18 2025, 1:40 PM
mhorne abandoned D48848: aw_mmc: refine locking in aw_mmc_helper_cd_handler().
Mar 18 2025, 1:39 PM
mhorne added a comment to D48848: aw_mmc: refine locking in aw_mmc_helper_cd_handler().

Superseded by c0bed9bd0bda.

Mar 18 2025, 1:39 PM
mhorne abandoned D48851: dwmmc: refine locking in dwmmc_card_task().

Superseded by c0bed9bd0bda.

Mar 18 2025, 1:39 PM
mhorne abandoned D48846: sdhci: split sdhci_card_task().
Mar 18 2025, 1:38 PM