Seems fine to me, but I am not an authority on the subject matter.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Mon, Jun 2
Wed, May 28
Please check the commit description before pushing.
May 20 2025
Approved, please go ahead and commit this.
May 18 2025
Oh spare me your wounded pride and perceived victimhood.
The subject of line-breaks is infinitely bikesheddable, so I will state my opinion here once more and then never again.
So, should it also be expanded/applied to the various hardware notes in this commit (not just the template)?
May 17 2025
May 16 2025
Overall it is a clear improvement.
May 15 2025
May 14 2025
In D50330#1148832, @bapt wrote:origin is not a good way to reference a package, I know people are used to it, because at somepoint it was the only to get a unique name which reference a package, but it is not the case anymore, with flavors or even with subpackages.
May 13 2025
May 12 2025
LGTM with one tweak.
Approved.
May 6 2025
Thanks.
May 5 2025
May 2 2025
In D49687#1143288, @ziaee wrote:Is that sufficient for me to merge this?
Thanks all for the input. Let us proceed here. Having spoken with the interested parties, I plan to handle the follow-up change describing the driver provenance.
May 1 2025
Apr 30 2025
Add #ifdef FDT conditionals around mii_fdt.h inclusion and the call to mcommphy_yt8531_setup_delay().
Apr 29 2025
@jsihv_gmx.com you might have seen, I merged this functionality but had to revert as it broke the build on amd64 (!FDT). Here is an updated version which addresses this.
Thanks, this is great.
Apr 28 2025
Commit LGTM, if someone confirms the factual accuracy.
Apr 24 2025
Approved.
Apr 3 2025
Apr 2 2025
Apr 1 2025
Okay, I looked through the code again in detail and things seem good to me.
Mar 29 2025
Mar 28 2025
In D49543#1129885, @cperciva wrote:In D49543#1129854, @cperciva wrote:The one user-visible difference is that if we avoid reusing freed IDs then we can quickly hit PCI_INVALID_IRQ and get a panic. If we reuse freed IDs then we only hit that panic when we leak an IRQ (which is a separate issue I'm talking to @jhb about).
If someone can figure out how to resolve the "returning PCI_INVALID_IRQ from intr_map_irq makes bad things happen" issue then I agree there will be no functional difference.
Never mind, once the bogus PCI IRQ allocation is gone (D49560) there's no panic because intr_map_irq isn't returning into the PCI code.
So no user-visible difference here.
Indeed, I did not read it closely enough :)
Aside from the warning, this should be a no-op, as the only thing gated behind this knob on the kernel side is sys/modules/efirt, which still has an additional MACHINE_CPUARCH check around it.
IMO it is logically preferable to exhaust all unique/unused IDs before issuing one that was previously assigned, then freed. This is how the current code behaves.
Mar 25 2025
FYI, it is difficult to review a change that reorders and rewords a list of entries, at the same time. In the future such a thing should be split.
In D49494#1128681, @ziaee wrote:I verified that there are no other instances of git -C with git grep and tested the command. @mhorne should I merge this?
git -C /usr/src pull, as you say in the title.
Mar 24 2025
Mar 21 2025
"show two examples in PORTS_MODULES so it's obvious that they're space separated", can you note something like this in the commit message?
LGTM, and Approved.
Mar 19 2025
In D49408#1126804, @ziaee wrote:Thank you, I thought it does need it because I'm proposing changing the copyright header?
I ask once again to be mindful of your use of the commit trailers here... The commit does not require "approval" from @shurd, but as the author of the man page (its de-facto maintainer), his "Reviewed by" is meaningful.
Mar 18 2025
Superseded by aaf0a7302d10.
Superseded by c0bed9bd0bda.
Superseded by c0bed9bd0bda.