Page MenuHomeFreeBSD

cred: Separate constant for the number of inlined groups
ClosedPublic

Authored by olce on Oct 4 2024, 8:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 23, 1:30 PM
Unknown Object (File)
Mon, Sep 22, 2:50 AM
Unknown Object (File)
Sep 4 2025, 12:57 AM
Unknown Object (File)
Aug 23 2025, 1:19 PM
Unknown Object (File)
Aug 21 2025, 10:07 PM
Unknown Object (File)
Aug 21 2025, 4:02 AM
Unknown Object (File)
Aug 14 2025, 10:55 PM
Unknown Object (File)
Aug 9 2025, 7:56 AM
Subscribers

Details

Summary

CRED_SMALLGROUPS_NB now holds the number of inlined groups in field
'cr_smallgroups'. XU_NGROUPS stays the number of groups allowed in
'struct xucred'. The first is an implementation detail, while the
second is part of a public interface. All mentions of XU_NGROUPS in the
tree have been reviewed and only those concerning the implementation
detail have been changed to use CRED_SMALLGROUPS_NB (they were all in
'kern_prot.c').

No functional change (intended).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Oct 4 2024, 8:07 AM

Seems good. This is just a correctness change, yes? As in, CRED_SMALLGROUPS_NB is not touched by any later change in the series?

This revision is now accepted and ready to land.Oct 28 2024, 5:17 PM

Seems good. This is just a correctness change, yes? As in, CRED_SMALLGROUPS_NB is not touched by any later change in the series?

Yes, this is effectively a correctness fix, with also the aim of enabling a possible increase of CRED_SMALLGROUPS_NB in the future (whereas XU_NGROUPS can't be changed because of backwards compatibility), although for now I don't feel a particular need to do it.