Page MenuHomeFreeBSD
Differential D46908

cred: Make group_is_supplementary() public; New group_is_primary()
ClosedPublic
Actions

Authored by olce on Oct 4 2024, 8:07 AM.
Tags
None
Referenced Files
F103253156: D46908.id145899.diff
Fri, Nov 22, 4:17 PM
Unknown Object (File)
Mon, Nov 18, 1:42 PM
Unknown Object (File)
Fri, Nov 15, 1:42 PM
Unknown Object (File)
Thu, Nov 14, 3:44 PM
Unknown Object (File)
Sat, Nov 2, 9:42 PM
Unknown Object (File)
Sun, Oct 27, 12:04 PM
Unknown Object (File)
Sun, Oct 27, 10:07 AM
Unknown Object (File)
Oct 24 2024, 2:51 AM
View All 17 Files
Subscribers
bapt
imp

Details

Reviewers
mhorne
mjg
emaste
Commits
rGd43f0394c57e: cred: Make group_is_supplementary() public; New group_is_primary()
rG923a50140b2b: cred: Make group_is_supplementary() public; New group_is_primary()
rG6369544278b2: cred: Make group_is_supplementary() public; New group_is_primary()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce created this revision.Oct 4 2024, 8:07 AM
Herald added a subscriber: imp. · View Herald TranscriptOct 4 2024, 8:07 AM
olce requested review of this revision.Oct 4 2024, 8:07 AM
Harbormaster completed remote builds in B59719: Diff 144206.Oct 4 2024, 8:07 AM
olce added a subscriber: bapt.Oct 4 2024, 8:17 AM
olce added a parent revision: D46907: cred: group_is_supplementary(): Use bsearch().Oct 4 2024, 8:30 AM
olce added a child revision: D46909: cred: Hide internal flag CRED_FLAG_CAPMODE.
mhorne requested changes to this revision.Oct 7 2024, 7:11 PM
mhorne added inline comments.
sys/sys/ucred.h
163

As with D46906, this should be group_is_primary(). Perhaps you have already made the change locally.

This revision now requires changes to proceed.Oct 7 2024, 7:11 PM
olce added inline comments.Oct 7 2024, 7:18 PM
sys/sys/ucred.h
163

Yes. Will update these reviews tomorrow.

olce updated this revision to Diff 144484.Oct 8 2024, 1:31 PM
olce retitled this revision from cred: is_a_supplementary_group() public; New is_a_primary_group() to cred: Make group_is_supplementary() public; New group_is_primary().

Rename to group_is_primary().

Harbormaster completed remote builds in B59840: Diff 144484.Oct 8 2024, 1:31 PM
mhorne accepted this revision.Mon, Oct 28, 5:35 PM
This revision is now accepted and ready to land.Mon, Oct 28, 5:35 PM
Closed by commit rG6369544278b2: cred: Make group_is_supplementary() public; New group_is_primary() (authored by olce). · Explain WhySat, Nov 2, 8:39 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rG6369544278b2: cred: Make group_is_supplementary() public; New group_is_primary().
olce added a commit: rG923a50140b2b: cred: Make group_is_supplementary() public; New group_is_primary().Fri, Nov 15, 10:49 AM
olce added a commit: rGd43f0394c57e: cred: Make group_is_supplementary() public; New group_is_primary().Fri, Nov 15, 1:01 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines
sys/
11 lines

Diff 145899

View Options

sys/kern/kern_prot.c

Loading...
View Options

sys/sys/ucred.h

Loading...