Page MenuHomeFreeBSD
Differential D34748

riscv: add Allwinner D1 device tree
Needs ReviewPublic
Actions

Authored by julien.cassette_gmail.com on Apr 2 2022, 11:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 1, 1:13 PM
Unknown Object (File)
Fri, Mar 22, 4:25 PM
Unknown Object (File)
Fri, Mar 22, 4:25 PM
Unknown Object (File)
Fri, Mar 22, 3:43 PM
Unknown Object (File)
Mar 4 2024, 5:50 AM
Unknown Object (File)
Feb 19 2024, 10:55 AM
Unknown Object (File)
Feb 13 2024, 6:57 PM
Unknown Object (File)
Jan 21 2024, 8:47 PM
View All 41 Files
Subscribers
bcr
emaste
gehaowu_bitmoe.com
imp
jrtc27
Contributor Reviews (src)

Details

Reviewers
manu
Group Reviewers
riscv
Summary

Obtained from: https://github.com/smaeul/linux/commit/06b026a8b7148f18356c5f809e51f013c2494587

Signed-off-by: Julien Cassette <julien.cassette@gmail.com>

Test Plan

The DTB files are built.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44962
Build 41850: arc lint + arc unit

Event Timeline

julien.cassette_gmail.com created this revision.Apr 2 2022, 11:38 AM
Herald added a reviewer: Core Team. · View Herald TranscriptApr 2 2022, 11:38 AM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
julien.cassette_gmail.com requested review of this revision.Apr 2 2022, 11:38 AM
Harbormaster completed remote builds in B44962: Diff 104496.Apr 2 2022, 11:38 AM
julien.cassette_gmail.com added a child revision: D34749: aw_wdog: support Allwinner D1 watchdog.Apr 2 2022, 11:38 AM
julien.cassette_gmail.com edited the test plan for this revision. (Show Details)Apr 2 2022, 11:45 AM
julien.cassette_gmail.com added a reviewer: riscv.
jrtc27 added a subscriber: jrtc27.Apr 2 2022, 11:51 AM

Why do we need this? Device trees should come from the firmware in this day and age...

jrtc27 added a reviewer: manu.Apr 2 2022, 11:51 AM
julien.cassette_gmail.com added a comment.Apr 2 2022, 12:57 PM
In D34748#787493, @jrtc27 wrote:

Why do we need this? Device trees should come from the firmware in this day and age...

Hello Jessica.
Since this is done for other devices, I guessed this was needed for some cases (e.g. maybe the firmware does not always provide the exact DTB we expect?), or even just for documentation purposes.
Regards, Julien.

jrtc27 added a comment.Apr 2 2022, 1:18 PM
In D34748#787517, @julien.cassette_gmail.com wrote:
In D34748#787493, @jrtc27 wrote:

Why do we need this? Device trees should come from the firmware in this day and age...

Hello Jessica.
Since this is done for other devices, I guessed this was needed for some cases (e.g. maybe the firmware does not always provide the exact DTB we expect?), or even just for documentation purposes.
Regards, Julien.

This was added for the SiFive Unleashed because initially there was no proper firmware, U-Boot came later and instead you just had to direct boot a kernel. There is no need for it any more even there.

julien.cassette_gmail.com added a comment.Apr 3 2022, 4:53 PM
In D34748#787522, @jrtc27 wrote:
In D34748#787517, @julien.cassette_gmail.com wrote:
In D34748#787493, @jrtc27 wrote:

Why do we need this? Device trees should come from the firmware in this day and age...

Hello Jessica.
Since this is done for other devices, I guessed this was needed for some cases (e.g. maybe the firmware does not always provide the exact DTB we expect?), or even just for documentation purposes.
Regards, Julien.

This was added for the SiFive Unleashed because initially there was no proper firmware, U-Boot came later and instead you just had to direct boot a kernel. There is no need for it any more even there.

Okay, thanks for the explanation. I guess we can drop the review then.

julien.cassette_gmail.com removed a child revision: D34749: aw_wdog: support Allwinner D1 watchdog.Apr 3 2022, 6:39 PM
emaste added a subscriber: emaste.Apr 7 2022, 1:27 PM

There is no need for it any more even there.

Shall we remove it to avoid any confusion? Presumably we are no longer interested in supporting SiFive Unleashed cases without uboot.

manu added a comment.Apr 7 2022, 1:43 PM
In D34748#787493, @jrtc27 wrote:

Why do we need this? Device trees should come from the firmware in this day and age...

The headers are still needed, I guess I need to update the vendor import.

emaste added a comment.Oct 21 2022, 6:47 PM

Note that sun20i-d1-msgbox.h is listed as GPL-only

gehaowu_bitmoe.com added a subscriber: gehaowu_bitmoe.com.Nov 23 2022, 12:27 PM
bcr removed a reviewer: Core Team.May 20 2023, 1:50 PM
bcr added a subscriber: bcr.

Remove core-team, as we do not seem to get involved in this.

Revision Contents
Changeset List

PathSize
sys/
contrib/
device-tree/
include/
dt-bindings/
clock/
156 lines
19 lines
10 lines
mailbox/
18 lines
reset/
77 lines
16 lines
src/
riscv/
allwinner/
151 lines
144 lines
372 lines
1162 lines
modules/
dtb/
allwinner/
7 lines
riscv/
conf/
1 line

Diff 104496

View Options

sys/contrib/device-tree/include/dt-bindings/clock/sun20i-d1-ccu.h

Loading...
View Options

sys/contrib/device-tree/include/dt-bindings/clock/sun20i-d1-r-ccu.h

Loading...
View Options

sys/contrib/device-tree/include/dt-bindings/clock/sun6i-rtc.h

Loading...
View Options

sys/contrib/device-tree/include/dt-bindings/mailbox/sun20i-d1-msgbox.h

Loading...
View Options

sys/contrib/device-tree/include/dt-bindings/reset/sun20i-d1-ccu.h

Loading...
View Options

sys/contrib/device-tree/include/dt-bindings/reset/sun20i-d1-r-ccu.h

Loading...
View Options

sys/contrib/device-tree/src/riscv/allwinner/sun20i-d1-lichee-rv-dock.dts

Loading...
View Options

sys/contrib/device-tree/src/riscv/allwinner/sun20i-d1-lichee-rv.dts

Loading...
View Options

sys/contrib/device-tree/src/riscv/allwinner/sun20i-d1-nezha.dts

Loading...
View Options

sys/contrib/device-tree/src/riscv/allwinner/sun20i-d1.dtsi

Loading...
View Options

sys/modules/dtb/allwinner/Makefile

Loading...
View Options

sys/riscv/conf/GENERIC

Loading...