Page MenuHomeFreeBSD
Differential D47627

riscv: Add implementations of atomic_testand(set|clear)_(32|64|long)
ClosedPublic
Actions

Authored by jhb on Nov 15 2024, 8:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 11, 10:54 AM
Unknown Object (File)
Mon, Nov 3, 4:30 AM
Unknown Object (File)
Mon, Nov 3, 4:30 AM
Unknown Object (File)
Thu, Oct 30, 11:53 PM
Unknown Object (File)
Thu, Oct 16, 5:04 AM
Unknown Object (File)
Thu, Oct 16, 5:04 AM
Unknown Object (File)
Oct 14 2025, 12:44 AM
Unknown Object (File)
Oct 14 2025, 12:35 AM
View All 49 Files
Subscribers
imp
riscv

Details

Reviewers
kib
jrtc27
mhorne
br
Commits
rG4380cca46dd9: riscv: Add implementations of atomic_testand(set|clear)_(32|64|long)
rGa474e53d03ca: riscv: Add implementations of atomic_testand(set|clear)_(32|64|long)
Summary

These use amoor and amoand rather than a loop.

Also define atomic_testandset_acq_(64|long) using amoor.aq.

Sponsored by: AFRL, DARPA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Nov 15 2024, 8:40 PM
Herald added subscribers: riscv, imp. · View Herald TranscriptNov 15 2024, 8:40 PM
jhb requested review of this revision.Nov 15 2024, 8:40 PM
jhb added a child revision: D47628: arm: Implement atomic_testandset_acq_long as a simple wrapper.
Harbormaster completed remote builds in B60619: Diff 146564.Nov 15 2024, 8:40 PM
jhb added reviewers: mhorne, br.Nov 15 2024, 10:25 PM
jhb added a comment.Nov 16 2024, 5:41 PM

I did boot this under qemu, and if you get this wrong the first attempt to create a UMA zone panics due to BIT_TEST_SET_ATOMIC being wrong (I had it wrong the first time).

kib accepted this revision.Nov 16 2024, 6:57 PM
This revision is now accepted and ready to land.Nov 16 2024, 6:57 PM
mhorne accepted this revision.Nov 18 2024, 3:14 PM
mhorne added inline comments.
sys/riscv/include/atomic.h
468–480

For consistency with those added above, decide if testandclear should precede or follow testandset.

jhb added inline comments.Nov 18 2024, 7:45 PM
sys/riscv/include/atomic.h
468–480

Oh, yes, I will sort clear before test above.

Closed by commit rGa474e53d03ca: riscv: Add implementations of atomic_testand(set|clear)_(32|64|long) (authored by jhb). · Explain WhyNov 19 2024, 3:28 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGa474e53d03ca: riscv: Add implementations of atomic_testand(set|clear)_(32|64|long).
jhb added a commit: rG4380cca46dd9: riscv: Add implementations of atomic_testand(set|clear)_(32|64|long).Dec 1 2024, 4:58 AM

Revision Contents
Changeset List

PathSize
sys/
riscv/
include/
73 lines

Diff 146692

View Options

sys/riscv/include/atomic.h

Loading...