Page MenuHomeFreeBSD
Differential D47631

atomic(9): Implement atomic_testand(clear|set)_ptr
ClosedPublic
Actions

Authored by jhb on Nov 15 2024, 8:40 PM.
Tags
None
Referenced Files
F132357884: D47631.id146568.diff
Thu, Oct 16, 5:10 AM
F132357413: D47631.id146696.diff
Thu, Oct 16, 5:06 AM
F132357400: D47631.id.diff
Thu, Oct 16, 5:06 AM
Unknown Object (File)
Tue, Oct 14, 12:36 AM
Unknown Object (File)
Mon, Oct 13, 7:30 AM
Unknown Object (File)
Mon, Oct 13, 7:30 AM
Unknown Object (File)
Sun, Oct 12, 7:17 PM
Unknown Object (File)
Wed, Oct 8, 11:40 PM
View All 50 Files
Subscribers
emaste
imp
jhibbits
olce
riscv

Details

Reviewers
kib
jrtc27
andrew
manu
imp
Commits
rGb291c7168a78: atomic(9): Implement atomic_testand(clear|set)_ptr
rGa80b9ee15aa0: atomic(9): Implement atomic_testand(clear|set)_ptr
Summary

For current architectures, these are just aliases for the existing
operation on the relevant scalar integer.

Obtained from: CheriBSD
Sponsored by: AFRL, DARPA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Nov 15 2024, 8:40 PM
Herald added a reviewer: andrew. · View Herald TranscriptNov 15 2024, 8:40 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: riscv, olce, jhibbits and 2 others. · View Herald Transcript
jhb requested review of this revision.Nov 15 2024, 8:40 PM
Harbormaster completed remote builds in B60623: Diff 146568.Nov 15 2024, 8:40 PM
jhb added a parent revision: D47630: atomic.9: Document atomic_testand*_64 and atomic_testandset_acq_long.Nov 15 2024, 8:40 PM
jhb added a child revision: D47632: rangelock: Use atomic_testandset_ptr.
kib accepted this revision.Nov 16 2024, 1:49 AM
This revision is now accepted and ready to land.Nov 16 2024, 1:49 AM
imp accepted this revision.Nov 16 2024, 1:54 AM

All look good except I'm not so sure about 32bit powerpc

jhb added a comment.Nov 16 2024, 5:39 PM

Should have noted that this passes make universe (and I've also booted it on some architectures).

sys/powerpc/include/atomic.h
1100

This matches the pattern of other 32-bit powerpc ops of using a cast instead of just mapping the macro directly.

Closed by commit rGa80b9ee15aa0: atomic(9): Implement atomic_testand(clear|set)_ptr (authored by jhb). · Explain WhyNov 19 2024, 3:29 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGa80b9ee15aa0: atomic(9): Implement atomic_testand(clear|set)_ptr.
jhb added a commit: rGb291c7168a78: atomic(9): Implement atomic_testand(clear|set)_ptr.Dec 1 2024, 4:58 AM

Revision Contents
Changeset List

PathSize
share/
man/
man9/
1 line
sys/
amd64/
include/
2 lines
arm/
include/
2 lines
arm64/
include/
2 lines
i386/
include/
4 lines
kern/
2 lines
2 lines
2 lines
powerpc/
include/
10 lines
riscv/
include/
2 lines

Diff 146696

View Options

share/man/man9/atomic.9

Loading...
View Options

sys/amd64/include/atomic.h

Loading...
View Options

sys/arm/include/atomic.h

Loading...
View Options

sys/arm64/include/atomic.h

Loading...
View Options

sys/i386/include/atomic.h

Loading...
View Options

sys/kern/subr_asan.c

Loading...
View Options

sys/kern/subr_csan.c

Loading...
View Options

sys/kern/subr_msan.c

Loading...
View Options

sys/powerpc/include/atomic.h

Loading...
View Options

sys/riscv/include/atomic.h

Loading...