Page MenuHomeFreeBSD

riscv: Construct an identity map in locore.S
AcceptedPublic

Authored by mhorne on Thu, May 23, 7:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 4, 2:56 PM
Unknown Object (File)
Mon, May 27, 8:01 PM
Unknown Object (File)
Mon, May 27, 6:06 PM
Unknown Object (File)
Sun, May 26, 5:17 PM
Unknown Object (File)
Thu, May 23, 9:57 PM
Subscribers

Details

Reviewers
markj
br
jrtc27
jhb
Group Reviewers
riscv
Summary

This is useful for two reasons. Within this change, it allows the
early DTB mapping to be eliminated, as we can now just dereference the
physical address provided by FW and copy the DTB contents into KVA.

It will also aid in an upcoming change.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 58031
Build 54919: arc lint + arc unit

Event Timeline

sys/riscv/riscv/locore.S
124

A more elaborate comment would be helpful:

  • When is this map used?
  • Is the mapping temporary? If so, when is it removed?
  • What does it cover?
sys/riscv/riscv/pmap.c
698

Do you still need this fence? It looks like belongs in pmap_bootstrap_l3().

sys/riscv/riscv/locore.S
124

I see that you do this in a follow-up commit.

mhorne added inline comments.
sys/riscv/riscv/pmap.c
698

Agreed, it is odd here, but precedes the addition of the code I am removing.

It would be better to check the usage of this fence in the later reworking of pmap_bootstrap(), D45327.

This change is essentially part of that rework, and although I separated it for the sake of review, the split is imperfect.

markj added inline comments.
sys/riscv/riscv/locore.S
130
This revision is now accepted and ready to land.Mon, May 27, 3:11 PM
mhorne marked an inline comment as done.

Add assembly commentary here, not in the later patch.

This revision now requires review to proceed.Mon, Jun 3, 6:39 PM
mhorne retitled this revision from Construct an identity map in locore.S to riscv: Construct an identity map in locore.S.Mon, Jun 3, 6:41 PM
This revision is now accepted and ready to land.Thu, Jun 6, 5:21 PM