bsd.mkopt.mk: Allow OPT_FOO to be set to override FOO
Needs ReviewPublic
Actions

Authored by jrtc27 on Sun, Jan 25, 2:33 PM.

Details

Reviewers

brooks
imp

Group Reviewers

cheri

Summary

Just as we allow MK_FOO to be set, overriding any WITH(OUT)_FOO and the
default, we should allow OPT_FOO to be set, overriding any FOO and the
default.

Obtained from: CheriBSD
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 70547
Build 67430: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Sun, Jan 25, 2:33 PM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptSun, Jan 25, 2:33 PM

jrtc27 requested review of this revision.Sun, Jan 25, 2:33 PM

Harbormaster completed remote builds in B70131: Diff 170381.Sun, Jan 25, 2:33 PM

What are you using this for? I think it's ahoodchange, but I'm curios.

This revision is now accepted and ready to land.Sun, Jan 25, 4:23 PM

In D54876#1254502, @imp wrote:

What are you using this for? I think it's ahoodchange, but I'm curios.

Downstream I'm adding an option to pick a TLS ABI for CHERI and need to ensure it's overridden to the host's default when bootstrapping rather than using a potentially-incompatible (or not-yet-supported-by-host-rtld) one.

LGTM

jrtc27 added a subscriber: jhb.Tue, Jan 27, 7:55 PM

jrtc27 added inline comments.