Page MenuHomeFreeBSD

bsd.mkopt.mk: Allow OPT_FOO to be set to override FOO
Needs ReviewPublic

Authored by jrtc27 on Jan 25 2026, 2:33 PM.
Tags
None
Referenced Files
F152097867: D54876.id170381.diff
Sun, Apr 12, 5:19 PM
Unknown Object (File)
Tue, Apr 7, 9:31 PM
Unknown Object (File)
Sun, Apr 5, 12:11 AM
Unknown Object (File)
Wed, Apr 1, 5:17 AM
Unknown Object (File)
Mon, Mar 30, 7:29 AM
Unknown Object (File)
Tue, Mar 17, 8:58 PM
Unknown Object (File)
Mar 11 2026, 10:15 AM
Unknown Object (File)
Mar 11 2026, 8:51 AM

Details

Reviewers
brooks
imp
Group Reviewers
cheri
Summary

Just as we allow MK_FOO to be set, overriding any WITH(OUT)_FOO and the
default, we should allow OPT_FOO to be set, overriding any FOO and the
default.

Obtained from: CheriBSD
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 70547
Build 67430: arc lint + arc unit

Event Timeline

What are you using this for? I think it's ahoodchange, but I'm curios.

This revision is now accepted and ready to land.Jan 25 2026, 4:23 PM
In D54876#1254502, @imp wrote:

What are you using this for? I think it's ahoodchange, but I'm curios.

Downstream I'm adding an option to pick a TLS ABI for CHERI and need to ensure it's overridden to the host's default when bootstrapping rather than using a potentially-incompatible (or not-yet-supported-by-host-rtld) one.

jrtc27 added inline comments.
share/mk/bsd.mkopt.mk
148

As pointed out by @jhb downstream...

This revision now requires review to proceed.Feb 9 2026, 1:35 PM