load_elf: Do kernel module relocations for PPC
ClosedPublic
Actions

Authored by ivy on Fri, Apr 17, 12:49 AM.

Details

Reviewers

jrtc27
kevans
imp
tpearson_raptorengineering.com
manu
adrian

Group Reviewers

PowerPC

Commits

rGba94d7574972: stand/common/load_elf: Do kernel module relocations for PPC

Summary

reloc_ptr() skips relocations for the kernel module, because on most
platforms the kernel is ET_EXEC and this is not required. On PPC,
the kernel is ET_DYN and we need to relocate here, otherwise the
module metadata will not be loaded properly and the kernel module
will have an incorrect version, preventing module dependencies from
resolving.

This fixes loading kernel modules from loader.conf on powerpc.

Diagnosed by: jrtc27
Sponsored by: https://www.patreon.com/bsdivy

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivy created this revision.Fri, Apr 17, 12:49 AM

Herald added a reviewer: manu. · View Herald TranscriptFri, Apr 17, 12:49 AM

Herald added a subscriber: dab. · View Herald Transcript

ivy requested review of this revision.Fri, Apr 17, 12:49 AM

Harbormaster completed remote builds in B72272: Diff 175726.Fri, Apr 17, 12:50 AM

neat! why's the kernel ET_DYN on ppc anyway?

This revision is now accepted and ready to land.Fri, Apr 17, 1:39 AM

I now understand why this case is there and am contemplating unifying the two paths so this condition can just be deleted even on non-PowerPC (it's more interesting on CHERI where even our ET_EXEC will have relocations for capabilities, but not integer addresses...), but for now this should be sufficient.

Closed by commit rGba94d7574972: stand/common/load_elf: Do kernel module relocations for PPC (authored by ivy). · Explain WhySat, Apr 18, 12:08 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rGba94d7574972: stand/common/load_elf: Do kernel module relocations for PPC.