Page MenuHomeFreeBSD
Differential D56033

tunefs: Don't lower WARNS
ClosedPublic
Actions

Authored by des on Sun, Mar 22, 6:59 PM.
Tags
None
Referenced Files
F152524808: D56033.id.diff
Wed, Apr 15, 12:01 PM
F152511431: D56033.id174801.diff
Wed, Apr 15, 10:24 AM
Unknown Object (File)
Tue, Apr 14, 2:00 PM
Unknown Object (File)
Sun, Apr 12, 1:54 AM
Unknown Object (File)
Sat, Apr 11, 8:04 PM
Unknown Object (File)
Fri, Apr 10, 6:26 AM
Unknown Object (File)
Wed, Apr 8, 9:58 AM
Unknown Object (File)
Tue, Apr 7, 3:55 AM
View All 17 Files
Subscribers
brooks
imp
jhb
jrtc27

Details

Reviewers
None
Commits
rG1fcaefce1e19: tunefs: Don't lower WARNS
rG83a0bced4ef0: tunefs: Don't lower WARNS
rGc5e79c7e93dd: tunefs: Don't lower WARNS
Summary

Use casts to silence the alignment warnings instead of potentially
suppressing other legitimate warnings.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Sun, Mar 22, 6:59 PM
Herald added a subscriber: imp. · View Herald TranscriptSun, Mar 22, 6:59 PM
des requested review of this revision.Sun, Mar 22, 6:59 PM
Harbormaster completed remote builds in B71645: Diff 174131.Sun, Mar 22, 6:59 PM
des added a child revision: D56034: tunefs: Add tests.Sun, Mar 22, 6:59 PM
jhb added subscribers: jrtc27, brooks, jhb.Wed, Mar 25, 12:27 PM

@brooks, @jrtc27: I wonder if it might be nice to have a __ASSUME_ALIGNED wrapper for these cases similar to __DECONST. In particular, for CHERI it can be useful to annotate when pointer values are properly aligned so that assignment can be inlined instead of resulting in a libcall to memcpy.

brooks added a comment.Thu, Mar 26, 10:03 AM

__ASSUME_ALIGNED could work. __builtin_assume_aligned is broadly supported so I double we even need a fall back.

des added a comment.Mon, Mar 30, 10:59 AM
In D56033#1282934, @brooks wrote:

__ASSUME_ALIGNED could work. __builtin_assume_aligned is broadly supported so I double we even need a fall back.

__ASSUME_ALIGNED currently does not exist, may I commit this until it does?

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Apr 2, 11:22 AM
Closed by commit rGc5e79c7e93dd: tunefs: Don't lower WARNS (authored by des). · Explain Why
This revision was automatically updated to reflect the committed changes.
des added a commit: rGc5e79c7e93dd: tunefs: Don't lower WARNS.
des added a commit: rG83a0bced4ef0: tunefs: Don't lower WARNS.Sat, Apr 4, 9:00 AM
des added a commit: rG1fcaefce1e19: tunefs: Don't lower WARNS.

Revision Contents
Changeset List

PathSize
sbin/
tunefs/
2 lines
6 lines

Diff 174801

View Options

sbin/tunefs/Makefile

Loading...
View Options

sbin/tunefs/tunefs.c

Loading...