Page MenuHomeFreeBSD
Differential D56010

file: Parse some UFS2 flags
ClosedPublic
Actions

Authored by des on Mar 21 2026, 7:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 13, 5:45 PM
Unknown Object (File)
Mon, May 11, 2:03 PM
Unknown Object (File)
Sat, May 9, 8:29 PM
Unknown Object (File)
Sat, May 9, 8:22 PM
Unknown Object (File)
Tue, May 5, 1:31 AM
Unknown Object (File)
Fri, May 1, 7:15 AM
Unknown Object (File)
Fri, May 1, 7:09 AM
Unknown Object (File)
Mon, Apr 27, 12:12 PM
View All 31 Files
Subscribers
imp

Details

Reviewers
delphij
Commits
rGf0ca30b4e500: file: Parse some UFS2 flags
rGc7e5e9642a4c: file: Parse some UFS2 flags
rG0d2454f0cb8a: file: Parse some UFS2 flags
rGfa03f93e8829: file: Parse some UFS2 flags
Summary

This allows libmagic to recognize the FS_DOSOFTDEP, FS_SUJ, FS_GJOURNAL,
FS_ACLS, and FS_NFS4ACLS flags on a UFS2 file system.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Mar 21 2026, 7:23 AM
Herald added a subscriber: imp. · View Herald TranscriptMar 21 2026, 7:23 AM
des requested review of this revision.Mar 21 2026, 7:23 AM
Harbormaster completed remote builds in B71618: Diff 174075.Mar 21 2026, 7:23 AM
des added a comment.Mar 21 2026, 7:24 AM

grrr

diff --git a/contrib/file/magic/Magdir/filesystems b/contrib/file/magic/Magdir/filesystems
index a15e5e74d971..78e9a31bd0e7 100644
--- a/contrib/file/magic/Magdir/filesystems
+++ b/contrib/file/magic/Magdir/filesystems
@@ -1640,6 +1640,11 @@
 >1112  lelong          x               pending inodes to free %d,
 >712   lequad          x               system-wide uuid %0llx,
 >60    lelong          x               minimum percentage of free blocks %d,
+>1312  lelong&0xa      0x2             soft updates,
+>1312  lelong&0xa      0xa             soft updates journaling,
+>1312  lelong&0x40     0x40            GEOM journaling,
+>1312  lelong&0x10     0x10            POSIX.1e ACLs,
+>1312  lelong&0x100    0x100           NFSv4 ACLs,
 >128   lelong          0               TIME optimization
 >128   lelong          1               SPACE optimization
des added a comment.Mar 22 2026, 5:26 PM

Note, this has also been submitted upstream.

des added a child revision: D56034: tunefs: Add tests.Mar 22 2026, 7:03 PM
des added a comment.Mar 24 2026, 11:03 AM

Accepted upstream as 482259e5e952

This revision was not accepted when it landed; it landed in state Needs Review.Mar 24 2026, 11:04 AM
Closed by commit rGfa03f93e8829: file: Parse some UFS2 flags (authored by des). · Explain Why
This revision was automatically updated to reflect the committed changes.
des added a commit: rGfa03f93e8829: file: Parse some UFS2 flags.
des added a commit: rG0d2454f0cb8a: file: Parse some UFS2 flags.Apr 2 2026, 9:48 AM
des added a commit: rGc7e5e9642a4c: file: Parse some UFS2 flags.
des added a commit: rGf0ca30b4e500: file: Parse some UFS2 flags.

Revision Contents
Changeset List

PathSize
contrib/
file/
magic/
Magdir/
5 lines

Diff 174231

View Options

contrib/file/magic/Magdir/filesystems

Loading...