Page MenuHomeFreeBSD
Differential D56034

tunefs: Add tests
ClosedPublic
Actions

Authored by des on Sun, Mar 22, 6:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 17, 2:55 AM
Unknown Object (File)
Sat, Apr 11, 8:04 PM
Unknown Object (File)
Sat, Apr 11, 1:20 PM
Unknown Object (File)
Wed, Apr 8, 9:58 AM
Unknown Object (File)
Wed, Apr 8, 9:58 AM
Unknown Object (File)
Tue, Apr 7, 9:42 AM
Unknown Object (File)
Sun, Apr 5, 7:08 PM
Unknown Object (File)
Sat, Apr 4, 7:20 PM
View All 18 Files
Subscribers
imp
ivy
ngie

Details

Reviewers
ngie
Group Reviewers
tests
Commits
rG83ec9a97e19d: tunefs: Add tests
rGb78e2b69893c: tunefs: Add tests
rG6630c3a73688: tunefs: Add tests
Summary

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Sun, Mar 22, 6:59 PM
Herald added subscribers: ivy, imp. · View Herald TranscriptSun, Mar 22, 6:59 PM
des requested review of this revision.Sun, Mar 22, 6:59 PM
Harbormaster completed remote builds in B71646: Diff 174132.Sun, Mar 22, 6:59 PM
des added a parent revision: D56033: tunefs: Don't lower WARNS.Sun, Mar 22, 6:59 PM
des added a reviewer: tests.Sun, Mar 22, 7:00 PM
des added a parent revision: D56010: file: Parse some UFS2 flags.Sun, Mar 22, 7:03 PM
ngie accepted this revision.Tue, Mar 24, 4:24 PM
ngie added a subscriber: ngie.
ngie added inline comments.
sbin/tunefs/tests/tunefs_test.sh
16–51

Most of my recommendations are to just make the function a bit easier for humans to follow and for the function to be easier to maintain in the future.

96–186

I think you could use su instead of sunoj for brevity.

This revision is now accepted and ready to land.Tue, Mar 24, 4:24 PM
Closed by commit rG6630c3a73688: tunefs: Add tests (authored by des). · Explain WhyThu, Apr 2, 11:22 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG6630c3a73688: tunefs: Add tests.
des added a commit: rGb78e2b69893c: tunefs: Add tests.Sat, Apr 4, 9:00 AM
des added a commit: rG83ec9a97e19d: tunefs: Add tests.

Revision Contents
Changeset List

PathSize
etc/
mtree/
2 lines
sbin/
tunefs/
5 lines
tests/
4 lines
189 lines

Diff 174802

View Options

etc/mtree/BSD.tests.dist

Loading...
View Options

sbin/tunefs/Makefile

Loading...
View Options

sbin/tunefs/tests/Makefile

Loading...
View Options

sbin/tunefs/tests/tunefs_test.sh

Loading...