pkg: Add tests

[des]

Summary

MFC after: 1 week

[des]

speed up pkg create pkg by lowering the compression level

[des]

refine

[ngie]

pkg already provides tests. Should we leverage those instead of having another set of different tests?

[des]

In D58349#1341394, @ngie wrote:

pkg already provides tests. Should we leverage those instead of having another set of different tests?

You understand that pkg(7) and pkg(8) are two completely different programs, right?

[ngie]

Do all of these tests require root permissions to function?

usr.sbin/pkg/tests/pkg_test.sh

9–10

One of these values should be removed (the latter statement is a no-op since the variable is already set).

15

TIL!

49

This only works when MK_RESCUE != no. The test should confirm that /rescue/sh exists before executing with atf_set require.files /rescue/sh.

59–74

Same thing with less escaping :).

103–118

129

A sysctl needs to be tested before we can confirm that jail functionality can be accessed, right? Also, I would assume that this would only work for root, not other users.

135–137

General comment: I feel like there needs to be a generic "create test jail" script for procedures like this.

[des]

usr.sbin/pkg/tests/pkg_test.sh

9–10

You assume the sysctl command always succeeds and returns a non-empty string.