Page MenuHomeFreeBSD

pkg: Add tests
Needs ReviewPublic

Authored by des on Sun, Jul 19, 7:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 14, 3:56 PM
Unknown Object (File)
Thu, Aug 13, 5:43 PM
Unknown Object (File)
Mon, Aug 10, 12:37 AM
Unknown Object (File)
Sun, Aug 9, 11:06 PM
Unknown Object (File)
Sun, Aug 9, 5:04 AM
Unknown Object (File)
Sat, Aug 8, 11:13 PM
Unknown Object (File)
Sat, Aug 8, 2:47 PM
Unknown Object (File)
Sat, Aug 8, 10:54 AM
Subscribers

Details

Reviewers
bdrewery
Group Reviewers
tests
Summary

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75127
Build 72010: arc lint + arc unit

Event Timeline

des requested review of this revision.Sun, Jul 19, 7:35 PM

speed up pkg create pkg by lowering the compression level

pkg already provides tests. Should we leverage those instead of having another set of different tests?

pkg already provides tests. Should we leverage those instead of having another set of different tests?

You understand that pkg(7) and pkg(8) are two completely different programs, right?

Do all of these tests require root permissions to function?

usr.sbin/pkg/tests/pkg_test.sh
9–10

One of these values should be removed (the latter statement is a no-op since the variable is already set).

15

TIL!

49

This only works when MK_RESCUE != no. The test should confirm that /rescue/sh exists before executing with atf_set require.files /rescue/sh.

59–74

Same thing with less escaping :).

103–118
129

A sysctl needs to be tested before we can confirm that jail functionality can be accessed, right? Also, I would assume that this would only work for root, not other users.

135–137

General comment: I feel like there needs to be a generic "create test jail" script for procedures like this.