MFC after: 1 week
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 75004 Build 71887: arc lint + arc unit
Event Timeline
Comment Actions
pkg already provides tests. Should we leverage those instead of having another set of different tests?
Comment Actions
Do all of these tests require root permissions to function?
| usr.sbin/pkg/tests/pkg_test.sh | ||
|---|---|---|
| 10–11 | One of these values should be removed (the latter statement is a no-op since the variable is already set). | |
| 16 | TIL! | |
| 50 | This only works when MK_RESCUE != no. The test should confirm that /rescue/sh exists before executing with atf_set require.files /rescue/sh. | |
| 60–75 | Same thing with less escaping :). | |
| 104–119 | ||
| 130 | A sysctl needs to be tested before we can confirm that jail functionality can be accessed, right? Also, I would assume that this would only work for root, not other users. | |
| 136–138 | General comment: I feel like there needs to be a generic "create test jail" script for procedures like this. | |
| usr.sbin/pkg/tests/pkg_test.sh | ||
|---|---|---|
| 10–11 | You assume the sysctl command always succeeds and returns a non-empty string. | |