Page MenuHomeFreeBSD
Feed Advanced Search

Yesterday

brooks committed rP490385: Update to a new snapshot..
Update to a new snapshot.
Tue, Jan 15, 4:19 PM

Wed, Jan 9

brooks committed rP489840: Upgrade to a new snapshot..
Upgrade to a new snapshot.
Wed, Jan 9, 11:06 PM
brooks committed rS342889: style(9): fix the indent of a return..
style(9): fix the indent of a return.
Wed, Jan 9, 5:24 PM

Fri, Jan 4

brooks added a comment to D18696: Manage sysctl-tree in userpace.

This looks like a neat library. I've made a few comments based on a casual review.

Fri, Jan 4, 6:07 PM
brooks committed rP489257: MFH: r489195 (reliability fix blanket).
MFH: r489195 (reliability fix blanket)
Fri, Jan 4, 4:16 PM

Thu, Jan 3

brooks committed rP489225: Add a patch files for stable/12 r342281, which corresponds to the.
Add a patch files for stable/12 r342281, which corresponds to the
Thu, Jan 3, 9:17 PM
brooks closed D18699: devel/llvm60: Add patch for stable/12 rS342281.
Thu, Jan 3, 9:17 PM
brooks closed D18691: devel/llvm70: Add patches for head rS342592 and rS342593.

Committed in rP489195

Thu, Jan 3, 7:18 PM
brooks accepted D18691: devel/llvm70: Add patches for head rS342592 and rS342593.
Thu, Jan 3, 7:18 PM
brooks committed rP489195: Backport two Objective-C bug fixes (D18672).
Backport two Objective-C bug fixes (D18672)
Thu, Jan 3, 6:10 PM
brooks closed D18672: Backport two Objective-C bug fixes to devel/llvm70.
Thu, Jan 3, 6:10 PM

Thu, Dec 20

brooks added a comment to D18603: Fix compile warning in if_fxp(4)..

Thanks for chasing this down. This was quite the abomination...

Thu, Dec 20, 5:28 PM

Tue, Dec 18

brooks committed rS342190: const poison the `new` pointer of __sysctl..
const poison the `new` pointer of __sysctl.
Tue, Dec 18, 12:45 PM
brooks closed D18444: const poison the `new` pointer of __sysctl..
Tue, Dec 18, 12:45 PM
brooks committed rS342189: Partial MFC of r342125:.
Partial MFC of r342125:
Tue, Dec 18, 9:16 AM
brooks committed rS342188: MFC r342125:.
MFC r342125:
Tue, Dec 18, 9:14 AM

Dec 15 2018

brooks committed rP487524: Upgrade to LLVM 7.0.1 Release..
Upgrade to LLVM 7.0.1 Release.
Dec 15 2018, 3:22 PM
brooks closed D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
Dec 15 2018, 3:06 PM
brooks committed rS342125: Fix bugs in plugable CC algorithm and siftr sysctls..
Fix bugs in plugable CC algorithm and siftr sysctls.
Dec 15 2018, 3:06 PM

Dec 14 2018

brooks accepted D18543: Planned obsolete mips support removal.

Looks good to me. This is a well reasoned list to remove in order to make sure we can support the remaining platforms.

Dec 14 2018, 6:42 AM

Dec 6 2018

brooks updated subscribers of D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
Dec 6 2018, 6:45 PM
brooks added 1 blocking reviewer(s) for D18443: Fix bugs in plugable CC algorithm and siftr sysctls.: transport.

@thj requested transport review before commit so make the them blocking so I don't forget.

Dec 6 2018, 6:38 PM
brooks updated the summary of D15637: Regularize the declaration of the exit syscall..
Dec 6 2018, 6:02 PM
brooks added inline comments to D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
Dec 6 2018, 4:54 PM
brooks updated the diff for D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
  • Be more consistant in checking for valid values.
Dec 6 2018, 4:54 PM
brooks updated the summary of D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
Dec 6 2018, 4:20 PM
brooks added a reviewer for D18443: Fix bugs in plugable CC algorithm and siftr sysctls.: transport.
Dec 6 2018, 4:18 PM
brooks updated the diff for D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
  • Remove comment resulting from mis-reading code.
Dec 6 2018, 4:14 PM
brooks added inline comments to D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
Dec 6 2018, 4:25 AM
brooks created D18444: const poison the `new` pointer of __sysctl..
Dec 6 2018, 1:00 AM
brooks added a child revision for D18443: Fix bugs in plugable CC algorithm and siftr sysctls.: D18444: const poison the `new` pointer of __sysctl..
Dec 6 2018, 1:00 AM
brooks added inline comments to D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
Dec 6 2018, 12:38 AM
brooks created D18443: Fix bugs in plugable CC algorithm and siftr sysctls..
Dec 6 2018, 12:28 AM

Dec 5 2018

brooks created D18442: Rework CASE_IOC_IFGROUPREQ() to require a case before it..
Dec 5 2018, 8:42 PM
brooks committed rS341604: Further simplify arguments to init..
Further simplify arguments to init.
Dec 5 2018, 7:18 PM
brooks closed D18441: Further simplify arguments to init..
Dec 5 2018, 7:18 PM
brooks added inline comments to D15637: Regularize the declaration of the exit syscall..
Dec 5 2018, 6:54 PM
brooks updated the diff for D15637: Regularize the declaration of the exit syscall..
  • Pretend we return an int (we don't return).
Dec 5 2018, 6:54 PM
brooks created D18441: Further simplify arguments to init..
Dec 5 2018, 6:40 PM
brooks retitled D15637: Regularize the declaration of the exit syscall. from Regularize the decleration of the exit syscall. to Regularize the declaration of the exit syscall..
Dec 5 2018, 6:22 PM
brooks updated the diff for D14488: Remove gratuitous copyouts of unchanged struct mac..
  • Rebase
Dec 5 2018, 6:01 PM
brooks updated the diff for D15637: Regularize the declaration of the exit syscall..
  • Rebase
Dec 5 2018, 5:58 PM
brooks committed rS341600: Remove never enabled support for "fastboot"..
Remove never enabled support for "fastboot".
Dec 5 2018, 5:37 PM
brooks closed D18431: Remove ifdef BOOTCDROM option to start init..
Dec 5 2018, 5:30 PM
brooks committed rS341599: Remove ifdef BOOTCDROM option to start init..
Remove ifdef BOOTCDROM option to start init.
Dec 5 2018, 5:30 PM
brooks updated the summary of D18431: Remove ifdef BOOTCDROM option to start init..
Dec 5 2018, 5:05 PM
brooks committed rS341509: Remove MD __sys_* private symbols..
Remove MD __sys_* private symbols.
Dec 5 2018, 12:46 AM
brooks closed D18425: Remove MD __sys_* private symbols..
Dec 5 2018, 12:46 AM
brooks added a comment to D18425: Remove MD __sys_* private symbols..

make tinderbox passed for me.

Dec 5 2018, 12:46 AM

Dec 4 2018

brooks created D18431: Remove ifdef BOOTCDROM option to start init..
Dec 4 2018, 10:37 PM
brooks committed rS341496: Regen after r341495: Remove NOARGS from oaccept..
Regen after r341495: Remove NOARGS from oaccept.
Dec 4 2018, 9:57 PM
brooks committed rS341495: Remove NOARGS from oaccept..
Remove NOARGS from oaccept.
Dec 4 2018, 9:57 PM
brooks committed rS341475: Regen after r341474: Normalize COMPAT_43 syscall declarations..
Regen after r341474: Normalize COMPAT_43 syscall declarations.
Dec 4 2018, 4:52 PM
brooks committed rS341474: Normalize COMPAT_43 syscall declarations..
Normalize COMPAT_43 syscall declarations.
Dec 4 2018, 4:51 PM
brooks closed D15816: Normalize COMPAT_43 syscall declarations..
Dec 4 2018, 4:51 PM
brooks retitled D15816: Normalize COMPAT_43 syscall declarations. from Normalize COMPAT_43 syscall declerations. to Normalize COMPAT_43 syscall declarations..
Dec 4 2018, 4:31 PM
brooks updated the diff for D15816: Normalize COMPAT_43 syscall declarations..
  • Rebase
  • GC duplicate, documentary definitions of _args structs.
Dec 4 2018, 1:08 AM
brooks committed rS341450: Remove test for KSE (removed in 2008)..
Remove test for KSE (removed in 2008).
Dec 4 2018, 12:23 AM
brooks committed rS341449: Remove a needlessly clever hack to start init with sys_exec()..
Remove a needlessly clever hack to start init with sys_exec().
Dec 4 2018, 12:16 AM
brooks closed D15469: Remove a needlessly clever hack to start init with sys_exec()..
Dec 4 2018, 12:16 AM
brooks updated the summary of D15469: Remove a needlessly clever hack to start init with sys_exec()..
Dec 4 2018, 12:04 AM
brooks added a comment to D18425: Remove MD __sys_* private symbols..
In D18425#392258, @kib wrote:

I think that our private export is too large. Ideally it would be trimmed down to the symbols used by libthr.

Dec 4 2018, 12:01 AM

Dec 3 2018

brooks created D18425: Remove MD __sys_* private symbols..
Dec 3 2018, 11:42 PM
brooks updated the diff for D15469: Remove a needlessly clever hack to start init with sys_exec()..
  • Remove redundent check (too much copy-and-paste).
  • Fix typo.
Dec 3 2018, 11:22 PM
brooks added inline comments to D15469: Remove a needlessly clever hack to start init with sys_exec()..
Dec 3 2018, 10:51 PM
brooks closed D18424: Remove declarations of syscalls not used in libthr..

Committed in rS341445.

Dec 3 2018, 10:13 PM
brooks committed rS341445: Remove declarations of syscalls not used in libthr..
Remove declarations of syscalls not used in libthr.
Dec 3 2018, 10:09 PM
brooks updated the diff for D15469: Remove a needlessly clever hack to start init with sys_exec()..
  • Rebase
  • Reduce diffs to master by retaining option handling order.
  • Free vmspace reference and clear TDP_EXECVMSPC after kern_execve().
Dec 3 2018, 10:09 PM
brooks created D18424: Remove declarations of syscalls not used in libthr..
Dec 3 2018, 9:25 PM

Dec 2 2018

brooks added a comment to D15469: Remove a needlessly clever hack to start init with sys_exec()..
In D15469#391506, @kib wrote:
In D15469#391417, @kib wrote:

Not calling pre/post leave a stray reference on vmspace0. I do not claim that this is important, but it is certainly something to consider and at least comment about. Might be the stray TDP_EXECVMSPC on thread0 is worse.

Hmm, I'll look into this more closely on Monday. It's not particularly hard to call them.

No, I think that calling them on proc0 would have too much undesirable effects, we do not want to stop almost all kernel threads. You would need to open-code clearing of the flag and possible dereference of vmspace0.

Dec 2 2018, 11:04 PM

Dec 1 2018

brooks added a comment to D15469: Remove a needlessly clever hack to start init with sys_exec()..
In D15469#391417, @kib wrote:

Not calling pre/post leave a stray reference on vmspace0. I do not claim that this is important, but it is certainly something to consider and at least comment about. Might be the stray TDP_EXECVMSPC on thread0 is worse.

Dec 1 2018, 12:52 AM
brooks added inline comments to D15469: Remove a needlessly clever hack to start init with sys_exec()..
Dec 1 2018, 12:49 AM

Nov 30 2018

brooks added reviewers for D15469: Remove a needlessly clever hack to start init with sys_exec().: kib, jhb.
Nov 30 2018, 11:22 PM
brooks updated the summary of D15469: Remove a needlessly clever hack to start init with sys_exec()..
Nov 30 2018, 11:22 PM
brooks added a comment to D16457: Subpackages. (deal with it.).

This looks like it will work well with the llvm ports. I'll mostly need to tweak my plist-generator a bit.

Nov 30 2018, 5:40 PM

Nov 29 2018

brooks updated the diff for D15469: Remove a needlessly clever hack to start init with sys_exec()..
  • Rebase
  • Catch up with changes in rS341263.
Nov 29 2018, 11:38 PM
brooks updated the diff for D16730: Committers Guide: Add a section encouraging pre-commit review..
  • Rebase
  • Address some suggestions from jhb.
Nov 29 2018, 11:24 PM
brooks committed rS341263: Add helper functions to copy strings into struct image_args..
Add helper functions to copy strings into struct image_args.
Nov 29 2018, 9:02 PM
brooks closed D15468: Add helper functions to copy strings into struct image_args..
Nov 29 2018, 9:02 PM
brooks added inline comments to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.
Nov 29 2018, 5:33 PM · manpages

Nov 27 2018

brooks added a comment to D18359: getfhat, fhlink, fhlinkat, fhreadlink: new file handle system calls.

A bunch of style things, but it generally looks fine. I've not looked deeply at the implementations of the kern_ functions.

Nov 27 2018, 5:04 PM · manpages

Nov 26 2018

brooks committed rS341000: Record r340273, r340275, r340295, r340303 as merged..
Record r340273, r340275, r340295, r340303 as merged.
Nov 26 2018, 10:21 PM
brooks accepted D14244: crossbuild: Allow bootstrapping libopenbsd on Linux.

This seems fine, especially since libopenbsd is an INTERNALLIB.

Nov 26 2018, 7:43 PM

Nov 21 2018

brooks added inline comments to D15468: Add helper functions to copy strings into struct image_args..
Nov 21 2018, 7:26 PM

Nov 20 2018

brooks committed rS340657: MFS r340643:.
MFS r340643:
Nov 20 2018, 12:43 AM

Nov 19 2018

brooks committed rS340643: MFC r340489-r340490.
MFC r340489-r340490
Nov 19 2018, 6:26 PM

Nov 17 2018

brooks updated the diff for D15468: Add helper functions to copy strings into struct image_args..
  • Use a comment rather than reserved identifier.
Nov 17 2018, 12:36 AM
brooks committed rS340490: Fix stray tab..
Fix stray tab.
Nov 17 2018, 12:03 AM

Nov 16 2018

brooks committed rS340489: Fix freebsd32 support for PCIOCGETCONF..
Fix freebsd32 support for PCIOCGETCONF.
Nov 16 2018, 11:59 PM
brooks closed D18011: Add missing cases for PCIOCGETCONF32..
Nov 16 2018, 11:59 PM
brooks created D18011: Add missing cases for PCIOCGETCONF32..
Nov 16 2018, 11:27 PM
brooks added a reviewer for D2549: Add missing pieces for mips32 gcc-4.9 kernel build!: jhb.

Adding John who's been working on this with an actually modern gcc

Nov 16 2018, 9:50 PM
brooks added inline comments to D15468: Add helper functions to copy strings into struct image_args..
Nov 16 2018, 4:20 PM

Nov 15 2018

brooks added inline comments to D15468: Add helper functions to copy strings into struct image_args..
Nov 15 2018, 6:30 PM
brooks updated the diff for D15468: Add helper functions to copy strings into struct image_args..
  • Remove unneeded temporaries to follow the pattern in freebsd32.
  • Const poision arguments.
  • Remove extra parens.
  • Document the argument array size with an assert rather than a comment.
Nov 15 2018, 6:29 PM
brooks updated the diff for D15468: Add helper functions to copy strings into struct image_args..
  • Rebase
Nov 15 2018, 12:46 AM
brooks abandoned D17349: GC unused and undocumented copyout_(un)map() interfaces..
Nov 15 2018, 12:42 AM
brooks accepted D17990: Avoid realpath(3) if not needed..

Oh right, of course that works. Things called from $PATH are run with a full path in $0.

Nov 15 2018, 12:18 AM

Nov 14 2018

brooks committed rP484948: Update to a new snapshot..
Update to a new snapshot.
Nov 14 2018, 9:41 PM
brooks added a comment to D17990: Avoid realpath(3) if not needed..

I don't understand how this can work is the working directory isn't /usr/local/bin.

Nov 14 2018, 9:28 PM