Page MenuHomeFreeBSD
Feed Advanced Search

Sat, Sep 21

brooks added a comment to D21718: makesyscalls.sh: generate boilerplate for standard COMPAT* options.

This is rather clever, but I don't like this direction. I'd like to remove the embedding of awk in sh that currently exists and this makes it much harder.

Sat, Sep 21, 1:00 PM

Thu, Sep 19

brooks added a comment to D21680: devel/xtoolchain-llvm-devel: Fix plist when NO_LLD_LINK defined.

Sorry about this. Fixed in rP512326

Thu, Sep 19, 12:51 PM
brooks accepted D21676: makesyscalls.sh: Add COMPAT12 support.

See also D21366 which includes an identical review diff. I didn't commit it at the time as my initial deprecation target didn't immediately make sense.

Thu, Sep 19, 12:34 PM
brooks committed rP512330: Fix plist..
Fix plist.
Thu, Sep 19, 11:10 AM
brooks committed rP512326: Fix plist for the no-ld-link case..
Fix plist for the no-ld-link case.
Thu, Sep 19, 9:56 AM

Fri, Sep 13

brooks committed rP511972: Update to a new snapshot..
Update to a new snapshot.
Fri, Sep 13, 2:33 PM

Thu, Sep 12

brooks accepted D21618: SIOCSIFNAME: Do nothing if we're not actually changing.

LGTM.

Thu, Sep 12, 3:21 PM
brooks committed rP511878: llvm90:.
llvm90:
Thu, Sep 12, 12:50 PM

Wed, Sep 11

brooks closed D21605: Avoid the use of the non-portable -D argument to ls..
Wed, Sep 11, 5:01 PM
brooks committed rS352220: Avoid the use of the non-portable -D argument to ls..
Avoid the use of the non-portable -D argument to ls.
Wed, Sep 11, 5:01 PM
brooks created D21605: Avoid the use of the non-portable -D argument to ls..
Wed, Sep 11, 12:04 PM
brooks committed rP511801: Fix linkage with non-default python port options..
Fix linkage with non-default python port options.
Wed, Sep 11, 8:30 AM
brooks committed rP511800: Update to 9.0.0rc4..
Update to 9.0.0rc4.
Wed, Sep 11, 8:29 AM

Mon, Sep 9

brooks accepted D21492: Make linux_common depend on pty..

LGTM

Mon, Sep 9, 1:57 PM
brooks added inline comments to D21492: Make linux_common depend on pty..
Mon, Sep 9, 1:27 PM

Fri, Sep 6

brooks committed rP511300: Assorted build improvements:.
Assorted build improvements:
Fri, Sep 6, 11:05 AM

Tue, Sep 3

brooks added inline comments to D20687: Fix execution of linux binaries with glibc>=2.24.
Tue, Sep 3, 11:41 AM

Mon, Sep 2

brooks added a comment to D20687: Fix execution of linux binaries with glibc>=2.24.

I suspect I know what's going on. If vectp % 16 == 8 then when long argc is stuck in front of it per the ABI requirements, the stack is aligned to 16 bytes. I suspect a change was made to require 16-byte alignment as recommend by Intel. A possibly relevant thread (I've only skimmed it) https://lore.kernel.org/patchwork/patch/749568/

Mon, Sep 2, 7:21 PM
brooks accepted D17282: new syscall: __sysctlbyname.

LGTM

Mon, Sep 2, 2:04 PM
brooks added a comment to D17282: new syscall: __sysctlbyname.

sys/compat/freebsd32/syscalls.master seems to be missing now...

Mon, Sep 2, 1:43 PM
brooks accepted D21445: library should not modify global process state by calling sigaction(2).

LGTM

Mon, Sep 2, 1:41 PM
brooks committed rS351690: Remove remnants of optimization for > pagesize allocations..
Remove remnants of optimization for > pagesize allocations.
Mon, Sep 2, 8:03 AM
brooks closed D21453: Remove remnants of optimization for > pagesize allocations..
Mon, Sep 2, 8:03 AM
brooks committed rP510767: Update to 9.0.0rc3..
Update to 9.0.0rc3.
Mon, Sep 2, 7:22 AM

Fri, Aug 30

brooks added a comment to D21453: Remove remnants of optimization for > pagesize allocations..
  • Remove dead check.
  • Return immediatly from the loop if bucket gets to big.
Fri, Aug 30, 7:58 AM

Thu, Aug 29

brooks added reviewers for D21453: Remove remnants of optimization for > pagesize allocations.: kib, imp, jhb.

I've now booted on amd64 in addition to CheriBSD.

Thu, Aug 29, 8:45 AM

Wed, Aug 28

brooks created D21453: Remove remnants of optimization for > pagesize allocations..
Wed, Aug 28, 3:44 PM
brooks committed rS351568: MFC r351389:.
MFC r351389:
Wed, Aug 28, 8:11 AM
brooks committed rS351567: MFC r348446:.
MFC r348446:
Wed, Aug 28, 8:05 AM
brooks committed rS351566: MFC r340424:.
MFC r340424:
Wed, Aug 28, 7:53 AM
brooks committed rS351565: Regenerate to add @generated tag in generated files..
Regenerate to add @generated tag in generated files.
Wed, Aug 28, 7:44 AM
brooks committed rS351564: MFC r339624:.
MFC r339624:
Wed, Aug 28, 7:37 AM

Tue, Aug 27

brooks added inline comments to D21393: [3/3] Add linux-compatible memfd_create.
Tue, Aug 27, 4:22 PM
brooks added inline comments to D21393: [3/3] Add linux-compatible memfd_create.
Tue, Aug 27, 12:06 PM

Aug 23 2019

brooks committed rP509638: New option PYCLANG to add python binding for clang..
New option PYCLANG to add python binding for clang.
Aug 23 2019, 10:06 AM

Aug 22 2019

brooks created D21366: Add COMPAT12 support to makesyscalls.sh..
Aug 22 2019, 2:16 PM
brooks committed rP509597: Update to a new snapshot..
Update to a new snapshot.
Aug 22 2019, 12:43 PM
brooks committed rS351389: Reorganise conditionals to reduce duplication..
Reorganise conditionals to reduce duplication.
Aug 22 2019, 10:21 AM

Aug 21 2019

D17282: new syscall: __sysctlbyname now requires changes to proceed.

It would be helpful to generate this diff against HEAD. That would exclude the generated files and the freebsd32 capabilities.conf entry.

Aug 21 2019, 9:16 AM

Aug 20 2019

brooks committed rS351251: Remove some compatability with Seventh Edition UNIX realloc()..
Remove some compatability with Seventh Edition UNIX realloc().
Aug 20 2019, 4:07 PM
brooks closed D21296: Remove some compatability with Seventh Edition UNIX realloc()..
Aug 20 2019, 4:07 PM

Aug 19 2019

brooks updated the summary of D21296: Remove some compatability with Seventh Edition UNIX realloc()..
Aug 19 2019, 10:16 AM
D21296: Remove some compatability with Seventh Edition UNIX realloc(). now requires review to proceed.
  • Always follow the allocated path, don't free prematurely.
Aug 19 2019, 10:13 AM

Aug 17 2019

brooks created D21296: Remove some compatability with Seventh Edition UNIX realloc()..
Aug 17 2019, 12:01 AM

Aug 16 2019

brooks committed rS351132: md(4): remove the unused and unusable MDIOCLIST ioctl..
md(4): remove the unused and unusable MDIOCLIST ioctl.
Aug 16 2019, 6:57 PM
brooks closed D18936: Remove the unused and unusable MDIOCLIST ioctl..
Aug 16 2019, 6:57 PM

Aug 15 2019

brooks committed rP509054: Update to 9.0.0rc2..
Update to 9.0.0rc2.
Aug 15 2019, 8:37 PM

Aug 9 2019

brooks committed rS350827: Don't add -Wno-class-memaccess with older gcc..
Don't add -Wno-class-memaccess with older gcc.
Aug 9 2019, 11:51 PM
Owners added a reviewer for D21195: Don't add -Wno-class-memaccess with older gcc.: Restricted Owners Package.
Aug 9 2019, 11:51 PM
brooks retitled D21195: Don't add -Wno-class-memaccess with older gcc. from Don't add -Wno-class-memaccess with modern gcc. to Don't add -Wno-class-memaccess with older gcc..
Aug 9 2019, 8:38 PM
brooks added a comment to D21195: Don't add -Wno-class-memaccess with older gcc..

I've fixed the expression to exclude gcc < 8 and tested on amd64 and riscv.

Aug 9 2019, 8:36 PM
brooks added a comment to D21195: Don't add -Wno-class-memaccess with older gcc..
  • Use the correct expression to add -Wno-class-memaccess.
Aug 9 2019, 8:35 PM
brooks added a comment to D21195: Don't add -Wno-class-memaccess with older gcc..

I completely misunderstood what was going on. The in .. excludes gcc 4.2.1 and this is a gcc 8.0+ warning. The incorrect copy and paste meant it worked by accident for 6.4. I'm testing a new version now...

Aug 9 2019, 3:56 PM

Aug 8 2019

brooks added a comment to D21195: Don't add -Wno-class-memaccess with older gcc..

This is breaking the xtoolchain CI jobs https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/10997/

Aug 8 2019, 11:33 PM
brooks added a reviewer for D21195: Don't add -Wno-class-memaccess with older gcc.: asomers.
Aug 8 2019, 11:33 PM
brooks created D21195: Don't add -Wno-class-memaccess with older gcc..
Aug 8 2019, 11:30 PM

Aug 7 2019

brooks committed rP508349: Assorted minor improvements:.
Assorted minor improvements:
Aug 7 2019, 7:53 PM

Aug 5 2019

brooks committed rP508191: Allow builds with a default python version on 3.7..
Allow builds with a default python version on 3.7.
Aug 5 2019, 4:15 PM
brooks committed rP508190: Welcome LLVM 9.0.0rc1 to the tree..
Welcome LLVM 9.0.0rc1 to the tree.
Aug 5 2019, 4:10 PM

Aug 2 2019

brooks committed rS350545: MFC r350228:.
MFC r350228:
Aug 2 2019, 10:34 PM
brooks committed rS350543: MFC r350228:.
MFC r350228:
Aug 2 2019, 8:31 PM
brooks committed rS350542: MFC r350218:.
MFC r350218:
Aug 2 2019, 8:24 PM
brooks committed rS350539: MFC r350160:.
MFC r350160:
Aug 2 2019, 4:05 PM

Aug 1 2019

brooks committed rS350526: MFC r350160:.
MFC r350160:
Aug 1 2019, 11:29 PM
brooks committed rP507836: Address a code generation bug that could allow the ARM stack protector.
Address a code generation bug that could allow the ARM stack protector
Aug 1 2019, 11:27 PM

Jul 31 2019

brooks committed rS350476: MFC r350159:.
MFC r350159:
Jul 31 2019, 6:40 PM
brooks committed rS350475: MFC r350158:.
MFC r350158:
Jul 31 2019, 6:26 PM
brooks committed rS350474: MFC r350157:.
MFC r350157:
Jul 31 2019, 6:11 PM
brooks committed rS350473: MFC r350157:.
MFC r350157:
Jul 31 2019, 5:56 PM
brooks committed rS350470: MFC r350143, r350148.
MFC r350143, r350148
Jul 31 2019, 5:29 PM
brooks committed rS350469: MFC r350143, r350148.
MFC r350143, r350148
Jul 31 2019, 5:01 PM

Jul 30 2019

D21092: freebsd32 shims for copy_file_range(2) is now accepted and ready to land.

LGTM

Jul 30 2019, 10:16 PM

Jul 29 2019

brooks added a comment to D21092: freebsd32 shims for copy_file_range(2).

Why is a shim required? All arguments are extended to 64-bits as part of the combat layer. There would be an issue if len were an off_t, but it's a size_t. The only pointers point to off_t's which are always 64-bit and thus require no special handling.

Jul 29 2019, 6:09 PM

Jul 26 2019

brooks committed rS350345: MFC r316803,320033,338277,350098,350100-350101.
MFC r316803,320033,338277,350098,350100-350101
Jul 26 2019, 2:50 AM
Herald updated subscribers of D10995: tcp: tcpdchk & tcpdmatch: warning fixes.
Jul 26 2019, 2:49 AM

Jul 25 2019

brooks committed rS350334: MFC r350117:.
MFC r350117:
Jul 25 2019, 8:35 PM
brooks committed rS350332: MFC r350117:.
MFC r350117:
Jul 25 2019, 8:01 PM
brooks committed rS350330: MFC r350116:.
MFC r350116:
Jul 25 2019, 6:16 PM
brooks committed rS350329: MFC r350116:.
MFC r350116:
Jul 25 2019, 5:33 PM
brooks committed rS350328: MFC r350067:.
MFC r350067:
Jul 25 2019, 5:30 PM

Jul 24 2019

brooks committed rS350305: MFC r350102:.
MFC r350102:
Jul 24 2019, 9:40 PM
brooks committed rS350304: MFC r350067:.
MFC r350067:
Jul 24 2019, 9:39 PM
brooks committed rS350300: MFC r350049:.
MFC r350049:
Jul 24 2019, 8:18 PM
brooks committed rS350299: MFC r350102:.
MFC r350102:
Jul 24 2019, 7:57 PM
brooks committed rS350296: MFC r350098, r350100-r350101.
MFC r350098, r350100-r350101
Jul 24 2019, 7:16 PM
brooks updated the summary of D20799: Eliminate the last MI difference in AT_* definitions (for powerpc)..
Jul 24 2019, 5:25 PM
brooks added a comment to D20799: Eliminate the last MI difference in AT_* definitions (for powerpc)..

This looks like it provides a viable update path. As you say, libc may have some edge case issues, but it does look like it does the job of letting people upgrade without a reinstall from media. What do you think about about timing this change? It seems like it should happen close to the ELFv2 switch so people get the whole thing out of the way at once.

Jul 24 2019, 5:07 PM
brooks added a comment to D20799: Eliminate the last MI difference in AT_* definitions (for powerpc)..
  • Detect old auxargs constant and translate them (from bdragon@).
  • Put freebsd_fixup_old_auxargs under #ifdef powerpc.
Jul 24 2019, 5:02 PM

Jul 23 2019

brooks added a comment to D20799: Eliminate the last MI difference in AT_* definitions (for powerpc)..

OK, I wasn't sure exactly how the bits in rtld were going to go. It doesn't look like this is going to be as much help as I'd hoped.

Jul 23 2019, 10:27 PM
brooks added inline comments to D20799: Eliminate the last MI difference in AT_* definitions (for powerpc)..
Jul 23 2019, 2:57 AM
brooks added a comment to D20799: Eliminate the last MI difference in AT_* definitions (for powerpc)..
  • Use the correct AT_COUNT value, not the CheriBSD one.
Jul 23 2019, 2:56 AM
brooks added inline comments to D20799: Eliminate the last MI difference in AT_* definitions (for powerpc)..
Jul 23 2019, 2:47 AM

Jul 22 2019

brooks committed rP507178: Update to LLVM 8.0.1..
Update to LLVM 8.0.1.
Jul 22 2019, 10:42 PM
brooks added inline comments to D21031: Add mkostempsat(3)..
Jul 22 2019, 10:23 PM
brooks closed D21002: ata_xpt: Use the correct union member when accessing valid.
Jul 22 2019, 9:08 PM
brooks committed rS350228: ata_xpt: Use the correct union member when accessing valid..
ata_xpt: Use the correct union member when accessing valid.
Jul 22 2019, 9:08 PM
brooks committed rS350218: Be consistent about temporary variable use in adjacent loops..
Be consistent about temporary variable use in adjacent loops.
Jul 22 2019, 6:27 PM
brooks added a comment to D20799: Eliminate the last MI difference in AT_* definitions (for powerpc)..

Did you apply a manual bump of __FreeBSD_version and P_OSREL_POWERPC_NEW_AUX_ARGS? That part of the patch is now out of date.

Jul 22 2019, 6:06 PM

Jul 19 2019

brooks committed rS350160: Avoid copying too much from the input string..
Avoid copying too much from the input string.
Jul 19 2019, 11:58 PM
brooks closed D21004: Avoid copying too much from the input string..
Jul 19 2019, 11:58 PM