Page MenuHomeFreeBSD
Feed Advanced Search

Wed, Nov 25

brooks added a comment to D19237: Fix TARGET_TRIPLE assembly and retrieve OS version automatically.

This generally looks fine.

Wed, Nov 25, 11:24 PM · PowerPC
brooks accepted D27347: Reformat sys/compat/freebsd32/syscalls.master with new style..

This is fine. I didn't do it because it with kern/syscalls.master was a bunch of work and I intended to delete this file in the near future. I still intend to delete it, but I've not managed to get the task of finishing the job to the top of my priority list long enough.

Wed, Nov 25, 10:22 PM
brooks added a comment to D27222: [1/2] _umtx_op: reduce redundancy required for compat32.

Unfortunately, much of the redundancy removed here isn't redundant for CHERI. On CHERI systems freebsd32__umtx_op_args can not be cast to _umtx_op_args. I'll need to ponder how best to proceed. For now I think I'll merge as-is and make compat32 more broken in CheriBSD.

Wed, Nov 25, 12:06 AM

Fri, Nov 20

brooks added inline comments to D27290: Switch to environment files for Github actions.
Fri, Nov 20, 5:20 PM

Thu, Nov 19

brooks added a comment to D27290: Switch to environment files for Github actions.

Failure: https://github.com/CTSRD-CHERI/cheribsd/runs/1427289786
Success: https://github.com/CTSRD-CHERI/cheribsd/runs/1427570600

Thu, Nov 19, 11:55 PM
brooks requested review of D27290: Switch to environment files for Github actions.
Thu, Nov 19, 11:50 PM
brooks added inline comments to D26617: Rename DISTDIR to RELDISTDIR to avoid clash with ports DISTDIR defined in make.conf.
Thu, Nov 19, 11:04 PM
brooks added inline comments to D27287: Look for drti.o in WORLDTMP when building dtrace probes..
Thu, Nov 19, 10:13 PM
brooks updated the summary of D27159: Match all MIPS and RISC-V MACHINE_ARCH values.
Thu, Nov 19, 12:31 AM
brooks updated the summary of D27159: Match all MIPS and RISC-V MACHINE_ARCH values.
Thu, Nov 19, 12:31 AM
brooks updated the diff for D27159: Match all MIPS and RISC-V MACHINE_ARCH values.
  • Remove nonsensical !s
Thu, Nov 19, 12:29 AM
brooks added a comment to D27159: Match all MIPS and RISC-V MACHINE_ARCH values.

I'm likewise skeptical that any powerpc works

Thu, Nov 19, 12:28 AM
brooks updated the diff for D27159: Match all MIPS and RISC-V MACHINE_ARCH values.
  • Fix powerpc64 case.
  • Use MACHINE_CPUARCH for mips and riscv
Thu, Nov 19, 12:21 AM

Tue, Nov 17

brooks accepted D27240: [zfs] Fix LZ4 function definitions to not trip up the compile.

How did this work for anyone? I tripped on it in CheriBSD on aarch64 just now (this is with llvm ~11.0.0).

Tue, Nov 17, 4:45 PM

Mon, Nov 16

brooks closed D27211: Add a guard for broken SUBDIR.${MK_FOO} use.
Mon, Nov 16, 7:15 PM
brooks committed rS367735: Add a guard for broken SUBDIR.${MK_FOO} use.
Add a guard for broken SUBDIR.${MK_FOO} use
Mon, Nov 16, 7:15 PM
brooks committed rS367728: Add missing includes of src.opts.mk.
Add missing includes of src.opts.mk
Mon, Nov 16, 5:20 PM

Fri, Nov 13

brooks closed D27210: Add missing src.opts.mk include.
Fri, Nov 13, 11:18 PM
brooks committed rS367655: Add missing src.opts.mk include.
Add missing src.opts.mk include
Fri, Nov 13, 11:18 PM
brooks retitled D27210: Add missing src.opts.mk include from Add missing src.opts.mk include This was missed in r364221 so tests were not built. to Add missing src.opts.mk include.
Fri, Nov 13, 10:44 PM
brooks requested review of D27211: Add a guard for broken SUBDIR.${MK_FOO} use.
Fri, Nov 13, 10:36 PM
brooks requested review of D27210: Add missing src.opts.mk include.
Fri, Nov 13, 10:32 PM
brooks accepted D27197: df: Remove support for mounting devices.

kill it with fire

Fri, Nov 13, 4:33 PM
brooks accepted D27183: [malloc] quieten -Werror=missing-braces with malloc.h wth gcc-6.4.
Fri, Nov 13, 12:45 AM

Wed, Nov 11

brooks added inline comments to D27183: [malloc] quieten -Werror=missing-braces with malloc.h wth gcc-6.4.
Wed, Nov 11, 10:47 PM
brooks committed rS367601: MFC r367302:.
MFC r367302:
Wed, Nov 11, 10:01 PM

Tue, Nov 10

brooks added a comment to D27159: Match all MIPS and RISC-V MACHINE_ARCH values.

I remember that powerpc64le is on it's way so I've given powerp64 the same treatment.

Tue, Nov 10, 11:42 PM
brooks updated the diff for D27159: Match all MIPS and RISC-V MACHINE_ARCH values.
  • give powerpc64 the match treatment as well
Tue, Nov 10, 11:41 PM
brooks accepted D27170: Add INIT_ALL_ZERO and INIT_ALL_PATTERN to kern.opts.mk.
Tue, Nov 10, 10:54 PM
brooks committed rS367579: Be more tolerant of share/mk and kern.mk mismatch.
Be more tolerant of share/mk and kern.mk mismatch
Tue, Nov 10, 9:12 PM
brooks closed D27131: Add support for initializing stack variables on entry..
Tue, Nov 10, 7:15 PM
brooks committed rS367577: Support initializing stack variables on function entry.
Support initializing stack variables on function entry
Tue, Nov 10, 7:15 PM
brooks added a comment to D27131: Add support for initializing stack variables on entry..

CI build (which isn't very interesting) https://github.com/brooksdavis/freebsd/tree/init-all

Tue, Nov 10, 6:54 PM
brooks committed rS367571: MFC r367302:.
MFC r367302:
Tue, Nov 10, 6:07 PM
brooks added a comment to D23843: Return ENOTSUP for mmap/mprotect with prot not subset of prot_max.

This isn't about permissions on the existing page. This is: "the programmer said I want RX, but never more than R". EDOOFUS might be more appropriate, but is non-POSIX.

The two calls may not have been written by the same programmer if one or both are in libraries.

Tue, Nov 10, 5:49 PM
brooks added a comment to D23843: Return ENOTSUP for mmap/mprotect with prot not subset of prot_max.

This isn't about permissions on the existing page. This is: "the programmer said I want RX, but never more than R". EDOOFUS might be more appropriate, but is non-POSIX.

Tue, Nov 10, 5:34 PM
brooks added a comment to D27159: Match all MIPS and RISC-V MACHINE_ARCH values.

amd64 CI run https://cirrus-ci.com/task/5036030833197056

Tue, Nov 10, 4:41 AM
brooks added a comment to D27159: Match all MIPS and RISC-V MACHINE_ARCH values.

There might be something to be said for a LINKER_FEATURES=lto in bsd.compiler.mk, but I'm not sure that we need to generalize from one example.

Tue, Nov 10, 12:51 AM
brooks requested review of D27159: Match all MIPS and RISC-V MACHINE_ARCH values.
Tue, Nov 10, 12:50 AM

Sat, Nov 7

brooks updated the summary of D27131: Add support for initializing stack variables on entry..
Sat, Nov 7, 12:29 AM
brooks added a comment to D27131: Add support for initializing stack variables on entry..

We've tested this extensively in CheriBSD on RISC-V.

Sat, Nov 7, 12:29 AM
brooks requested review of D27131: Add support for initializing stack variables on entry..
Sat, Nov 7, 12:27 AM

Fri, Nov 6

brooks added a comment to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.

Is specialfd supposed to be a public or private interface? If private I'd suggest __specialfd to make that clear.

Fri, Nov 6, 11:48 PM · Linux Emulation
brooks updated the diff for D27093: VFS_QUOTACTL: Remove needless casts of arg argument.
  • VFS_QUOTACTL(9): correct type of arg
Fri, Nov 6, 6:15 PM

Wed, Nov 4

brooks requested review of D27093: VFS_QUOTACTL: Remove needless casts of arg argument.
Wed, Nov 4, 10:01 PM
brooks added a reviewer for D27088: Add .cfi_{start,end}proc annotations for MIPS assembly: adrian.
Wed, Nov 4, 6:40 PM
brooks accepted D27088: Add .cfi_{start,end}proc annotations for MIPS assembly.
Wed, Nov 4, 6:39 PM

Tue, Nov 3

brooks committed rS367315: MFC r367121:.
MFC r367121:
Tue, Nov 3, 11:30 PM
brooks committed rS367314: MFC r367121:.
MFC r367121:
Tue, Nov 3, 11:29 PM
brooks committed rS367313: MFC r367063:.
MFC r367063:
Tue, Nov 3, 11:27 PM
brooks committed rS367312: MFC r367063:.
MFC r367063:
Tue, Nov 3, 11:27 PM
brooks closed D27077: sysvshm: pass relavent uap members as arguments.
Tue, Nov 3, 7:14 PM
brooks committed rS367302: sysvshm: pass relevant uap members as arguments.
sysvshm: pass relevant uap members as arguments
Tue, Nov 3, 7:14 PM
brooks requested review of D27077: sysvshm: pass relavent uap members as arguments.
Tue, Nov 3, 5:44 PM

Thu, Oct 29

brooks committed rS367145: MFC r366911:.
MFC r366911:
Thu, Oct 29, 10:00 PM
brooks committed rP553642: Update to a new snapshot..
Update to a new snapshot.
Thu, Oct 29, 9:21 PM
brooks committed rS367140: MFC r366911:.
MFC r366911:
Thu, Oct 29, 6:29 PM

Wed, Oct 28

brooks closed D26982: Disable raw test without ASAN.
Wed, Oct 28, 11:11 PM
brooks committed rS367121: Disable ssp raw test without ASAN.
Disable ssp raw test without ASAN
Wed, Oct 28, 11:11 PM
brooks committed rP553556: Bump port revion after r553456.
Bump port revion after r553456
Wed, Oct 28, 5:16 PM

Oct 27 2020

brooks requested review of D26982: Disable raw test without ASAN.
Oct 27 2020, 9:39 PM
brooks committed rP553456: Fix application of openmp patch.
Fix application of openmp patch
Oct 27 2020, 5:04 PM

Oct 26 2020

brooks closed D26902: Key decleration of union semun on src version.
Oct 26 2020, 5:52 PM
brooks committed rS367063: Key decleration of union semun on src version.
Key decleration of union semun on src version
Oct 26 2020, 5:52 PM
brooks committed rS367062: MFC r366981:.
MFC r366981:
Oct 26 2020, 5:50 PM
brooks committed rS367061: MFC r366981:.
MFC r366981:
Oct 26 2020, 5:47 PM

Oct 23 2020

brooks closed D26903: Only use ASAN when using the in-tree compiler.
Oct 23 2020, 10:28 PM
brooks committed rS366981: Only use ASAN when using the in-tree compiler.
Only use ASAN when using the in-tree compiler
Oct 23 2020, 10:28 PM

Oct 22 2020

brooks added a comment to D26902: Key decleration of union semun on src version.

Technically speaking this code is broken on FreeBSD <2 (see the code right above this), but I can't bring myself to do the reshuffling to fix that...

Oct 22 2020, 10:41 PM
brooks added a comment to D26902: Key decleration of union semun on src version.

The check is also just plain wrong. The question isn't "what version of FreeBSD is the compiler targeting?" It's "what version of FreeBSD is providing the headers?" Obviously they should match, but checking the right thing means I don't have to dig into libcompat build bits on 11.

Oct 22 2020, 7:53 PM
brooks committed rS366940: MFC r366671:.
MFC r366671:
Oct 22 2020, 4:41 PM
brooks committed rS366939: MFC r366731:.
MFC r366731:
Oct 22 2020, 4:29 PM
brooks committed rS366938: MFC r366731:.
MFC r366731:
Oct 22 2020, 4:27 PM
brooks added a comment to D26903: Only use ASAN when using the in-tree compiler.

I couldn't find an easier way to determine if the compiler was suitable. It might be that we want to skip these tests entirely instead, but then we're voting to make them dead code in the long term.

Oct 22 2020, 4:21 PM
brooks requested review of D26903: Only use ASAN when using the in-tree compiler.
Oct 22 2020, 4:18 PM
brooks requested review of D26902: Key decleration of union semun on src version.
Oct 22 2020, 4:11 PM

Oct 21 2020

brooks committed rS366912: MFC r366671:.
MFC r366671:
Oct 21 2020, 4:05 PM
brooks closed D26784: vmapbuf: don't smuggle user address via b_data.
Oct 21 2020, 4:00 PM
brooks committed rS366911: vmapbuf: don't smuggle address or length in buf.
vmapbuf: don't smuggle address or length in buf
Oct 21 2020, 4:00 PM

Oct 19 2020

brooks committed rP552775: New snapshot and infrastructure updates.
New snapshot and infrastructure updates
Oct 19 2020, 11:06 PM
brooks updated the diff for D26784: vmapbuf: don't smuggle user address via b_data.
  • GC a dead check.
Oct 19 2020, 9:06 PM
brooks added a comment to D26784: vmapbuf: don't smuggle user address via b_data.

https://cirrus-ci.com/task/5974398819631104

Oct 19 2020, 5:21 PM
brooks updated the diff for D26784: vmapbuf: don't smuggle user address via b_data.
  • Pass size rather than smuggling via b_bufsize.
Oct 19 2020, 3:09 PM

Oct 15 2020

brooks added a comment to D26784: vmapbuf: don't smuggle user address via b_data.

CI run: https://cirrus-ci.com/task/5059292485124096

Oct 15 2020, 5:35 PM
brooks closed D26783: physio: Don't store user addresses in bio_data.
Oct 15 2020, 5:05 PM
brooks committed rS366731: physio: Don't store user addresses in bio_data.
physio: Don't store user addresses in bio_data
Oct 15 2020, 5:05 PM

Oct 14 2020

brooks requested review of D26784: vmapbuf: don't smuggle user address via b_data.
Oct 14 2020, 11:53 PM
brooks added a comment to D26783: physio: Don't store user addresses in bio_data.

I needed this change in CheriBSD because we can't store user pointers in bio_data due to a type mismatch and we need to pass the pointer (rather than an address) to vm_fault_quick_hold_pages.

Oct 14 2020, 10:04 PM
brooks added a comment to D26783: physio: Don't store user addresses in bio_data.

Cirrus-CI run https://cirrus-ci.com/task/5195860164214784

Oct 14 2020, 10:02 PM
brooks requested review of D26783: physio: Don't store user addresses in bio_data.
Oct 14 2020, 10:01 PM
brooks created P439 so many stack traces....
Oct 14 2020, 6:34 PM
brooks created P438 panic shortly after mount root .
Oct 14 2020, 5:59 PM
brooks accepted D26776: Skip make includes for (most) directories without includes.

This looks like a nice improvement and the error/warning bits resolve my initial concern about maintenance.

Oct 14 2020, 5:08 PM
brooks added a comment to D26668: Expose eventfd in the native API/ABI using a new __specialfd syscall.

Ooh I just had a galaxy brain idea. What if we introduce one syscall, specialfd with args being an int for the type constant and a void* that points to per-type args structs. (Maybe also len to allow extending structs while keeping the same type.) This way, one syscall would allow adding more similar facilities later (like timerfd or something completely new.. and e.g. shm_open2 could have been this) without having a new syscall-worthiness debate each time!

Oct 14 2020, 4:52 PM · Linux Emulation

Oct 13 2020

brooks committed rP552284: Resurrect devel/llvm-cheri and update.
Resurrect devel/llvm-cheri and update
Oct 13 2020, 9:10 PM
brooks committed rS366684: Remove --ld-path=* from _LDFLAGS.
Remove --ld-path=* from _LDFLAGS
Oct 13 2020, 8:04 PM
brooks closed D26592: libgssapi: modernize static string array use.
Oct 13 2020, 5:14 PM
brooks committed rS366671: libgssapi: modernize static string array use.
libgssapi: modernize static string array use
Oct 13 2020, 5:14 PM

Oct 12 2020

brooks committed rP552154: Welcome 11.0.0 release..
Welcome 11.0.0 release.
Oct 12 2020, 10:31 PM

Oct 5 2020

brooks committed rP551536: Update to 11.0.0rc5..
Update to 11.0.0rc5.
Oct 5 2020, 7:04 PM