Feed Advanced Search

Yesterday

brooks committed rP477756: Limit LLVM builds to linking a single binary at a time..
Limit LLVM builds to linking a single binary at a time.
Tue, Aug 21, 8:29 PM
brooks committed rP477755: Fix builds without DOCS..
Fix builds without DOCS.
Tue, Aug 21, 8:26 PM
brooks committed rS338149: Revert r337978: Rework rtld's TLS Variant I implementation to match r326794.
Revert r337978: Rework rtld's TLS Variant I implementation to match r326794
Tue, Aug 21, 6:22 PM

Fri, Aug 17

brooks accepted D16735: Create devctl freeze/thaw..

Not my area of expertise, but looks valid to me.

Fri, Aug 17, 7:49 PM
brooks committed rP477441: Switch from ninja to Makefiles to work around bugs in generated ninja code..
Switch from ninja to Makefiles to work around bugs in generated ninja code.
Fri, Aug 17, 6:20 PM
brooks committed rS337978: Rework rtld's TLS Variant I implementation to match r326794.
Rework rtld's TLS Variant I implementation to match r326794
Fri, Aug 17, 4:20 PM
brooks closed D16510: Rework rtld's TLS Variant I implementation to match r326794.
Fri, Aug 17, 4:20 PM
brooks committed rP477434: Mark broken on 10.x..
Mark broken on 10.x.
Fri, Aug 17, 3:30 PM

Thu, Aug 16

brooks committed rP477400: Update a newer snapshow to support code generated by the latest.
Update a newer snapshow to support code generated by the latest
Thu, Aug 16, 11:50 PM
brooks committed rP477399: Update to a new snapshot..
Update to a new snapshot.
Thu, Aug 16, 11:48 PM
brooks committed rP477380: Update to a new snapshot. LLVM trunk is now 8.0..
Update to a new snapshot. LLVM trunk is now 8.0.
Thu, Aug 16, 10:51 PM
brooks committed rP477377: Add textproc/py-recommonmark:.
Add textproc/py-recommonmark:
Thu, Aug 16, 9:14 PM
brooks accepted D16745: Use MACHINE_CPUARCH/TARGET_CPUARCH in preference to MACHINE/TARGET and minor cleanup.

LGTM

Thu, Aug 16, 4:19 PM
brooks committed rS337912: MFC r337727 (rewritten due to unmerged API change in 11+):.
MFC r337727 (rewritten due to unmerged API change in 11+):
Thu, Aug 16, 3:54 PM
brooks committed rS337909: MFC r337727:.
MFC r337727:
Thu, Aug 16, 3:27 PM

Wed, Aug 15

brooks committed rP477293: Fix build with clang 7.0..
Fix build with clang 7.0.
Wed, Aug 15, 10:40 PM
brooks updated the diff for D16730: Committers Guide: Add a section encouraging pre-commit review..
  • Clarify that explicit approval can take any form that makes sense.
Wed, Aug 15, 9:21 PM
brooks retitled D16730: Committers Guide: Add a section encouraging pre-commit review. from Committers Guild: Add a section encouraging pre-commit review. to Committers Guide: Add a section encouraging pre-commit review..
Wed, Aug 15, 9:04 PM
brooks updated the diff for D16730: Committers Guide: Add a section encouraging pre-commit review..
  • Fix unicode apostrophes.
  • Convey that reviewers can't usually be any random committer.
Wed, Aug 15, 9:04 PM
brooks updated the diff for D16730: Committers Guide: Add a section encouraging pre-commit review..
  • Clarify an edit-o. @imp's large comment to be addressed seperately.
Wed, Aug 15, 8:49 PM
brooks added inline comments to D16730: Committers Guide: Add a section encouraging pre-commit review..
Wed, Aug 15, 8:49 PM
brooks added a comment to D16730: Committers Guide: Add a section encouraging pre-commit review..

For reference: https://llvm.org/docs/DeveloperPolicy.html#code-reviews

Wed, Aug 15, 6:37 PM
brooks retitled D16730: Committers Guide: Add a section encouraging pre-commit review. from Add a section encouraging pre-commit review. to Committers Guild: Add a section encouraging pre-commit review..
Wed, Aug 15, 6:37 PM
brooks created D16730: Committers Guide: Add a section encouraging pre-commit review..
Wed, Aug 15, 6:35 PM

Tue, Aug 14

brooks committed rS337768: MFC r337508:.
MFC r337508:
Tue, Aug 14, 4:25 PM
brooks committed rS337766: MFC r337508:.
MFC r337508:
Tue, Aug 14, 4:22 PM
brooks committed rP477133: Add a port of LLVM 7.0.0.rc1 based on devel/llvm60..
Add a port of LLVM 7.0.0.rc1 based on devel/llvm60.
Tue, Aug 14, 2:55 AM

Mon, Aug 13

brooks committed rP477121: Garbage collect LLVM and Clang 3.4..
Garbage collect LLVM and Clang 3.4.
Mon, Aug 13, 10:56 PM
brooks committed rP477120: At long last, garbage collect LLVM and Clang 3.3..
At long last, garbage collect LLVM and Clang 3.3.
Mon, Aug 13, 10:48 PM
brooks committed rS337727: Copy out from kernel to data, not the other way around..
Copy out from kernel to data, not the other way around.
Mon, Aug 13, 9:53 PM
brooks committed rP477118: Update clang/llvm version to 6.0 (used on FreeBSD 10).
Update clang/llvm version to 6.0 (used on FreeBSD 10)
Mon, Aug 13, 9:31 PM

Thu, Aug 9

brooks committed rP476795: Remove (non-default) support for building with LLVM 3.8 and 3.9..
Remove (non-default) support for building with LLVM 3.8 and 3.9.
Thu, Aug 9, 5:41 PM
brooks closed D16634: lang/rubinius: Remove (non-default) support for building with LLVM 3.8 and 3.9..
Thu, Aug 9, 5:41 PM

Wed, Aug 8

brooks committed rS337508: Terminate filter_create_ext() args with NULL, not 0..
Terminate filter_create_ext() args with NULL, not 0.
Wed, Aug 8, 10:45 PM
brooks committed rP476669: Remove obsolete Clang 3.8 support from bazel..
Remove obsolete Clang 3.8 support from bazel.
Wed, Aug 8, 7:51 PM
brooks committed rP476660: Depend on the real port, not the removed METAPORT on 10.x..
Depend on the real port, not the removed METAPORT on 10.x.
Wed, Aug 8, 7:12 PM
brooks committed rP476658: Remove broken and expired port which also depends on clang38 (on 10)..
Remove broken and expired port which also depends on clang38 (on 10).
Wed, Aug 8, 7:09 PM
brooks committed rP476656: Deprecate gps. It is unmaintained and depends on an obsolete LLVM version..
Deprecate gps. It is unmaintained and depends on an obsolete LLVM version.
Wed, Aug 8, 7:03 PM
brooks created D16634: lang/rubinius: Remove (non-default) support for building with LLVM 3.8 and 3.9..
Wed, Aug 8, 6:57 PM
brooks committed rP476655: Remove METAPORTs for obsolete LLVM 3.8..
Remove METAPORTs for obsolete LLVM 3.8.
Wed, Aug 8, 6:46 PM

Mon, Jul 30

brooks added reviewers for D16510: Rework rtld's TLS Variant I implementation to match r326794: jhibbits, andrew, br.
Mon, Jul 30, 3:23 PM

Fri, Jul 27

brooks added inline comments to D16090: Comitter guide: rewrite the section on testing..
Fri, Jul 27, 5:17 PM

Jul 19 2018

brooks accepted D16349: Set a mode when calling open with O_CREAT.

LGTM. I'd commit the netbsd ones separately and forward the commit some appropriate netbsd list (probably tech-kern).

Jul 19 2018, 11:17 PM

Jul 16 2018

brooks committed rS336340: MFC r336238:.
MFC r336238:
Jul 16 2018, 2:17 PM
brooks accepted D16245: Fix buildworld on FreeBSD 10.

LGTM

Jul 16 2018, 7:59 AM

Jul 13 2018

brooks committed rS336238: Round down the location of execpathp to slightly improve copyout speed..
Round down the location of execpathp to slightly improve copyout speed.
Jul 13 2018, 11:32 AM

Jul 10 2018

brooks accepted D16142: Get rid of some remnants of the old numa..

Looks good to me. Some may complain about the Xr references to the removed numa_getaffinity(2) and numa_setaffinity(2) in numa(4), but I think it's fine given that they are removed from the SEE ALSO.

Jul 10 2018, 2:08 PM
brooks committed rS336172: Regen after r336171..
Regen after r336171.
Jul 10 2018, 2:05 PM
brooks committed rS336171: Get rid of netbsd_lchown and netbsd_msync syscall entries..
Get rid of netbsd_lchown and netbsd_msync syscall entries.
Jul 10 2018, 1:32 PM
brooks closed D16193: Get rid of netbsd_lchown and netbsd_msync syscall entries..
Jul 10 2018, 1:32 PM

Jul 9 2018

brooks created D16193: Get rid of netbsd_lchown and netbsd_msync syscall entries..
Jul 9 2018, 9:26 AM
brooks accepted D16187: No longer install sys/nv.h and sys/cnv.h in lib/libnv/Makefile.

LGTM

Jul 9 2018, 9:19 AM

Jul 6 2018

brooks committed rS336033: One more 32-bit fix for r335979..
One more 32-bit fix for r335979.
Jul 6 2018, 1:35 PM
brooks committed rS336023: Correct breakage on 32-bit platforms from r335979..
Correct breakage on 32-bit platforms from r335979.
Jul 6 2018, 10:03 AM

Jul 5 2018

brooks committed rS336002: Work around lame warnings in ancient gcc on 32-bit platforms..
Work around lame warnings in ancient gcc on 32-bit platforms.
Jul 5 2018, 5:02 PM
brooks committed rS335990: Revert r335983..
Revert r335983.
Jul 5 2018, 4:03 PM
brooks added a comment to D16142: Get rid of some remnants of the old numa..

It looks like usr.bin/Makefile also needs an update to unhook the removed numactl.

Jul 5 2018, 3:12 PM
brooks added a comment to D16141: Disable sbrk() use in GNU tools..

Although we still need to make sure that everything still works with this change.

Jul 5 2018, 3:06 PM
brooks added inline comments to D16141: Disable sbrk() use in GNU tools..
Jul 5 2018, 2:43 PM
brooks created D16141: Disable sbrk() use in GNU tools..
Jul 5 2018, 2:36 PM
brooks committed rS335983: Get rid of netbsd_lchown and netbsd_msync syscall entries..
Get rid of netbsd_lchown and netbsd_msync syscall entries.
Jul 5 2018, 2:13 PM
brooks closed D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
Jul 5 2018, 2:13 PM
brooks committed rD51966: Document 1200072..
Document 1200072.
Jul 5 2018, 2:05 PM
brooks closed D15386: Improve portability of structs xinpcb and friends..
Jul 5 2018, 1:14 PM
brooks committed rS335979: Make struct xinpcb and friends word-size independent..
Make struct xinpcb and friends word-size independent.
Jul 5 2018, 1:14 PM
brooks added a comment to D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
readelf -a libc.so.7.full | grep netbsd
   905: 000000000008cf10    11 FUNC    GLOBAL DEFAULT   12 netbsd_msync@FBSD_1.0 (2)
  3141: 000000000008cf10    11 FUNC    GLOBAL DEFAULT   12 netbsd_lchown@FBSD_1.0 (2)
   165: 000000000008c0a0    17 FUNC    LOCAL  DEFAULT   12 __sys_netbsd_msync
   166: 000000000008c0a0    17 FUNC    LOCAL  DEFAULT   12 _netbsd_msync
   167: 000000000008c0a0    17 FUNC    LOCAL  DEFAULT   12 netbsd_msync
   168: 000000000008c0e0    17 FUNC    LOCAL  DEFAULT   12 __sys_netbsd_lchown
   169: 000000000008c0e0    17 FUNC    LOCAL  DEFAULT   12 _netbsd_lchown
   170: 000000000008c0e0    17 FUNC    LOCAL  DEFAULT   12 netbsd_lchown
  2040: 000000000008cf10    11 FUNC    GLOBAL DEFAULT   12 netbsd_lchown
  2041: 000000000008cf10    11 FUNC    GLOBAL DEFAULT   12 netbsd_msync
Jul 5 2018, 7:28 AM
brooks updated the diff for D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
  • Export under the correct versions.
  • Spell enosys consistantly.
Jul 5 2018, 7:27 AM

Jul 4 2018

brooks added a comment to D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..

I don't understand why there isn't an exported symbol. I've got a:

Jul 4 2018, 9:21 AM

Jun 29 2018

brooks added a comment to D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
$readelf -a ~/obj/home/bed22/git/freebsd/amd64.amd64/lib/libc/libc.so.7 | grep netbsd_lchown
   168: 000000000008c0e0    17 FUNC    LOCAL  DEFAULT   12 __sys_netbsd_lchown
   169: 000000000008c0e0    17 FUNC    LOCAL  DEFAULT   12 _netbsd_lchown
   170: 000000000008c0e0    17 FUNC    LOCAL  DEFAULT   12 netbsd_lchown
Jun 29 2018, 10:32 PM
brooks updated the diff for D15386: Improve portability of structs xinpcb and friends..
  • Fix a botched kptr_t change.
  • Make kvaddr_t unsigned to match the defintion in kvm.h and remove the
Jun 29 2018, 8:52 PM
brooks closed D11231: Correct link metadata created when installing with -DNO_ROOT..
Jun 29 2018, 4:08 PM
brooks committed rS335797: Correct link metadata created when installing with -DNO_ROOT..
Correct link metadata created when installing with -DNO_ROOT.
Jun 29 2018, 4:08 PM

Jun 28 2018

brooks updated the diff for D11231: Correct link metadata created when installing with -DNO_ROOT..
  • Rebase.
Jun 28 2018, 10:43 PM
brooks added a comment to D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
In D15814#338187, @kib wrote:
In D15814#337257, @kib wrote:

You can create symbols which are exported but not linkable, since they do not provide a default version. Such symbol can be only created by asm '@' syntax, it should be removed from the version map. Also I do not see a sense in leaving the private symbols around.

Is there an example of this?

https://reviews.freebsd.org/D12298

Jun 28 2018, 9:44 PM
brooks abandoned D15935: Fix a stack overflow in mount_smbfs when hostname is too long..

This is a duplicate of D15936.

Jun 28 2018, 9:36 PM
brooks committed rS335781: MFC r335641:.
MFC r335641:
Jun 28 2018, 9:23 PM
brooks committed rS335774: MFC r335641:.
MFC r335641:
Jun 28 2018, 8:33 PM

Jun 27 2018

brooks committed rP473455: Update to LLVM 6.0.1 release..
Update to LLVM 6.0.1 release.
Jun 27 2018, 8:18 PM
brooks added a comment to D16019: Split kern_break from sys_break and use it in linuxulator.

I wonder if we also want to restore ibcs2's int return value?

Would that be implementing a ibcs2-specific wrapper? I suspect it's not worth it.

Jun 27 2018, 4:03 PM

Jun 26 2018

brooks accepted D16019: Split kern_break from sys_break and use it in linuxulator.
Jun 26 2018, 10:46 PM
brooks added a comment to D16019: Split kern_break from sys_break and use it in linuxulator.

Looks good to me. I wonder if we also want to restore ibcs2's int return value?

Jun 26 2018, 10:46 PM
brooks added a comment to D15687: libssp is part of GCC, not an independent library..
Jun 26 2018, 3:13 PM
brooks accepted D15687: libssp is part of GCC, not an independent library..
Jun 26 2018, 3:00 PM
brooks added a comment to D15687: libssp is part of GCC, not an independent library..

That makes sense. If in fact nothing ever linked to it then we should just relegate it to the compat11 port and kill it along with gcc.

Jun 26 2018, 3:00 PM
brooks added a comment to D15687: libssp is part of GCC, not an independent library..

In terms of exposed symbols (see objdump -T), libssp definitely is a FORTIFY_SOURCE implementation. I've not looked at the code to avoid contamination in case we need a cleanroom one.

Jun 26 2018, 2:49 PM

Jun 25 2018

brooks committed rS335645: Normalize the g(eom,cache,part,...) build..
Normalize the g(eom,cache,part,...) build.
Jun 25 2018, 7:55 PM
brooks closed D15360: Normalize the g(eom,cache,part,...) build..
Jun 25 2018, 7:55 PM
brooks accepted D15953: Kernel environments: use any and all provided environments, evict hintmode and envmode.
Jun 25 2018, 6:54 PM
brooks added a comment to D15953: Kernel environments: use any and all provided environments, evict hintmode and envmode.

I don't see anything that's going to cause us obvious problems on BERI.

Jun 25 2018, 6:00 PM
brooks committed rS335641: Fix a stack overflow in mount_smbfs when hostname is too long..
Fix a stack overflow in mount_smbfs when hostname is too long.
Jun 25 2018, 4:43 PM
brooks closed D15936: Fix a stack overflow in mount_smbfs when hostname is too long..
Jun 25 2018, 4:43 PM

Jun 22 2018

brooks added a comment to D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
In D15814#337257, @kib wrote:

You can create symbols which are exported but not linkable, since they do not provide a default version. Such symbol can be only created by asm '@' syntax, it should be removed from the version map. Also I do not see a sense in leaving the private symbols around.

Jun 22 2018, 10:34 PM
brooks created D15971: elfdump: Add -E to test if a file is an ELF binary..
Jun 22 2018, 9:16 PM

Jun 20 2018

brooks added a comment to D15936: Fix a stack overflow in mount_smbfs when hostname is too long..

I'm not sure what the consequences of returning an error here are versus silently truncating. Before this change you'd have hostname "longerthan16chars.local" and it would get passed through as "longerthan16cha" but now mount_smbfs would fail with an error? If that assertion is true maybe it would be better just to copy and truncate at 16 than to return an error.

Jun 20 2018, 9:03 PM
brooks updated the diff for D15936: Fix a stack overflow in mount_smbfs when hostname is too long..
  • Per discussion in the PR, truncate the host name to 15 bytes.
Jun 20 2018, 8:59 PM
brooks created D15936: Fix a stack overflow in mount_smbfs when hostname is too long..
Jun 20 2018, 8:29 PM
brooks created D15935: Fix a stack overflow in mount_smbfs when hostname is too long..
Jun 20 2018, 8:25 PM
brooks updated the diff for D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
  • Add the version of the compat stubs I ment to add.
Jun 20 2018, 8:14 PM
brooks updated the diff for D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
  • Add compat symbols returning ENOSYS.
Jun 20 2018, 8:13 PM

Jun 18 2018

brooks committed rP472718: Update CHERI LLVM and QEMU to new snapshots..
Update CHERI LLVM and QEMU to new snapshots.
Jun 18 2018, 9:31 PM