Feed Advanced Search

Yesterday

brooks updated the diff for D15485: Avoid two suword() calls per auxarg entry..
  • Return error on copyout/suword failure in freebsd_fixup.
Mon, May 21, 8:50 PM
brooks added inline comments to D15485: Avoid two suword() calls per auxarg entry..
Mon, May 21, 4:10 PM

Fri, May 18

brooks added reviewers for D15485: Avoid two suword() calls per auxarg entry.: jhb, emaste, kib, imp.

This patch compiles (if you don't build linux emulation), but is incomplete. I've tested a variant on CheriBSD. In this review I'm looking for feedback on the approach before altering AUXARGS_ENTRY_32 and handling linux emulation. This is certainly more efficient and might be measurably so on i386 with 4/4.

Fri, May 18, 9:16 PM
brooks created D15485: Avoid two suword() calls per auxarg entry..
Fri, May 18, 9:12 PM
brooks created D15469: Remove a needlessly clever hack to start init with sys_exec()..
Fri, May 18, 12:09 AM

Thu, May 17

brooks added reviewers for D15468: Add helper functions to copy strings into struct image_args.: imp, emaste, jhb.

I've tested this on CheriBSD (mips64), amd64, and with i386 binaries on amd64 so it should be ready to go.

Thu, May 17, 11:09 PM
brooks closed D15467: Use strsep() to parse init_path in start_init()..
Thu, May 17, 11:08 PM
brooks committed rS333773: Use strsep() to parse init_path in start_init()..
Use strsep() to parse init_path in start_init().
Thu, May 17, 11:08 PM
brooks updated the diff for D15467: Use strsep() to parse init_path in start_init()..
  • Use strdup().
Thu, May 17, 10:38 PM
brooks added inline comments to D15467: Use strsep() to parse init_path in start_init()..
Thu, May 17, 10:33 PM
brooks added reviewers for D15467: Use strsep() to parse init_path in start_init().: imp, cperciva, ed, jhb.

Developed on CheriBSD (mips64), testing in an amd64 VM including verifying that single user mode works.

Thu, May 17, 9:15 PM
brooks created D15468: Add helper functions to copy strings into struct image_args..
Thu, May 17, 9:05 PM
brooks created D15467: Use strsep() to parse init_path in start_init()..
Thu, May 17, 8:13 PM

Wed, May 16

brooks accepted D15459: Use __SCCSID for SCCS IDs in libkvm sources..

LGTM. I'm not sure the blank line between FBSDID and SCCSID is useful, but don't care much one way or another.

Wed, May 16, 9:12 PM

Tue, May 15

brooks updated the diff for D15386: Improve portability of structs xinpcb and friends..
  • Bump __FreeBSD_version.
  • Add a note indicating the need for netstat/sockstat and the kernel to be
Tue, May 15, 10:02 PM
brooks updated the diff for D15386: Improve portability of structs xinpcb and friends..
  • Add an explict pad to struct xinpcb and add more padding while breaking the ABI.
  • Add padding to struct xfile.
Tue, May 15, 9:53 PM
brooks committed rS333644: Unwrap a line that no longer requires wrapping..
Unwrap a line that no longer requires wrapping.
Tue, May 15, 8:14 PM
brooks committed rS333643: Remove stray tabs from in_lltable_dump_entry()..
Remove stray tabs from in_lltable_dump_entry().
Tue, May 15, 8:13 PM
brooks committed rS333641: Unwrap some not-so-long lines now that extra tabs been removed..
Unwrap some not-so-long lines now that extra tabs been removed.
Tue, May 15, 6:00 PM
brooks committed rS333640: Remove stray tabs in in6_lltable_dump_entry(). NFC..
Remove stray tabs in in6_lltable_dump_entry(). NFC.
Tue, May 15, 5:57 PM
brooks committed rP470040: Merge r322325 from upstream. This allows devel/godot to build in a.
Merge r322325 from upstream. This allows devel/godot to build in a
Tue, May 15, 5:50 PM
brooks accepted D15442: Retire vxge(4).

LGTM

Tue, May 15, 4:29 PM
brooks committed rS333635: Allow freebsd32 __sysctl(2) to return ENOMEM..
Allow freebsd32 __sysctl(2) to return ENOMEM.
Tue, May 15, 4:25 PM
brooks closed D15438: Allow freebsd32 __sysctl(2) to return ENOMEM..
Tue, May 15, 4:25 PM
brooks updated the summary of D15386: Improve portability of structs xinpcb and friends..
Tue, May 15, 4:20 PM
brooks added a comment to D15386: Improve portability of structs xinpcb and friends..
In D15386#325723, @kib wrote:

And what is the scope of the ABI breakage ? I suspect that user programs like squid are affected.

Tue, May 15, 4:19 PM

Mon, May 14

brooks added reviewers for D15386: Improve portability of structs xinpcb and friends.: glebius, kib.

With this set of changes (plus D15438) i386 netstat and sockstat binaries work on amd64.

Mon, May 14, 11:43 PM
brooks created D15438: Allow freebsd32 __sysctl(2) to return ENOMEM..
Mon, May 14, 11:18 PM
brooks updated the diff for D15386: Improve portability of structs xinpcb and friends..
  • Make struct xfile platform independant.
  • Fix struct xinpgen size.
Mon, May 14, 10:17 PM

Thu, May 10

brooks created D15386: Improve portability of structs xinpcb and friends..
Thu, May 10, 11:49 PM

Wed, May 9

brooks accepted D15363: Add deprecation notice for vxge(4).

Even if we get pushback, we should plan to kill this in 13. We should also break it on i386 in 12 since with 4/4 the management interface writes to kernel memory when it thinks it is writing to userspace.

Wed, May 9, 4:34 PM
brooks updated the diff for D15360: Normalize the g(eom,cache,part,...) build..
  • Create WORLDTMP/lib/geom
  • Use SUBDIR_DEPENDS_geom to depend on libufs.
Wed, May 9, 3:13 PM
brooks added inline comments to D15360: Normalize the g(eom,cache,part,...) build..
Wed, May 9, 3:13 PM

Tue, May 8

brooks updated the diff for D15360: Normalize the g(eom,cache,part,...) build..
  • Chase the relocation of library directories.
Tue, May 8, 10:58 PM
brooks created D15360: Normalize the g(eom,cache,part,...) build..
Tue, May 8, 10:33 PM
brooks committed rP469417: Switch to using clang 6.0 for FreeBSD 10..
Switch to using clang 6.0 for FreeBSD 10.
Tue, May 8, 9:29 PM
brooks committed rP469381: Remove llvm39 as it no longer has any dependencies..
Remove llvm39 as it no longer has any dependencies.
Tue, May 8, 4:34 PM

Mon, May 7

brooks added a comment to D15238: Drop FreeBSD 10.3 support.

It's worth noting that 10.3 is not listed on the supported releases page so e-mail or no e-mail it's not supported.

Mon, May 7, 5:26 PM
brooks accepted D15341: Updated rtld to use libc_nossp_pic.a.

LGTM

Mon, May 7, 5:25 PM
brooks accepted D15340: Removed -fstack-protector-all restriction from libc.
Mon, May 7, 5:25 PM
brooks added a comment to D15340: Removed -fstack-protector-all restriction from libc.

LGTM.

Mon, May 7, 5:24 PM
brooks accepted D15283: Created static pic libc with no SSP to be used by rtld.

LGTM.

Mon, May 7, 5:14 PM

Sun, May 6

brooks committed rP469241: Update to a new snapshot..
Update to a new snapshot.
Sun, May 6, 4:44 PM
brooks committed rP469235: Work around a race in sphinx..
Work around a race in sphinx.
Sun, May 6, 4:00 PM
brooks committed rP469232: Deprecate FreeMAT..
Deprecate FreeMAT.
Sun, May 6, 3:49 PM
brooks committed rP469229: Remove this obsolete port of Temporally Enhanced Security Logic.
Remove this obsolete port of Temporally Enhanced Security Logic
Sun, May 6, 3:36 PM

Fri, May 4

brooks accepted D15292: Followup to r333210, retire nxge(4).

LGTM.

Fri, May 4, 3:56 PM

Thu, May 3

brooks committed rP468997: Update to LLVM 5.0.2..
Update to LLVM 5.0.2.
Thu, May 3, 11:34 PM
brooks accepted D15283: Created static pic libc with no SSP to be used by rtld.

This seems fine though I'm not super excited about compiling all of libc yet another time.

Thu, May 3, 11:30 PM
brooks committed rS333226: MFC r332997:.
MFC r332997:
Thu, May 3, 8:06 PM
brooks accepted D15277: Add deprecation notice for nxge(4).

Sounds good to me. I believe this one doesn't come in a PCIe variant so quite unlikely it's in production.

Thu, May 3, 2:31 PM

Tue, May 1

brooks accepted D15238: Drop FreeBSD 10.3 support.

Fine for the LLVM ports.

Tue, May 1, 10:58 PM

Mon, Apr 30

brooks accepted D15234: Remove support for ixgb(4).

I'm fine with this in concept. There should first be a commit adding deprecation notices to the attach routine and manpage.

Mon, Apr 30, 9:40 PM

Wed, Apr 25

brooks committed rS332997: Translate 32-bit ifmedia requests into native ones..
Translate 32-bit ifmedia requests into native ones.
Wed, Apr 25, 3:31 PM
brooks closed D14996: Translate 32-bit ifmedia requests into native ones..
Wed, Apr 25, 3:31 PM

Tue, Apr 24

brooks accepted D15182: Add deprecation notice for lmc(4).

Looks good to me.

Tue, Apr 24, 3:50 PM

Mon, Apr 23

brooks committed rS332895: Finish removing FDDI and tokenring media support..
Finish removing FDDI and tokenring media support.
Mon, Apr 23, 9:10 PM
brooks closed D15170: Finish removing FDDI and tokenring media support..
Mon, Apr 23, 9:10 PM
brooks added reviewers for D15170: Finish removing FDDI and tokenring media support.: emaste, kib.
Mon, Apr 23, 6:48 PM
brooks updated the summary of D15170: Finish removing FDDI and tokenring media support..
Mon, Apr 23, 6:35 PM
brooks updated the summary of D15170: Finish removing FDDI and tokenring media support..
Mon, Apr 23, 6:33 PM
brooks created D15170: Finish removing FDDI and tokenring media support..
Mon, Apr 23, 3:34 PM

Apr 20 2018

brooks committed rP467849: Merge r332833 from FreeBSD HEAD..
Merge r332833 from FreeBSD HEAD.
Apr 20 2018, 10:46 PM

Apr 19 2018

brooks added a comment to D14996: Translate 32-bit ifmedia requests into native ones..

I've retested the revised version of this change and it's working fine.

Apr 19 2018, 10:40 PM
brooks committed rS332796: Add sortbench..
Add sortbench.
Apr 19 2018, 9:54 PM
brooks closed D12677: Add sortbench..
Apr 19 2018, 9:54 PM
brooks committed rS332792: Replace SOFTFLOAT with __riscv_float_abi_*..
Replace SOFTFLOAT with __riscv_float_abi_*.
Apr 19 2018, 8:36 PM
brooks closed D10039: Replace SOFTFLOAT with __riscv_float_abi_*..
Apr 19 2018, 8:36 PM
brooks committed rP467792: Update to a new snapshot with support for new instructions..
Update to a new snapshot with support for new instructions.
Apr 19 2018, 5:43 PM
brooks committed rP467789: Remove a needless include of vm/pmap.h which broke the i386 build with.
Remove a needless include of vm/pmap.h which broke the i386 build with
Apr 19 2018, 5:02 PM
brooks committed rP467786: Remove a needless include of vm/pmap.h which broke the i386 build with.
Remove a needless include of vm/pmap.h which broke the i386 build with
Apr 19 2018, 4:54 PM

Apr 18 2018

brooks updated the diff for D10039: Replace SOFTFLOAT with __riscv_float_abi_*..
  • Rebase.
  • Remove another instance of SOFTFLOAT.
Apr 18 2018, 9:14 PM
brooks committed rP467737: Remove a needless include of vm/pmap.h which broke the i386 build with.
Remove a needless include of vm/pmap.h which broke the i386 build with
Apr 18 2018, 9:06 PM

Apr 17 2018

brooks committed rS332660: Remove references to fs_nofault_intr_begin/end..
Remove references to fs_nofault_intr_begin/end.
Apr 17 2018, 10:30 PM
brooks updated the diff for D14996: Translate 32-bit ifmedia requests into native ones..
  • Fix !COMPAT_FREEBSD32 builds post rebase.
Apr 17 2018, 9:36 PM
brooks added a comment to D10039: Replace SOFTFLOAT with __riscv_float_abi_*..

@br is this change sensible or should I abandon it?

Apr 17 2018, 8:41 PM
brooks updated the diff for D14996: Translate 32-bit ifmedia requests into native ones..
  • Rebase.
Apr 17 2018, 6:47 PM
brooks committed rS332656: Remove the unused fuwintr() and suiwintr() functions..
Remove the unused fuwintr() and suiwintr() functions.
Apr 17 2018, 6:04 PM
brooks closed D15102: Remove the unused fuwintr() and suiwintr() functions..
Apr 17 2018, 6:04 PM
brooks updated the summary of D15102: Remove the unused fuwintr() and suiwintr() functions..
Apr 17 2018, 6:03 PM
brooks committed rS332654: Remove unused implementations of copyoutstr()..
Remove unused implementations of copyoutstr().
Apr 17 2018, 5:20 PM
brooks closed D15108: Remove unused implementations of copyoutstr..
Apr 17 2018, 5:20 PM
brooks retitled D15108: Remove unused implementations of copyoutstr. from Remove the two implementations of copyoutstr. to Remove unused implementations of copyoutstr..
Apr 17 2018, 4:38 PM
brooks committed rS332650: Stop using fuswintr() and suswintr() in the profiler..
Stop using fuswintr() and suswintr() in the profiler.
Apr 17 2018, 4:37 PM
brooks closed D15101: Stop using fuswintr() and suswintr() in the profiler..
Apr 17 2018, 4:37 PM
brooks retitled D15101: Stop using fuswintr() and suswintr() in the profiler. from Stop using fuswintr() and suswintr(). to Stop using fuswintr() and suswintr() in the profiler..
Apr 17 2018, 4:09 PM
brooks updated the diff for D15102: Remove the unused fuwintr() and suiwintr() functions..
  • Add MLINKS to OLD_FILES.
Apr 17 2018, 3:39 PM

Apr 16 2018

brooks added a comment to D15108: Remove unused implementations of copyoutstr..

Did we come by that as a NetBSDism? Looks good to me.

Apr 16 2018, 10:18 PM
brooks created D15108: Remove unused implementations of copyoutstr..
Apr 16 2018, 10:04 PM
brooks updated the diff for D15101: Stop using fuswintr() and suswintr() in the profiler..
  • Don't compute things that aren't used in addupc_intr().
  • Update commment on addupc_task().
Apr 16 2018, 9:39 PM
brooks committed rP467533: Update to a new snapshot..
Update to a new snapshot.
Apr 16 2018, 8:57 PM
brooks committed rS332630: Remove support for FDDI and token ring media types in userland utilities..
Remove support for FDDI and token ring media types in userland utilities.
Apr 16 2018, 6:08 PM
brooks closed D15077: Remove support for FDDI and token ring media types in userland utilities..
Apr 16 2018, 6:08 PM
brooks created D15102: Remove the unused fuwintr() and suiwintr() functions..
Apr 16 2018, 5:56 PM
brooks created D15101: Stop using fuswintr() and suswintr() in the profiler..
Apr 16 2018, 5:53 PM
brooks committed rS332629: Remove unused badaddr() function..
Remove unused badaddr() function.
Apr 16 2018, 5:43 PM
brooks closed D15078: Remove unused badaddr() function..
Apr 16 2018, 5:43 PM

Apr 15 2018

brooks created D15078: Remove unused badaddr() function..
Apr 15 2018, 5:21 PM
brooks created D15077: Remove support for FDDI and token ring media types in userland utilities..
Apr 15 2018, 5:16 PM
brooks committed rS332490: Remove support for the Arcnet protocol..
Remove support for the Arcnet protocol.
Apr 15 2018, 3:47 PM