Page MenuHomeFreeBSD
Differential D56407

syscalls: Preserve the attributes of the args
ClosedPublic
Actions

Authored by imp on Wed, Apr 15, 2:16 PM.
Tags
None
Referenced Files
F153203018: D56407.diff
Sun, Apr 19, 7:02 PM
Unknown Object (File)
Sun, Apr 19, 1:26 AM
Unknown Object (File)
Sat, Apr 18, 5:37 AM
Unknown Object (File)
Sat, Apr 18, 5:21 AM
Unknown Object (File)
Sat, Apr 18, 4:38 AM
Unknown Object (File)
Fri, Apr 17, 7:34 PM
Unknown Object (File)
Fri, Apr 17, 4:13 AM
Unknown Object (File)
Fri, Apr 17, 3:08 AM
View All 10 Files
Subscribers
None

Details

Reviewers
brooks
jrtc27
kevans
Commits
rG2a1745da389b: syscalls: Preserve the attributes of the args
Summary

Lightly parse and preserve the attributes of the args as attributes.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Wed, Apr 15, 2:16 PM
imp created this revision.
Harbormaster completed remote builds in B72222: Diff 175567.Wed, Apr 15, 2:17 PM
imp added a child revision: D56408: syscall: Create a script to export the data as json.Wed, Apr 15, 2:17 PM
imp added a reviewer: kevans.Wed, Apr 15, 2:21 PM
brooks accepted this revision.Thu, Apr 16, 8:15 AM
brooks added inline comments.
sys/tools/syscalls/core/scarg.lua
145

Will these arguments be growing annotations? It's hard for me to imagine when you'd need one.

150

The consumer handles nil so does this need to be set at all?

This revision is now accepted and ready to land.Thu, Apr 16, 8:15 AM
Closed by commit rG2a1745da389b: syscalls: Preserve the attributes of the args (authored by imp). · Explain WhyFri, Apr 17, 4:46 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG2a1745da389b: syscalls: Preserve the attributes of the args.
imp added inline comments.Fri, Apr 17, 10:33 PM
sys/tools/syscalls/core/scarg.lua
145

Hmmm, maybe not. I should just drop these two until there's a proven usecase.

150

Ah good point.
I was being parnaoid, but I can remove this.

Revision Contents
Changeset List

PathSize
sys/
tools/
syscalls/
core/
19 lines

Diff 175735

View Options

sys/tools/syscalls/core/scarg.lua

Loading...