Page MenuHomeFreeBSD

syscalls: Preserve the attributes of the args
ClosedPublic

Authored by imp on Wed, Apr 15, 2:16 PM.
Tags
None
Referenced Files
F153203018: D56407.diff
Sun, Apr 19, 7:02 PM
Unknown Object (File)
Sun, Apr 19, 1:26 AM
Unknown Object (File)
Sat, Apr 18, 5:37 AM
Unknown Object (File)
Sat, Apr 18, 5:21 AM
Unknown Object (File)
Sat, Apr 18, 4:38 AM
Unknown Object (File)
Fri, Apr 17, 7:34 PM
Unknown Object (File)
Fri, Apr 17, 4:13 AM
Unknown Object (File)
Fri, Apr 17, 3:08 AM
Subscribers
None

Details

Summary

Lightly parse and preserve the attributes of the args as attributes.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Wed, Apr 15, 2:16 PM
imp created this revision.
brooks added inline comments.
sys/tools/syscalls/core/scarg.lua
145

Will these arguments be growing annotations? It's hard for me to imagine when you'd need one.

150

The consumer handles nil so does this need to be set at all?

This revision is now accepted and ready to land.Thu, Apr 16, 8:15 AM
This revision was automatically updated to reflect the committed changes.
sys/tools/syscalls/core/scarg.lua
145

Hmmm, maybe not. I should just drop these two until there's a proven usecase.

150

Ah good point.
I was being parnaoid, but I can remove this.