Page MenuHomeFreeBSD
Differential D56408

syscall: Create a script to export the data as json
ClosedPublic
Actions

Authored by imp on Wed, Apr 15, 2:17 PM.
Tags
None
Referenced Files
F156484926: D56408.id175569.diff
Thu, May 14, 12:30 AM
F156483741: D56408.id175568.diff
Thu, May 14, 12:08 AM
F156479288: D56408.id175568.diff
Wed, May 13, 11:05 PM
F156479201: D56408.id175568.diff
Wed, May 13, 11:04 PM
F156433709: D56408.id175736.diff
Wed, May 13, 4:38 PM
Unknown Object (File)
Mon, May 11, 2:31 PM
Unknown Object (File)
Mon, May 11, 5:21 AM
Unknown Object (File)
Sat, May 9, 8:37 PM
View All 28 Files
Subscribers
None

Details

Reviewers
brooks
jrtc27
kevans
Commits
rGb3b23f284a67: syscall: Create a script to export the data as json
Summary

Create a script to export the parsed data as json. Include the
annotations for the system call arguments, since they are helpful to
downstream uses.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Wed, Apr 15, 2:17 PM
imp created this revision.
Harbormaster completed remote builds in B72223: Diff 175568.Wed, Apr 15, 2:17 PM
imp added a parent revision: D56407: syscalls: Preserve the attributes of the args.Wed, Apr 15, 2:17 PM
imp updated this revision to Diff 175569.Wed, Apr 15, 2:19 PM

on second thought, simplify a bit: always write to stdout.

Harbormaster completed remote builds in B72224: Diff 175569.Wed, Apr 15, 2:19 PM
imp added a reviewer: kevans.Wed, Apr 15, 2:21 PM
brooks accepted this revision.Thu, Apr 16, 8:18 AM
brooks added inline comments.
sys/tools/syscalls/scripts/syscall_json.lua
9

Does it actually make sense of this to be a module? I guess it's harmless.

97–98

I find it a little odd to be providing both of these things in one file, but I don't have a feel for what makes "good" use of JSON.

This revision is now accepted and ready to land.Thu, Apr 16, 8:18 AM
Closed by commit rGb3b23f284a67: syscall: Create a script to export the data as json (authored by imp). · Explain WhyFri, Apr 17, 4:46 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGb3b23f284a67: syscall: Create a script to export the data as json.
imp added inline comments.Fri, Apr 17, 10:28 PM
sys/tools/syscalls/scripts/syscall_json.lua
9

Oh, likely no.

97–98

I find it a little odd to be providing both of these things in one file, but I don't have a feel for what makes "good" use of JSON.

I'm unsure as well, but I'll see if I wind up needing it. after noticing this after the commit (I missed it before somehow) I got to thinking about it and maybe it's not needed. It can be inferred by looking at all the other syscalls. It only saves about 50 lines in the output.

Revision Contents
Changeset List

PathSize
sys/
tools/
syscalls/
scripts/
126 lines

Diff 175736

View Options

sys/tools/syscalls/scripts/syscall_json.lua

Loading...