bsd.suffixes-extra.mk: rewrap long lines
ClosedPublic
Actions

Authored by brooks on May 22 2025, 3:02 PM.

Details

Reviewers

dg612_cam.ac.uk
jrtc27
jhb
dim

Commits

rG83812c4eccb3: bsd.suffixes-extra.mk: rewrap long lines

Summary

Group CFLAGS variables together either on one line or all separate
depending on length.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.May 22 2025, 3:02 PM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptMay 22 2025, 3:02 PM

brooks requested review of this revision.May 22 2025, 3:02 PM

Harbormaster completed remote builds in B64352: Diff 155865.May 22 2025, 3:02 PM

brooks added a child revision: D50464: share/mk: add {PICO,PIEO,NOSSPPICO}_CFLAGS for C and assembly.May 22 2025, 3:02 PM

Maybe a silly question, but when make unwraps these command lines and then prints them for the user, will the output become longer due extra spaces? Could be bad for my OCD... :)

In D50463#1151819, @dim wrote:

Maybe a silly question, but when make unwraps these command lines and then prints them for the user, will the output become longer due extra spaces? Could be bad for my OCD... :)

I think the number of bytes output remains the same, but the tabs are visible. Note that most commands were already split.

jhb accepted this revision.May 23 2025, 5:38 PM

This revision is now accepted and ready to land.May 23 2025, 5:38 PM

Closed by commit rG83812c4eccb3: bsd.suffixes-extra.mk: rewrap long lines (authored by brooks). · Explain WhyMay 23 2025, 11:48 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG83812c4eccb3: bsd.suffixes-extra.mk: rewrap long lines.