Page MenuHomeFreeBSD

rtld: get syscall implementations from libsys
ClosedPublic

Authored by brooks on May 22 2025, 7:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 1:16 AM
Unknown Object (File)
Fri, Oct 3, 2:09 PM
Unknown Object (File)
Sun, Sep 28, 4:25 PM
Unknown Object (File)
Sat, Sep 27, 5:19 PM
Unknown Object (File)
Fri, Sep 19, 9:55 AM
Unknown Object (File)
Sep 15 2025, 1:55 AM
Unknown Object (File)
Sep 2 2025, 11:33 PM
Unknown Object (File)
Aug 29 2025, 6:03 PM
Subscribers

Details

Summary

When I added libsys I failed to switch rtld's reuse of object files
from libc to to use ones from libsys instead. This would have turned up
as a broken system in d7847a8d35143, but SHARED_CFLAGS is not being
applied to assembly files.

PR: 286975

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

libexec/rtld-elf/rtld-libc/Makefile.inc
95

Duplicated by the later line

99
101

This is never empty? (And were it to be, rtld_libc.a probably shouldn't depend on LIBC_NOSSP_PIC unconditionally)

brooks added inline comments.
libexec/rtld-elf/rtld-libc/Makefile.inc
101

Oops, that's a leftover from my initial (broken) implementation where some archs didn't have any libc entries.

This revision is now accepted and ready to land.May 22 2025, 9:22 PM
This revision was automatically updated to reflect the committed changes.
brooks marked an inline comment as done.