Paths

Table of Contentst

Differential D50466

share/mk: pass SHARED_CFLAGS to PIC and PIE from assembly
ClosedPublic
Actions

Authored by brooks on May 22 2025, 3:02 PM.

Tags

None

Referenced Files

	F168331247: D50466.id155897.diff
	Thu, Aug 27, 3:59 PM

	F168329134: D50466.id155959.diff
	Thu, Aug 27, 3:47 PM

	F168329083: D50466.id155868.diff
	Thu, Aug 27, 3:47 PM

	F168323148: D50466.diff
	Thu, Aug 27, 3:12 PM

	Unknown Object (File)
	Thu, Aug 13, 2:34 PM

	Unknown Object (File)
	Wed, Aug 12, 7:17 PM

	Unknown Object (File)
	Wed, Aug 12, 7:16 PM

	Unknown Object (File)
	Wed, Aug 12, 5:15 PM

Subscribers

Details

Reviewers

dg612_cam.ac.uk
jrtc27
jhb
dim
emaste

Commits

rG9c2001036185: share/mk: pass SHARED_CFLAGS to PIC and PIE from assembly

Summary

This mirrors what we do for C code.

PR: 286975

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.May 22 2025, 3:02 PM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptMay 22 2025, 3:02 PM

brooks requested review of this revision.May 22 2025, 3:02 PM

Harbormaster completed remote builds in B64355: Diff 155868.May 22 2025, 3:03 PM

brooks added a parent revision: D50465: libsys: Use PICO_CFLAGS to disable syscall stubs.May 22 2025, 3:03 PM

I wish we had these documented somewhere, so we could include a note that ${SHARED_CFLAGS} (along with ${CFLAGS} and ${PIEO_CFLAGS}/${PICO_CFLAGS} etc.).

I see three SHARED_CFLAGS references: in lib/libc/sys/Makefile.inc (noted in the PR), share/mk/bsd.sanitizer.mk, and lib/libarchive/Makefile.inc. I'm not sure why libarchive's addition of ICONV-related flags are in SHARED_CFLAGS not CFLAGS.

brooks added a parent revision: D50475: rtld: get syscall implementations from libsys.May 22 2025, 7:05 PM

Drop PICO_CFLAGS, and friends
Document SHARED_CFLAGS

Harbormaster completed remote builds in B64369: Diff 155897.May 22 2025, 10:33 PM

brooks added a parent revision: D50481: share/mk/bsd.README: refer to the linker, not the loader.May 22 2025, 10:35 PM

emaste accepted this revision.May 22 2025, 11:28 PM

This revision is now accepted and ready to land.May 22 2025, 11:28 PM

jhb accepted this revision.May 23 2025, 5:39 PM

Closed by commit rG9c2001036185: share/mk: pass SHARED_CFLAGS to PIC and PIE from assembly (authored by brooks). · Explain WhyMay 23 2025, 11:49 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG9c2001036185: share/mk: pass SHARED_CFLAGS to PIC and PIE from assembly.

Revision Contents
Changeset List

Path

Size

share/

mk/

3 lines

bsd.suffixes-extra.mk

10 lines

Diff 155959

share/mk/bsd.README

Loading...

share/mk/bsd.suffixes-extra.mk

Loading...