Paths

Table of Contentst

Differential D50480

share/mk: improve CFLAGS description
Needs ReviewPublic
Actions

Authored by brooks on May 22 2025, 10:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 12, 2:18 AM

	Unknown Object (File)
	Thu, Nov 6, 8:54 PM

	Unknown Object (File)
	Thu, Nov 6, 1:53 PM

	Unknown Object (File)
	Wed, Nov 5, 3:37 AM

	Unknown Object (File)
	Wed, Nov 5, 3:32 AM

	Unknown Object (File)
	Wed, Nov 5, 3:32 AM

	Unknown Object (File)
	Wed, Nov 5, 3:30 AM

	Unknown Object (File)
	Fri, Oct 31, 4:00 PM

View All 63 Files

Subscribers

Details

Reviewers

emaste
jhb

Summary

Also document CXXFLAGS.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 64397
Build 61281: arc lint + arc unit

Event Timeline

brooks created this revision.May 22 2025, 10:34 PM

Herald added subscribers: imp, bdrewery. · View Herald TranscriptMay 22 2025, 10:34 PM

brooks requested review of this revision.May 22 2025, 10:34 PM

Harbormaster completed remote builds in B64371: Diff 155899.May 22 2025, 10:34 PM

brooks added a parent revision: D50479: share/mk: make *ADD and *FLAGS descriptions common.May 22 2025, 10:34 PM

brooks added a child revision: D50481: share/mk/bsd.README: refer to the linker, not the loader.

emaste added inline comments.May 22 2025, 11:26 PM

share/mk/bsd.README
136–139	Should we (in an ideal world, absent legacy and backwards compatibility considerations) really have `CPPFLAGS` and reserve `CFLAGS` specifically for C?

brooks added inline comments.May 22 2025, 11:40 PM

share/mk/bsd.README
136–139	Certainly something C specific would be good, but we also need something to pass all the common flags. We've got a lot of ABI stuff in CFLAGS via bsd.cpu.mk. Likewise we add -target and --sysroot to XCFLAGS so they end up in CFLAGS.

jhb added inline comments.May 23 2025, 5:34 PM

share/mk/bsd.README
136–139	Maybe either "things that are run though the C preprocessor" or "Flags to the compiler when compiling most things processed by the C preprocessor."?
152–153	This seems more consistent with the wording used for AFLAGS and CFLAGS?

Rephrased with some help from @jhb

Harbormaster completed remote builds in B64396: Diff 155950.May 23 2025, 10:59 PM

Spell version correctly

Harbormaster completed remote builds in B64397: Diff 155951.May 23 2025, 11:01 PM

brooks marked 3 inline comments as done.May 23 2025, 11:11 PM

Revision Contents
Changeset List

Path

Size

share/

mk/

8 lines

Diff 155951

share/mk/bsd.README

Loading...