rtld: get syscall implementations from libsys
ClosedPublic
Actions

Authored by brooks on May 22 2025, 7:04 PM.

Details

Reviewers

dg612_cam.ac.uk
jrtc27
jhb
dim

Commits

rG387783da979e: rtld: get syscall implementations from libsys

Summary

When I added libsys I failed to switch rtld's reuse of object files
from libc to to use ones from libsys instead. This would have turned up
as a broken system in d7847a8d35143, but SHARED_CFLAGS is not being
applied to assembly files.

PR: 286975

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.May 22 2025, 7:04 PM

Herald added subscribers: bdragon, imp. · View Herald TranscriptMay 22 2025, 7:04 PM

brooks requested review of this revision.May 22 2025, 7:04 PM

Harbormaster completed remote builds in B64363: Diff 155890.May 22 2025, 7:04 PM

brooks added a parent revision: D50474: src.libnames.mk: add LIBSYS_PIC.May 22 2025, 7:04 PM

brooks mentioned this in D50465: libsys: Use PICO_CFLAGS to disable syscall stubs.May 22 2025, 7:05 PM

brooks added a child revision: D50466: share/mk: pass SHARED_CFLAGS to PIC and PIE from assembly.

jrtc27 added inline comments.May 22 2025, 7:09 PM

libexec/rtld-elf/rtld-libc/Makefile.inc
95	Duplicated by the later line
99
101	This is never empty? (And were it to be, rtld_libc.a probably shouldn't depend on LIBC_NOSSP_PIC unconditionally)

Address feedback from @jrtc27

Harbormaster completed remote builds in B64365: Diff 155892.May 22 2025, 7:25 PM

brooks marked 3 inline comments as done.May 22 2025, 7:26 PM

brooks added inline comments.

libexec/rtld-elf/rtld-libc/Makefile.inc
101	Oops, that's a leftover from my initial (broken) implementation where some archs didn't have any libc entries.

jrtc27 accepted this revision.May 22 2025, 9:22 PM

This revision is now accepted and ready to land.May 22 2025, 9:22 PM

brooks mentioned this in D50464: share/mk: add {PICO,PIEO,NOSSPPICO}_CFLAGS for C and assembly.May 22 2025, 10:32 PM

jhb accepted this revision.May 23 2025, 5:37 PM

Closed by commit rG387783da979e: rtld: get syscall implementations from libsys (authored by brooks). · Explain WhyMay 23 2025, 11:48 PM

This revision was automatically updated to reflect the committed changes.

brooks marked an inline comment as done.

brooks added a commit: rG387783da979e: rtld: get syscall implementations from libsys.

Revision Contents
Changeset List

Path

Size

libexec/

rtld-elf/

rtld-libc/

Makefile.inc

30 lines

Diff 155957

View Options

libexec/rtld-elf/rtld-libc/Makefile.inc

rtld: get syscall implementations from libsysClosedPublicActions