Paths

Table of Contentst

Use .pieo extension for WITH_PIE bsd.prog.mk output
AbandonedPublic
Actions

Authored by dim on Apr 22 2025, 5:33 PM.

Details

Reviewers

brooks
emaste
imp
jhb
jrtc27
olce
andrew
manu

Summary

When object files for programs are built using bsd.prog.mk, and WITH_PIE
is enabled, the extension used is still plain ".o". To be consistent
with bsd.lib.mk, and to allow changes in WITH_PIE settings to propagate
correctly, the extension should be ".pieo" instead.

To avoid duplicating the .SUFFIXES list and suffix-transformation rules
from bsd.lib.mk, move these to bsd.suffixes-extra.mk so they can be
included from both bsd.lib.mk and bsd.prog.mk. (Note that we cannot add
them to bsd.suffixes.mk, since that file also gets included by sys.mk,
which applies to non-source builds. That would require a whole ports
exp-run.)

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 63643
Build 60527: arc lint + arc unit

Event Timeline

dim created this revision.Apr 22 2025, 5:33 PM

Herald added a subscriber: bdrewery. · View Herald TranscriptApr 22 2025, 5:33 PM

Harbormaster completed remote builds in B63636: Diff 154105.Apr 22 2025, 5:33 PM

dim requested review of this revision.Apr 22 2025, 5:33 PM

Note this requires D49951 to be committed first, since otherwise tests/sys/fs/fusefs falls over due to it picking sbin/mount.c over tests/sys/fs/fusefs/mount..cc for targeting mount.pieo. This has to do with some internal ordering in make that I haven't been able to fully figure out.

Are you up for splitting bsd.suffixes-extra.mk out first, without any functional changes?

In D49962#1139420, @emaste wrote:

Are you up for splitting bsd.suffixes-extra.mk out first, without any functional changes?

Sure, that should be a very safe NFC operation. :)

dim mentioned this in D49965: Move extra suffix-transformation rules into bsd.suffixes-extra.mk.Apr 22 2025, 6:31 PM

Split off the bsd.suffixes-extra.mk part to D49965.

Herald added a reviewer: andrew. · View Herald TranscriptApr 22 2025, 6:35 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: riscv, ziaee, vegeta_tuxpowered.net and 3 others. · View Herald Transcript

Harbormaster completed remote builds in B63643: Diff 154114.Apr 22 2025, 6:35 PM

Abandoning, arc diff totally messed this up.

guest-patmaddox added a subscriber: guest-patmaddox.Apr 23 2025, 3:18 AM

Revision Contents
Changeset List

Path

Size

include/

fts.h

29 lines

lib/

libc/

gen/

4 lines

1 line

6 lines

58 lines

172 lines

2 lines

include/

libc_private.h

1 line

tests/

gen/

Makefile

9 lines

fts_blocks_test.c

63 lines

stdlib/

Makefile

4 lines

share/

mk/

1 line

1 line

74 lines

15 lines

2 lines

bsd.suffixes-extra.mk

76 lines

vt/

keymaps/

INDEX.keymaps

7 lines

us.intl.acc.kbd

sys/

arm64/

machdep.c

21 lines

pmap.c

85 lines

include/

pmap.h

3 lines

conf/

files.riscv

1 line

contrib/

edk2/

Include/

Library/

BaseLib.h

23 lines

Uefi/

UefiBaseType.h

14 lines

UefiSpec.h

5 lines

dev/

xilinx/

axidma.c

9 lines

kern/

uipc_ktls.c

14 lines

uipc_socket.c

42 lines

netinet6/

icmp6.c

6 lines

ip6_forward.c

3 lines

riscv/

include/

cbo.h

33 lines

cpu.h

1 line

riscv/

cbo.c

104 lines

identcpu.c

57 lines

tools/

git/

ghpr/

ghpr-init.sh

8 lines

ghpr-push.sh

1 line

Commit	Tree	Parents	Author	Summary	Date
23b5cca13fa8	f20033be1f13	60b5d6e4b453	Dimitry Andric	Use .pieo extension for WITH_PIE bsd.prog.mk output (Show More…)	Apr 21 2025, 7:52 PM
60b5d6e4b453	97b92b874ab8	95f4e7f5e283	Dimitry Andric	Move extra suffix-transformation rules into bsd.suffixes-extra.mk (Show More…)	Apr 22 2025, 6:26 PM
95f4e7f5e283	40887f8eb950	a1a06bc68661	yu shan wei	LoongArch: sys/contrib/edk2: add support (Show More…)	Mar 30 2025, 11:55 PM
a1a06bc68661	5cb1c84f340f	2cdf33392648	Warner Losh	ghpr: Make init a little more robust (Show More…)	Apr 22 2025, 4:25 PM
2cdf33392648	74a7e2c1c9f1	d8e841a9aa1f	Warner Losh	ghpr: Add gh pr close (Show More…)	Apr 22 2025, 4:18 PM
d8e841a9aa1f	8e55860fb9e4	12668eadcb82	SHENGYI HONG	libc: treat execvpe as a week symbol (Show More…)	Apr 2 2025, 8:35 PM
12668eadcb82	bce303164253	f0ac5e919f3f	Dag-Erling Smørgrav	bsd.compiler.mk: Add a blocks compiler feature. (Show More…)	Apr 22 2025, 5:44 PM
f0ac5e919f3f	d1ff0ddbb298	ccaf78c962e8	Dag-Erling Smørgrav	fts: Add blocks support. (Show More…)	Apr 22 2025, 5:16 PM
ccaf78c962e8	e49087222529	32bb6a6925c0	Andrew Turner	arm64: Move cpu0 dpcpu and msgbuf to the DMAP (Show More…)	Apr 22 2025, 3:59 PM
32bb6a6925c0	66e05996e5ab	a049678039e4	Andrew Turner	arm64: Call pmap_bootstrap_dmap from initarm (Show More…)	Apr 22 2025, 3:57 PM
a049678039e4	b135768c6365	12367f1429f1	Quentin Thébault	vt: add US International keymap (Show More…)	Feb 20 2025, 4:38 AM
12367f1429f1	30e223ae432a	b7a61e09e4ad	Meng Zhuo	riscv: add Sifive p550/p650 identification (Show More…)	Apr 22 2025, 6:35 AM
b7a61e09e4ad	b13e03179774	1000cc4a0d39	Mark Johnston	netinet6: Do not forward or send ICMPv6 messages to the unspec address (Show More…)	Apr 22 2025, 2:54 PM
1000cc4a0d39	aabe8af3b7f8	a1a067b7131e	Mark Johnston	so_splice: Disallow splicing with KTLS-enabled sockets (Show More…)	Apr 22 2025, 2:53 PM
a1a067b7131e	8e0b9b1c7e16	81e2d24bc6ea	Ruslan Bukin	axidma(4): add local data cache flushes. (Show More…)	Apr 22 2025, 9:28 AM
81e2d24bc6ea	b1ed3edfeebc	ff45e4759a38	Ruslan Bukin	riscv: support for Cache-Block Operations (CBO). (Show More…)	Apr 22 2025, 8:14 AM