Use .pieo extension for WITH_PIE bsd.prog.mk output
ClosedPublic
Actions

Authored by dim on Apr 22 2025, 6:40 PM.

Details

Reviewers

brooks
emaste
imp
jhb
jrtc27
olce

Commits

rG979864eef41b: Use .pieo extension for WITH_PIE bsd.prog.mk output
rG4939a4a9cd14: Use .pieo extension for WITH_PIE bsd.prog.mk output
rG245bb0110639: Use .pieo extension for WITH_PIE bsd.prog.mk output

Summary

When object files for programs are built using bsd.prog.mk, and WITH_PIE
is enabled, the extension used is still plain ".o". To be consistent
with bsd.lib.mk, and to allow changes in WITH_PIE settings to propagate
correctly, the extension should be ".pieo" instead.

Requires D49965 to be committed first.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dim created this revision.Apr 22 2025, 6:40 PM

Herald added a subscriber: bdrewery. · View Herald TranscriptApr 22 2025, 6:40 PM

dim requested review of this revision.Apr 22 2025, 6:40 PM

Harbormaster completed remote builds in B63644: Diff 154115.Apr 22 2025, 6:40 PM

emaste added inline comments.Apr 22 2025, 6:47 PM

share/mk/bsd.prog.mk
55–57	As an aside, I wonder if Makefiles, tools, etc., would work if we made this `OBJ_EXT=pie.o`

dim mentioned this in D49967: Convert libllvm, libclang and liblldb into private shared libraries.Apr 22 2025, 6:49 PM

dim added inline comments.Apr 22 2025, 7:10 PM

share/mk/bsd.prog.mk
55–57	As an aside, I wonder if Makefiles, tools, etc., would work if we made this `OBJ_EXT=pie.o` With other make implementations there is typically a `$(suffix ...)` function that splits on the rightmost dot, so that wouldn't work for that case. In bmake I think it will depend on whether it understands the following notation for a suffix-transformation rule: .c.pie.o: <recipe>