Page MenuHomeFreeBSD

contrib/llvm-project: fix clang crash compiling modules
ClosedPublic

Authored by ivy on Jun 25 2025, 4:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 31, 5:21 AM
Unknown Object (File)
Wed, May 20, 7:58 PM
Unknown Object (File)
May 13 2026, 10:50 AM
Unknown Object (File)
May 13 2026, 6:30 AM
Unknown Object (File)
May 12 2026, 10:43 AM
Unknown Object (File)
May 11 2026, 4:51 PM
Unknown Object (File)
May 11 2026, 10:23 AM
Unknown Object (File)
May 11 2026, 1:37 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivy requested review of this revision.Jun 25 2025, 4:02 PM

Can you put a MFC after: 3 days header in the commit message, please? (I tend to use 3 days for upstream commits that are trivial; this one seems a bit more extensive so maybe you can extend the MFC period to one or two weeks)

This revision is now accepted and ready to land.Jun 25 2025, 4:47 PM
In D51041#1164931, @dim wrote:

Can you put a MFC after: 3 days header in the commit message, please?

i've added 3 days to my local commit message. i've tested this with buildworld and with the commit that produced the problem, and it's in a fairly niche feature (C++20 modules) so i'm happy with 3 days personally, but i could do longer if you think it's appropriate.

3 days is fine, if it works. :)