Page MenuHomeFreeBSD

contrib/llvm-project: fix clang crash compiling modules
ClosedPublic

Authored by ivy on Jun 25 2025, 4:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 11:38 AM
Unknown Object (File)
Mon, Oct 13, 11:38 AM
Unknown Object (File)
Mon, Oct 13, 11:38 AM
Unknown Object (File)
Sun, Oct 12, 10:57 PM
Unknown Object (File)
Thu, Sep 25, 11:07 PM
Unknown Object (File)
Thu, Sep 25, 8:34 PM
Unknown Object (File)
Tue, Sep 23, 8:07 PM
Unknown Object (File)
Sat, Sep 20, 4:38 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivy requested review of this revision.Jun 25 2025, 4:02 PM

Can you put a MFC after: 3 days header in the commit message, please? (I tend to use 3 days for upstream commits that are trivial; this one seems a bit more extensive so maybe you can extend the MFC period to one or two weeks)

This revision is now accepted and ready to land.Jun 25 2025, 4:47 PM
In D51041#1164931, @dim wrote:

Can you put a MFC after: 3 days header in the commit message, please?

i've added 3 days to my local commit message. i've tested this with buildworld and with the commit that produced the problem, and it's in a fairly niche feature (C++20 modules) so i'm happy with 3 days personally, but i could do longer if you think it's appropriate.

3 days is fine, if it works. :)