Page MenuHomeFreeBSD
Feed Advanced Search

Tue, Oct 12

eugen_grosbein.net committed R11:c38fddddbeec: net/quagga: make it fetchable again (authored by eugen_grosbein.net).
net/quagga: make it fetchable again
Tue, Oct 12, 8:40 AM

Mon, Oct 11

eugen_grosbein.net accepted D32437: last: improve non-UTF8 locale output after libxo support was added.
Mon, Oct 11, 4:40 AM

Thu, Oct 7

eugen_grosbein.net committed R10:37381a47e0ff: syslogd: undo regression after r326573 (authored by eugen_grosbein.net).
syslogd: undo regression after r326573
Thu, Oct 7, 3:13 AM
eugen_grosbein.net committed R10:75c6f34fbedd: syslogd: undo regression after r326573 (authored by eugen_grosbein.net).
syslogd: undo regression after r326573
Thu, Oct 7, 3:10 AM
eugen_grosbein.net committed R10:7cf79c60fee5: syslogd: undo regression after r326573 (authored by eugen_grosbein.net).
syslogd: undo regression after r326573
Thu, Oct 7, 3:08 AM

Fri, Oct 1

eugen_grosbein.net committed R11:db8499a9f887: textproc/sgmlformat: unbreak for external groff (authored by eugen_grosbein.net).
textproc/sgmlformat: unbreak for external groff
Fri, Oct 1, 8:06 AM

Mon, Sep 27

eugen_grosbein.net committed R10:3b4cc56e524a: syslogd: undo regression after r326573 (authored by eugen_grosbein.net).
syslogd: undo regression after r326573
Mon, Sep 27, 7:32 AM

Sat, Sep 18

eugen_grosbein.net committed R11:73fc549fd2fd: net/mpd5: add missing change after previous revision (authored by eugen_grosbein.net).
net/mpd5: add missing change after previous revision
Sat, Sep 18, 4:13 PM
eugen_grosbein.net committed R11:091a500aaa52: net/mpd5: unbreak multihomed L2TP server setup and add WITHOUT_RADIUS (authored by eugen_grosbein.net).
net/mpd5: unbreak multihomed L2TP server setup and add WITHOUT_RADIUS
Sat, Sep 18, 3:45 PM

Fri, Sep 17

eugen_grosbein.net committed R11:0727cd2415ff: security/vuxml: fix range in vid f55921aa-10c9-11ec-8647-00e0670f2660 (authored by eugen_grosbein.net).
security/vuxml: fix range in vid f55921aa-10c9-11ec-8647-00e0670f2660
Fri, Sep 17, 7:24 PM
eugen_grosbein.net committed R11:e094a06a8c68: security/i2pd: add lowest boost-libs version required (authored by eugen_grosbein.net).
security/i2pd: add lowest boost-libs version required
Fri, Sep 17, 6:02 PM
eugen_grosbein.net added a comment to D32008: Remove support for FreeBSD 11.4.

Please skip the change for security/ipsec-tools as was already applied and then reverted: the change breaks upgrade path from previous version like 9.x or 10.x or 11.0 because they do no have ipsec.ko as a module.

Fri, Sep 17, 5:21 PM

Sep 8 2021

eugen_grosbein.net committed R11:f51bea8bb347: net/mpd5: fix PPPoE Server remotely exploitable crash (authored by eugen_grosbein.net).
net/mpd5: fix PPPoE Server remotely exploitable crash
Sep 8 2021, 10:19 PM
eugen_grosbein.net committed R11:9cf7566d021e: net/mpd5: add L2TP fix from upstream (r2410, r2411). (authored by eugen_grosbein.net).
net/mpd5: add L2TP fix from upstream (r2410, r2411).
Sep 8 2021, 10:19 PM
eugen_grosbein.net committed R11:1f6fcc264e1d: net/mpd5: fix PPPoE Server remotely exploitable crash (authored by eugen_grosbein.net).
net/mpd5: fix PPPoE Server remotely exploitable crash
Sep 8 2021, 10:09 PM
eugen_grosbein.net committed R11:2c7d4d50c06a: security/vuxml: add net/mpd5 PPPoE Server remotely exploitable crash (authored by eugen_grosbein.net).
security/vuxml: add net/mpd5 PPPoE Server remotely exploitable crash
Sep 8 2021, 10:09 PM

Aug 28 2021

eugen_grosbein.net committed R11:2daa6c3395df: net/mpd5: unbreak build for GCC (powerpc64) (authored by eugen_grosbein.net).
net/mpd5: unbreak build for GCC (powerpc64)
Aug 28 2021, 7:35 PM
eugen_grosbein.net committed R11:d823e066215b: devel/py-application: drop maintainership (authored by eugen_grosbein.net).
devel/py-application: drop maintainership
Aug 28 2021, 7:35 PM

Aug 18 2021

eugen_grosbein.net committed R11:b69e9c3c4e6f: security/ipsec-tools: make upgrade less painful (authored by eugen_grosbein.net).
security/ipsec-tools: make upgrade less painful
Aug 18 2021, 1:09 PM
eugen_grosbein.net committed R11:fe1375b13d3a: net/mpd5: add L2TP fix from upstream (r2410, r2411). (authored by eugen_grosbein.net).
net/mpd5: add L2TP fix from upstream (r2410, r2411).
Aug 18 2021, 12:52 PM

Jul 16 2021

eugen_grosbein.net committed R10:aed0c36c718c: rc.d: connect sysctl_lastload (authored by eugen_grosbein.net).
rc.d: connect sysctl_lastload
Jul 16 2021, 6:47 AM
eugen_grosbein.net committed R10:5cc84f7ae5a6: rc.d: connect sysctl_lastload (authored by eugen_grosbein.net).
rc.d: connect sysctl_lastload
Jul 16 2021, 6:46 AM
eugen_grosbein.net committed R10:61891195f8ed: ipfw: reload sysctl.conf variables if needed (authored by eugen_grosbein.net).
ipfw: reload sysctl.conf variables if needed
Jul 16 2021, 6:43 AM
eugen_grosbein.net committed R10:c403205e553e: ipfw: reload sysctl.conf variables if needed (authored by eugen_grosbein.net).
ipfw: reload sysctl.conf variables if needed
Jul 16 2021, 6:42 AM
eugen_grosbein.net committed R10:6ec2f0d74b22: rc.d: unbreak sysctl lastload (authored by eugen_grosbein.net).
rc.d: unbreak sysctl lastload
Jul 16 2021, 6:38 AM
eugen_grosbein.net committed R10:4ee2bcb486ad: rc.d: unbreak sysctl lastload (authored by eugen_grosbein.net).
rc.d: unbreak sysctl lastload
Jul 16 2021, 6:36 AM

Jul 10 2021

eugen_grosbein.net committed R11:941d1da4dcb7: lang/gprolog: update to 1.5.0 (authored by eugen_grosbein.net).
lang/gprolog: update to 1.5.0
Jul 10 2021, 10:19 PM

Jun 18 2021

eugen_grosbein.net accepted D30614: xinstall: fix invocation of llvm-strip.
Jun 18 2021, 3:43 PM

Jun 17 2021

eugen_grosbein.net committed R11:ba9b50a94af9: sysutils/fusefs-webdavfs: update to g20200520 (authored by eugen_grosbein.net).
sysutils/fusefs-webdavfs: update to g20200520
Jun 17 2021, 4:41 AM

Jun 8 2021

eugen_grosbein.net requested changes to D30614: xinstall: fix invocation of llvm-strip.

I agree that snprintf() should be avoided here, as well as stack abuse. Please consider using asprintf() that allocated memory on heap all by itself dealing with space requirements automatically, just free the pointer just after posix_spawnp().

Jun 8 2021, 9:54 PM

May 26 2021

eugen_grosbein.net committed R10:3bca93e04275: rc.d/random: add support for zero harvest_mask (authored by eugen_grosbein.net).
rc.d/random: add support for zero harvest_mask
May 26 2021, 11:41 AM

May 23 2021

eugen_grosbein.net committed R10:d6112f7dd874: if_vlan.c: really fix it. (authored by eugen_grosbein.net).
if_vlan.c: really fix it.
May 23 2021, 3:04 AM
eugen_grosbein.net committed R10:bb12347c3b30: if_vlan.c: fix breakage after previous merge (authored by eugen_grosbein.net).
if_vlan.c: fix breakage after previous merge
May 23 2021, 1:07 AM
eugen_grosbein.net committed R10:18fa0cbfc4e9: MFC r351629: sys/net/if_vlan.c: Wrap a vlan's parent's if_output (authored by mjoras).
MFC r351629: sys/net/if_vlan.c: Wrap a vlan's parent's if_output
May 23 2021, 12:05 AM

May 20 2021

eugen_grosbein.net committed R10:20eb96979392: rc.d: connect sysctl_lastload (authored by eugen_grosbein.net).
rc.d: connect sysctl_lastload
May 20 2021, 4:52 AM

May 19 2021

eugen_grosbein.net committed R10:f4b38c360e63: rc.d: unbreak sysctl lastload (authored by eugen_grosbein.net).
rc.d: unbreak sysctl lastload
May 19 2021, 1:10 PM
eugen_grosbein.net committed R10:271f9f2e8b93: MFC r307882: bsnmpd: fix SNMPv3 (authored by syrinx).
MFC r307882: bsnmpd: fix SNMPv3
May 19 2021, 12:06 PM

May 18 2021

eugen_grosbein.net added a comment to D26447: add deprecation notice to ftpd.
In D26447#664154, @gnn wrote:

Now that this review has devolved to the point of discussing democracy, rather than the deprecation of a piece of long surviving, but, inherently insecure code in our base system, it's time for people to step back from their keyboards and realize that removing this from base does not make it impossible to install or use, it simply reduces the default attack surface of our system. So, let's let emaste put this deprecation in for 14, and move on.

May 18 2021, 12:33 AM

May 17 2021

eugen_grosbein.net committed R10:f5b5de1a3210: ipfw: reload sysctl.conf variables if needed (authored by eugen_grosbein.net).
ipfw: reload sysctl.conf variables if needed
May 17 2021, 9:27 PM

May 15 2021

eugen_grosbein.net committed R11:ed8939d4472b: lang/gprolog: Comment out BROKEN_riscv64 (authored by eugen_grosbein.net).
lang/gprolog: Comment out BROKEN_riscv64
May 15 2021, 3:44 AM

May 14 2021

eugen_grosbein.net committed R11:f81d67ce4708: lang/gprolog: unbreak for FreeBSD 13+ (authored by eugen_grosbein.net).
lang/gprolog: unbreak for FreeBSD 13+
May 14 2021, 4:13 PM
eugen_grosbein.net committed R11:0796c5abcb20: lang/yap: improve documentation handling (authored by eugen_grosbein.net).
lang/yap: improve documentation handling
May 14 2021, 1:15 PM

Apr 6 2021

eugen_grosbein.net requested changes to D26447: add deprecation notice to ftpd.

Please keep ftp and telnet clients and servers in base system. Removing violates POLA and does not buy anything. Servers already disables by default.

Apr 6 2021, 10:50 AM
eugen_grosbein.net added a reviewer for D26447: add deprecation notice to ftpd: eugen_grosbein.net.
Apr 6 2021, 10:48 AM
eugen_grosbein.net added a reviewer for D26447: add deprecation notice to ftpd: network.
Apr 6 2021, 10:48 AM

Aug 1 2020

eugen_grosbein.net updated the summary of D25911: bsnmpget should print protocol errors to stderr.
Aug 1 2020, 9:10 AM
eugen_grosbein.net requested review of D25911: bsnmpget should print protocol errors to stderr.
Aug 1 2020, 9:08 AM

Jul 16 2020

eugen_grosbein.net abandoned D25681: if_spppsubr: Define a few LCP options, Recognize (but still reject) multilink PPP config options.
Jul 16 2020, 6:32 AM · network, transport
eugen_grosbein.net updated subscribers of D25681: if_spppsubr: Define a few LCP options, Recognize (but still reject) multilink PPP config options.

Sorry for the mess, my latest actions on this differential were unintentional, some problems with old Firefox.

Jul 16 2020, 6:32 AM · network, transport
eugen_grosbein.net reclaimed D25681: if_spppsubr: Define a few LCP options, Recognize (but still reject) multilink PPP config options.
Jul 16 2020, 6:26 AM · network, transport
eugen_grosbein.net commandeered D25681: if_spppsubr: Define a few LCP options, Recognize (but still reject) multilink PPP config options.
Jul 16 2020, 6:25 AM · network, transport
eugen_grosbein.net updated subscribers of D25681: if_spppsubr: Define a few LCP options, Recognize (but still reject) multilink PPP config options.

CCing Roman Kurakin (ce(4)) and Serge Vakulenko (cp(4)), see later.

Jul 16 2020, 6:19 AM · network, transport

Jul 9 2020

eugen_grosbein.net added a comment to D25551: Optimize "install -s" and installworld.

I'm going to commit this soon unless an objection is raised.

Jul 9 2020, 2:31 AM

Jul 3 2020

eugen_grosbein.net added a comment to D25551: Optimize "install -s" and installworld.

My goal is to improve performance by default not requiring any user actions while not breaking things same time. Both GNU binutils version of strip(1) and our version from contrib/elftoolchain/elfcopy support -o, so there would be no slowdown but improvement for all supported branches. However, install(1) could be used in some strange environment for cases other than "installworld" and I don't want it to break there making regression.

Jul 3 2020, 5:30 AM
eugen_grosbein.net added a comment to D25551: Optimize "install -s" and installworld.

Thanks, I've fixed this.

Jul 3 2020, 5:11 AM
eugen_grosbein.net updated the diff for D25551: Optimize "install -s" and installworld.

Use: strip -o to_name -- from_name

Jul 3 2020, 5:09 AM

Jul 2 2020

eugen_grosbein.net updated the summary of D25551: Optimize "install -s" and installworld.
Jul 2 2020, 8:39 PM
eugen_grosbein.net updated the test plan for D25551: Optimize "install -s" and installworld.
Jul 2 2020, 7:31 PM
eugen_grosbein.net updated the summary of D25551: Optimize "install -s" and installworld.
Jul 2 2020, 7:24 PM
eugen_grosbein.net requested review of D25551: Optimize "install -s" and installworld.
Jul 2 2020, 7:18 PM

Jun 3 2020

eugen_grosbein.net added a comment to D25029: Introduce ifconfig -a -[gG] groupname.

Thanks!

Jun 3 2020, 1:20 PM
eugen_grosbein.net updated the diff for D25029: Introduce ifconfig -a -[gG] groupname.

Correct wording in the manual page.

Jun 3 2020, 1:19 PM
eugen_grosbein.net added a comment to D25029: Introduce ifconfig -a -[gG] groupname.

I'm going to commit this soon unless an objection is raised.

Jun 3 2020, 12:39 PM

Jun 2 2020

eugen_grosbein.net added a comment to D25029: Introduce ifconfig -a -[gG] groupname.
In D25029#552845, @lutz_donnerhacke.de wrote:

If I understand correctly

ifconfig -a -g lagg -G lagg*1

will match all lagg interfaces besides those ending in 1.

But

ifconfig -a -g lagg -g vlan

will match vlan interfaces only.

Correct?

Jun 2 2020, 1:31 PM
eugen_grosbein.net updated the diff for D25029: Introduce ifconfig -a -[gG] groupname.

Add explicit note to the manual page that additional options -g override previous ones, same for -G.

Jun 2 2020, 1:29 PM

May 31 2020

eugen_grosbein.net updated the diff for D25029: Introduce ifconfig -a -[gG] groupname.

Fix case when none of -g nor -G is specified that was broken with addition of second option.

May 31 2020, 7:48 PM
eugen_grosbein.net updated the summary of D25029: Introduce ifconfig -a -[gG] groupname.
May 31 2020, 1:44 AM
eugen_grosbein.net updated the summary of D25029: Introduce ifconfig -a -[gG] groupname.
May 31 2020, 1:42 AM
eugen_grosbein.net updated the diff for D25029: Introduce ifconfig -a -[gG] groupname.

Do not use prefix to negate condition. Instead, use new flag -G and allow user to specify both -g and -G same time.

May 31 2020, 1:41 AM
eugen_grosbein.net added a comment to D25029: Introduce ifconfig -a -[gG] groupname.
In D25029#552131, @lutz_donnerhacke.de wrote:

"^" does look like an regex starting point and will cause confusion: "Why is '-g la.*2[345]' not working?"

May 31 2020, 12:15 AM

May 29 2020

eugen_grosbein.net added a comment to D25029: Introduce ifconfig -a -[gG] groupname.
In D25029#551705, @ae wrote:

You can just use another option name to specify excludes.

May 29 2020, 1:00 PM
eugen_grosbein.net added inline comments to D25029: Introduce ifconfig -a -[gG] groupname.
May 29 2020, 12:45 PM
eugen_grosbein.net added inline comments to D25029: Introduce ifconfig -a -[gG] groupname.
May 29 2020, 8:26 AM

May 27 2020

eugen_grosbein.net added inline comments to D25029: Introduce ifconfig -a -[gG] groupname.
May 27 2020, 8:02 PM
eugen_grosbein.net updated the diff for D25029: Introduce ifconfig -a -[gG] groupname.

Compactify code a bit.

May 27 2020, 1:59 PM
eugen_grosbein.net updated the diff for D25029: Introduce ifconfig -a -[gG] groupname.

Fix misprint that somehow passed testing.

May 27 2020, 1:31 PM
eugen_grosbein.net requested review of D25029: Introduce ifconfig -a -[gG] groupname.
May 27 2020, 1:20 PM
eugen_grosbein.net accepted D18382: Add new "trim" conversion for dd(1).
May 27 2020, 1:04 PM

Apr 16 2020

eugen_grosbein.net added a comment to D24383: ethersubr: Make the mac address generation more robust.

Kernel side asprintf() uses M_NOWAIT internally and may return -1 on memory allocation failure. It would need a check.

Apr 16 2020, 6:27 PM
eugen_grosbein.net requested changes to D24383: ethersubr: Make the mac address generation more robust.

Please consider to decrease abuse of kernel stack. We already had problems with kernel-land double faults due to kernel thread stack overflows. Could you please aggregate these big but fixed-sized arrays to single struct and allocate it using one malloc() call at heap instead?

Apr 16 2020, 4:17 AM

Apr 14 2020

eugen_grosbein.net added a comment to D24416: epair: Simplify mac address generation.
In D24416#537135, @kp wrote:

I can't create epair0 again even though it no longer exists in the host vnet.

Apr 14 2020, 5:50 PM
eugen_grosbein.net added a comment to D24416: epair: Simplify mac address generation.

I haven't been paying attention to this, but IME the problem with epair (and also bridge) interfaces was always that the generator would come up with the same MAC address on different *machines*. We simply gave up and manually assigned LAA MAC addresses to all such interfaces.

Apr 14 2020, 5:48 PM
eugen_grosbein.net added a comment to D24416: epair: Simplify mac address generation.

You still miss the point. Please read PR 229957 there all epairs are created within host, so they have same UUID. But after epair is created and MAC generated, epair get moved to another VNET, so next one may be created within host with same properties and get same MAC address.

Apr 14 2020, 4:28 PM
eugen_grosbein.net requested changes to D24416: epair: Simplify mac address generation.

Sadly, ether_gen_addr() cannot be used for epair safely. Your change removes parts of code that was brought in for a reason. This change would re-introduce problems fixed by code removed. Please read PRs 184149 and 229957 for details.

Apr 14 2020, 1:16 PM

Apr 12 2020

eugen_grosbein.net added a comment to D24371: trim(8): candelete() returns wrong results because fd is opened O_WRONLY.

Also, trim(8) calls candelete() for cosmetic reasons only and in verbose mode only (by default).
"trim -q" does not call candelete() and always reveals real error of system call.

Apr 12 2020, 6:10 AM
eugen_grosbein.net added a comment to D24371: trim(8): candelete() returns wrong results because fd is opened O_WRONLY.

This seems to be driver-dependent as it works as expected for md:

Apr 12 2020, 6:03 AM

Apr 11 2020

eugen_grosbein.net added a comment to D24371: trim(8): candelete() returns wrong results because fd is opened O_WRONLY.

I'm not sure I understand the problem.

Apr 11 2020, 4:55 PM

Feb 15 2020

eugen_grosbein.net added a comment to D23577: divert: Add socket options for divert socket's send and receive buffers.
In D23577#519163, @aleksandr.fedorov_itglobal.com wrote:

divert sockets can be used with other software but present exactly same significant overhead.
Do you have an example when suggested change improves performance really?

I agree with you that divert sockets have a known overhead. And I don't have a suitable example, because I don't use them anywhere. On the other hand, I see no reason why the initial socket buffer size should be hardcoded. My experience with other types of sockets indicates that large buffers can increase throughput. For example, netgraph sockets.

So, if some people want to use divert sockets, why not add the ability to resize the buffer socket?

Feb 15 2020, 2:05 PM
eugen_grosbein.net added a comment to D23577: divert: Add socket options for divert socket's send and receive buffers.
In D23577#520228, @lutz_donnerhacke.de wrote:
In D23577#519182, @lutz_donnerhacke.de wrote:

Can you please explain, what the issue is with the sysctl itself?

Sysctls are great tools and very handy, so our sysctl tree grows quick and already bloated and needs increasing amounts of memory. I don't think we should add new one just because it's easy and we can do it, without any practical use case.

So how implementing an (existing) socketopt to modify the desired behavior from the application side?

Feb 15 2020, 2:00 PM
eugen_grosbein.net added a comment to D23577: divert: Add socket options for divert socket's send and receive buffers.
In D23577#519182, @lutz_donnerhacke.de wrote:

Can you please explain, what the issue is with the sysctl itself?

Feb 15 2020, 12:15 PM
eugen_grosbein.net added a comment to D23577: divert: Add socket options for divert socket's send and receive buffers.
In D23577#519163, @aleksandr.fedorov_itglobal.com wrote:

divert sockets can be used with other software but present exactly same significant overhead.
Do you have an example when suggested change improves performance really?

I agree with you that divert sockets have a known overhead. And I don't have a suitable example, because I don't use them anywhere. On the other hand, I see no reason why the initial socket buffer size should be hardcoded. My experience with other types of sockets indicates that large buffers can increase throughput. For example, netgraph sockets.

So, if some people want to use divert sockets, why not add the ability to resize the buffer socket?

Feb 15 2020, 12:13 PM

Feb 12 2020

eugen_grosbein.net added a comment to D23577: divert: Add socket options for divert socket's send and receive buffers.
In D23577#518798, @aleksandr.fedorov_itglobal.com wrote:

divert(4) sockets can be used not only with natd(8), so the changes looks reasonable for me.

Feb 12 2020, 11:24 AM
eugen_grosbein.net added a comment to D23577: divert: Add socket options for divert socket's send and receive buffers.
In D23577#518767, @neel_neelc.org wrote:

Please describe use case for this change. Also, defauls are not 65536 but (65536 + 100).

This can be used to reduce divert memory consumption on "small" devices (e.g. low power routers) or increase divert performance on "big" devices (e.g. middleboxes, IDS).

I updated the description.

Feb 12 2020, 6:21 AM
eugen_grosbein.net added a comment to D23577: divert: Add socket options for divert socket's send and receive buffers.

Please describe use case for this change. Also, defauls are not 65536 but (65536 + 100).

Feb 12 2020, 4:36 AM
eugen_grosbein.net accepted D23091: netgraph/ng_nat: Prevent crash by malformated packets.
In D23091#518544, @lutz_donnerhacke.de wrote:

@eugen_grosbein.net are your concerns handled?

Feb 12 2020, 12:05 AM

Feb 9 2020

eugen_grosbein.net added a comment to D23586: ipfw_nat: Perfomance of accessing multiple nat tables.

We already have "nat tablearg" feature for this task:

Feb 9 2020, 6:44 AM

Feb 4 2020

eugen_grosbein.net added a comment to D23450: libalias: Allow setting alias port ranges.
In D23450#515674, @pi wrote:

What happens, if some port mapping is defined unexpected source IPs are sent from behind the CGN ? Will this packet/port end up 'somewhere' in the reserved range or will it map somewhere outside of all reserved ranges ?

Feb 4 2020, 10:51 AM
eugen_grosbein.net added a comment to D23450: libalias: Allow setting alias port ranges.
In D23450#515673, @pi wrote:

The use case is a static mapping from behind-nat users to the outside world. If such a static mapping is possible, CGN-operators do not need to log every transaction.

Feb 4 2020, 10:37 AM
eugen_grosbein.net added a reviewer for D23450: libalias: Allow setting alias port ranges: eugen_grosbein.net.
Feb 4 2020, 10:11 AM
eugen_grosbein.net added a reviewer for D23450: libalias: Allow setting alias port ranges: network.

Please describe why do you need to limit aliasing port rangle for NAT instance and what is wrong with current unlimited and mixed usage of ports for NAT instances?

Feb 4 2020, 10:02 AM