devd: Add vm_guest variable
Needs ReviewPublic
Actions

Authored by imp on Jul 19 2025, 5:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jul 12, 7:29 AM

	Unknown Object (File)
	Sat, Jul 11, 4:35 PM

	Unknown Object (File)
	Sat, Jul 4, 12:22 AM

	Unknown Object (File)
	Fri, Jul 3, 6:42 AM

	Unknown Object (File)
	Sat, Jun 27, 3:15 PM

	Unknown Object (File)
	Jun 4 2026, 4:50 PM

	Unknown Object (File)
	Jun 4 2026, 5:42 AM

	Unknown Object (File)
	May 14 2026, 1:45 AM

View All 55 Files

Subscribers

asomers

Details

Reviewers

eugen_grosbein.net

Summary

Fetch vm_guest on startup in case we're running in a jail.

PR: 287873
Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65578
Build 62461: arc lint + arc unit

Event Timeline

imp created this revision.Jul 19 2025, 5:33 AM

Herald added a subscriber: asomers. · View Herald TranscriptJul 19 2025, 5:33 AM

imp requested review of this revision.Jul 19 2025, 5:33 AM

Harbormaster completed remote builds in B65578: Diff 158779.Jul 19 2025, 5:33 AM

The commit message says "jail". But kern.vm_guest doesn't change in a jail. Did you mean to say "in a VM"?

In D51421#1174366, @asomers wrote:

The commit message says "jail". But kern.vm_guest doesn't change in a jail. Did you mean to say "in a VM"?

yea. I gotta update that, and for the bug number and likely to set the author. I just ,cleaned uo the code from the pr. I was initially confused about the jail vs vm thing amd didn't update the comment once I'd sorted that out.

eugen_grosbein.net added a reviewer: eugen_grosbein.net.Jul 20 2025, 7:26 AM

eugen_grosbein.net added inline comments.Jul 20 2025, 7:28 AM

sbin/devd/devd.cc
1357	I've just noticed my patch has a mistake in this devdlog(), it should print "sysctlbyname" instead of "sysctlnametomib".

Revision Contents
Changeset List

Path

Size

sbin/

devd/

devd.cc

12 lines

Diff 158779

View Options

devd: Add vm_guest variableNeeds ReviewPublicActions