Page MenuHomeFreeBSD
Differential D51421

devd: Add vm_guest variable
Needs ReviewPublic
Actions

Authored by imp on Jul 19 2025, 5:33 AM.
Tags
None
Referenced Files
F132683132: D51421.diff
Sun, Oct 19, 12:45 AM
Unknown Object (File)
Sep 16 2025, 6:35 AM
Unknown Object (File)
Sep 16 2025, 4:46 AM
Unknown Object (File)
Sep 7 2025, 10:05 PM
Unknown Object (File)
Aug 26 2025, 10:25 AM
Unknown Object (File)
Aug 25 2025, 7:27 PM
Unknown Object (File)
Aug 25 2025, 7:05 PM
Unknown Object (File)
Aug 25 2025, 6:45 PM
View All 22 Files
Subscribers
asomers

Details

Reviewers
eugen_grosbein.net
Summary

Fetch vm_guest on startup in case we're running in a jail.

PR: 287873
Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65578
Build 62461: arc lint + arc unit

Event Timeline

imp created this revision.Jul 19 2025, 5:33 AM
Herald added a subscriber: asomers. · View Herald TranscriptJul 19 2025, 5:33 AM
imp requested review of this revision.Jul 19 2025, 5:33 AM
Harbormaster completed remote builds in B65578: Diff 158779.Jul 19 2025, 5:33 AM
asomers added a comment.Jul 20 2025, 12:14 AM

The commit message says "jail". But kern.vm_guest doesn't change in a jail. Did you mean to say "in a VM"?

imp added a comment.Jul 20 2025, 4:56 AM
In D51421#1174366, @asomers wrote:

The commit message says "jail". But kern.vm_guest doesn't change in a jail. Did you mean to say "in a VM"?

yea. I gotta update that, and for the bug number and likely to set the author. I just ,cleaned uo the code from the pr. I was initially confused about the jail vs vm thing amd didn't update the comment once I'd sorted that out.

eugen_grosbein.net added a reviewer: eugen_grosbein.net.Jul 20 2025, 7:26 AM
eugen_grosbein.net added inline comments.Jul 20 2025, 7:28 AM
sbin/devd/devd.cc
1357

I've just noticed my patch has a mistake in this devdlog(), it should print "sysctlbyname" instead of "sysctlnametomib".

Revision Contents
Changeset List

PathSize
sbin/
devd/
12 lines

Diff 158779

View Options

sbin/devd/devd.cc

Loading...