Index: en_US.ISO8859-1/articles/committers-guide/article.xml =================================================================== --- en_US.ISO8859-1/articles/committers-guide/article.xml +++ en_US.ISO8859-1/articles/committers-guide/article.xml @@ -3185,10 +3185,7 @@ - Do not commit to anything under the - src/contrib, - src/crypto, or - src/sys/contrib trees without + Do not commit to contributed software without explicit approval from the respective maintainers. @@ -3495,34 +3492,38 @@ - Do not commit to anything under the - src/contrib, - src/crypto, and - src/sys/contrib trees without + Do not commit to contributed software without explicit approval from the respective maintainers. + Contributed software is anything under the + src/contrib, + src/crypto, or + src/sys/contrib trees. + The trees mentioned above are for contributed software usually imported onto a vendor branch. Committing - something there, even if it does not take the file off the - vendor branch, may cause unnecessary headaches for those - responsible for maintaining that particular piece of - software. Thus, unless you have - explicit approval from the maintainer - (or you are the maintainer), do not - commit there! + something there may cause unnecessary headaches + when importing newer versions of the software. As a + general consider sending patches upstream to the vendor. + Patches may be committed to FreeBSD first with permission + of the maintainer. - - Please note that this does not mean you should not try - to improve the software in question; you are still more - than welcome to do so. Ideally, submit your - patches to the vendor. If your changes are - &os;-specific, talk to the maintainer; they may be - willing to apply them locally. But whatever you do, do - not commit there by yourself! + Reasons for modifying upstream software range from + wanting strict control over a tightly coupled dependency + to lack of portability in the canonical + repository's distribution of their code. Regardless of the + reason, effort to minimize the maintenance burden of + fork is helpful to fellow maintainers. Avoid committing + trivial or cosmetic changes to files + since it makes every merge thereafter more + difficult: such patches need to be manually re-verified + every import. - Contact the &a.core; if you wish to take up - maintainership of an unmaintained part of the tree. + If a particular piece of software lacks a maintainer, + you're encouraged to take up owership. If you're unsure + of the current maintainership email &a.arch; and + ask. @@ -5088,28 +5089,6 @@ Miscellaneous Questions - - - Why are trivial or cosmetic changes to files on a - vendor branch a bad idea? - - - - - - From now on, every new vendor release of that file - will need to have patches merged in by hand. - - - - From now on, every new vendor release of that file - will need to have patches - verified by hand. - - - - - How do I add a new file to a branch?