Approved by: maybe my doc mentors, definitely a src committer.
% dot -T png -o /tmp/doc.png share/misc/committers-doc.dot
% dot -T png -o /tmp/ports.png share/misc/committers-ports.dot
% dot -T png -o /tmp/src.png share/misc/committers-src.dot
dot: graph is too large for cairo-renderer bitmaps. Scaling by 0.73637 to fit
% file /tmp/*.png
/tmp/doc.png: PNG image data, 6300 x 1760, 8-bit/color RGBA, non-interlaced
/tmp/ports.png: PNG image data, 18182 x 2647, 8-bit/color RGBA, non-interlaced
/tmp/src.png: PNG image data, 32767 x 1249, 8-bit/color RGB, non-interlaced
I'm assuming RGB instead of RGBA for /tmp/src.png is a result of
"graph is too large" and neither is an actual test failure.
So, assuming this is the final round of reviewing, how does doc committing work for src files that aren't manual pages? Am I allowed (and able) to commit with a src committer's approval, or do I have to ask one to commit for me?
I think comments should be fine, but yes, it's no harm to ask more. :-)
BTW, another thing you might want to do in your onboarding process is changing your phabricator username, there should be a description about this in committer's guide.