Differential D22543

[showmount] implement long options
ClosedPublic
Actions

Authored by eadler on Nov 25 2019, 8:35 AM.

Tags

None

Referenced Files

	F173461295: D22543.id64879.diff
	Sat, Sep 26, 3:08 AM

	Unknown Object (File)
	Tue, Sep 15, 10:31 AM

	Unknown Object (File)
	Tue, Sep 15, 5:24 AM

	Unknown Object (File)
	Sat, Sep 5, 11:24 AM

	Unknown Object (File)
	Wed, Sep 2, 1:03 PM

	Unknown Object (File)
	Wed, Sep 2, 10:53 AM

	Unknown Object (File)
	Wed, Sep 2, 10:52 AM

	Unknown Object (File)
	Wed, Sep 2, 6:58 AM

Subscribers

Details

Reviewers

kevans
rmacklem

Commits

rS355647: [showmount] implement long options

Summary

add long options support to showmount. Where mappings exist use the GNU
names for said options.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

eadler created this revision.Nov 25 2019, 8:35 AM

Herald added a reviewer: manpages. · View Herald TranscriptNov 25 2019, 8:35 AM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B27755: Diff 64846.Nov 25 2019, 8:35 AM

eadler edited reviewers, added: kevans, rmacklem; removed: manpages.Nov 25 2019, 8:36 AM

kevans added inline comments.Nov 25 2019, 1:01 PM

usr.bin/showmount/showmount.c
131 ↗	(On Diff #64846)	Generally when converting to long opts, we should use the '+' leading specifier to maintain preexisting behavior of getopt(3) of halting at the first non-option argument, unless it's really advantageous and we've documented the behavior change.

Harbormaster completed remote builds in B27772: Diff 64879.Nov 26 2019, 6:13 AM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 12 2019, 5:13 AM

Closed by commit rS355647: [showmount] implement long options (authored by eadler). · Explain Why

This revision was automatically updated to reflect the committed changes.

eadler added a commit: rS355647: [showmount] implement long options.

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

showmount/

8 lines

11 lines

Diff 65535

head/usr.bin/showmount/showmount.8

Loading...

head/usr.bin/showmount/showmount.c

Loading...