Page MenuHomeFreeBSD
Differential D22543

[showmount] implement long options
ClosedPublic
Actions

Authored by eadler on Nov 25 2019, 8:35 AM.

Details

Reviewers
kevans
rmacklem
Commits
rS355647: [showmount] implement long options
Summary

add long options support to showmount. Where mappings exist use the GNU
names for said options.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

eadler created this revision.Nov 25 2019, 8:35 AM
Herald added a reviewer: manpages. · View Herald TranscriptNov 25 2019, 8:35 AM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B27755: Diff 64846.Nov 25 2019, 8:35 AM
eadler edited reviewers, added: kevans, rmacklem; removed: manpages.Nov 25 2019, 8:36 AM
kevans added inline comments.Nov 25 2019, 1:01 PM
usr.bin/showmount/showmount.c
131 ↗(On Diff #64846)

Generally when converting to long opts, we should use the '+' leading specifier to maintain preexisting behavior of getopt(3) of halting at the first non-option argument, unless it's really advantageous and we've documented the behavior change.

eadler updated this revision to Diff 64879.Nov 26 2019, 6:13 AM

per @kevans

Harbormaster completed remote builds in B27772: Diff 64879.Nov 26 2019, 6:13 AM
eadler added a comment.Nov 29 2019, 2:11 AM

@kevans ping?

This revision was not accepted when it landed; it landed in state Needs Review.Dec 12 2019, 5:13 AM
Closed by commit rS355647: [showmount] implement long options (authored by eadler). · Explain Why
This revision was automatically updated to reflect the committed changes.
eadler added a commit: rS355647: [showmount] implement long options.

Revision Contents
Changeset List

PathSize
head/
usr.bin/
showmount/
8 lines
11 lines

Diff 65535

View Options

head/usr.bin/showmount/showmount.8

Loading...
View Options

head/usr.bin/showmount/showmount.c

Loading...