Page MenuHomeFreeBSD

The Porter's Handbook Go chapter: Document GO_TESTTARGET
ClosedPublic

Authored by dmgk on Nov 16 2019, 7:26 PM.

Diff Detail

Repository
rD FreeBSD doc repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

No longer relevant/requires changes after rP518928.

Hi Dmitri, do you plan to reclaim/commit this too after rP526567? @eadler already approved it before.

Hi Dmitri, do you plan to reclaim/commit this too after rP526567? @eadler already approved it before.

I am, but doesn't this still need approval from @mat first?

Rename GO_TEST_TARGET to GO_TESTTARGET

dmgk retitled this revision from The Porter's Handbook Go chapter: Document GO_TEST_TARGET to The Porter's Handbook Go chapter: Document GO_TESTTARGET.Feb 20 2020, 1:48 PM
In D22413#522269, @dmgk wrote:

Hi Dmitri, do you plan to reclaim/commit this too after rP526567? @eadler already approved it before.

I am, but doesn't this still need approval from @mat first?

Thanks. I don't think so. You can commit to the doc repository if you have approval from a doc committer. @mat had opportunity before to comment on or veto it.

tobik requested changes to this revision.Feb 20 2020, 1:56 PM

Oh, GO_TESTFLAGS needs to be documented too.

This revision now requires changes to proceed.Feb 20 2020, 1:56 PM
  • Document GO_TESTFLAGS
  • Correct command name in GO_BUILDFLAGS - go.mk doesn't do go install anymore
This revision was not accepted when it landed; it landed in state Needs Review.Feb 20 2020, 3:32 PM
This revision was automatically updated to reflect the committed changes.