User Details
User Details
- User Since
- Mar 29 2021, 10:30 AM (220 w, 5 d)
Mar 5 2025
Mar 5 2025
takahiro.kurosawa_gmail.com accepted D49234: net80211: Fix IEEE80211_KEY_UNDEFINED() in ieee80211_node_delucastkey().
Thanks for fixing!
I've been running the kernel that has exactly the same fix and confirmed the problem I had was fixed.
Mar 4 2025
Mar 4 2025
takahiro.kurosawa_gmail.com added a comment to D48980: net80211: use IEEE80211_KEY_UNDEFINED() insetad of checking they keyix.
It seems that the condition is inversed by this change.
Probably the key need to be deleted if it is set?
Jul 20 2024
Jul 20 2024
takahiro.kurosawa_gmail.com abandoned D45690: ifnet: fix a race in if_detach_internal on clearing if_afdata.
I will retract this since it does not completely fix the problem and I have not come up with a good fix so far.
Jun 24 2024
Jun 24 2024
takahiro.kurosawa_gmail.com added inline comments to D45690: ifnet: fix a race in if_detach_internal on clearing if_afdata.
takahiro.kurosawa_gmail.com updated the diff for D45690: ifnet: fix a race in if_detach_internal on clearing if_afdata.
Replace epoch_wait_preempt() with NET_EPOCH_WAIT()
Jun 22 2024
Jun 22 2024
Aug 5 2023
Aug 5 2023
takahiro.kurosawa_gmail.com requested review of D41330: netlink: fix adding an interface route.
Jun 21 2022
Jun 21 2022
takahiro.kurosawa_gmail.com updated the test plan for D35536: arp(8): use getifaddrs(3) instead of ioctl(SIOCGIFCONF) etc..
Jun 11 2022
Jun 11 2022
takahiro.kurosawa_gmail.com added a comment to D35456: ping6: fix "connect() ssend: Network is unreachable" errors.
@kp Thanks for the comment.
I don't know the detail, but the "NOTES" in ping.c states:
May 28 2022
May 28 2022
takahiro.kurosawa_gmail.com added inline comments to D35307: netinet6: fix proxy NDP.
takahiro.kurosawa_gmail.com updated the diff for D35307: netinet6: fix proxy NDP.
- Add lltable_delete_conditional() instead of lltable_flags_free().
- Use lltable_delete_conditional() for purging in6_multi for solicited node multicast addresses.
- Move out the sockaddr_dl setup code from nd6_ns_input() to a new function.
May 27 2022
May 27 2022
takahiro.kurosawa_gmail.com added inline comments to D35307: netinet6: fix proxy NDP.
takahiro.kurosawa_gmail.com updated the diff for D35307: netinet6: fix proxy NDP.
- Add the lltable.llt_flags member and LLT_ADDEDPROXY flag in it
- Add lltable_flags_free() that frees LLEs with specified la_flags
- Use lltable_flags_free() for freeing in6_multis in if_detach path
- Add the test script
May 26 2022
May 26 2022
takahiro.kurosawa_gmail.com added inline comments to D35323: lltable: use sa_family_t instead of int for lltable.llt_af.
takahiro.kurosawa_gmail.com updated the diff for D35323: lltable: use sa_family_t instead of int for lltable.llt_af.
Add the spare member to indicate explicit alignment.
takahiro.kurosawa_gmail.com added inline comments to D35307: netinet6: fix proxy NDP.
takahiro.kurosawa_gmail.com added reviewers for D35322: lltable: introduce the llt_post_resolved callback: melifaro, network.
takahiro.kurosawa_gmail.com requested review of D35322: lltable: introduce the llt_post_resolved callback.
May 24 2022
May 24 2022
takahiro.kurosawa_gmail.com updated the diff for D35307: netinet6: fix proxy NDP.
Fix spell check warnings
takahiro.kurosawa_gmail.com requested review of D35307: netinet6: fix proxy NDP.
May 12 2022
May 12 2022
takahiro.kurosawa_gmail.com added reviewers for D35188: rtsock: fix buffer overrun (sockaddr misuse): melifaro, network.
takahiro.kurosawa_gmail.com requested review of D35188: rtsock: fix buffer overrun (sockaddr misuse).
Apr 13 2021
Apr 13 2021
takahiro.kurosawa_gmail.com updated the diff for D29468: pf: Implement the NAT source port selection of MAP-E Customer Edge.
- changed the "mape" nvlist structure
- updated the test for the review comments
Apr 12 2021
Apr 12 2021
takahiro.kurosawa_gmail.com added inline comments to D29468: pf: Implement the NAT source port selection of MAP-E Customer Edge.
takahiro.kurosawa_gmail.com updated the diff for D29468: pf: Implement the NAT source port selection of MAP-E Customer Edge.
- moved to the new nvlist-based implementation
- removed timeout in the test
- changed the manual page that map-e-portset is for MAP-E CE (avoid confusion with MAP-E BR)
takahiro.kurosawa_gmail.com added a comment to D29468: pf: Implement the NAT source port selection of MAP-E Customer Edge.
Apr 9 2021
Apr 9 2021
takahiro.kurosawa_gmail.com added a comment to D29468: pf: Implement the NAT source port selection of MAP-E Customer Edge.
@kp thanks for notifying the changes.
I'd like to hear your idea for the following points to rebase the code to the nvlist-based implementation.
Apr 7 2021
Apr 7 2021
Mar 30 2021
Mar 30 2021
takahiro.kurosawa_gmail.com updated the diff for D29468: pf: Implement the NAT source port selection of MAP-E Customer Edge.
- rebased the patch from 12-STABLE to -current
- added the test script
- fixed 2 issues