Page MenuHomeFreeBSD

ndp: improve -c and -d handling in ndp_netlink
ClosedPublic

Authored by rcm on Oct 20 2023, 1:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 10, 10:20 AM
Unknown Object (File)
Sat, Feb 28, 4:39 PM
Unknown Object (File)
Fri, Feb 20, 3:53 PM
Unknown Object (File)
Fri, Feb 20, 12:15 PM
Unknown Object (File)
Thu, Feb 19, 4:30 AM
Unknown Object (File)
Thu, Feb 19, 4:30 AM
Unknown Object (File)
Thu, Feb 19, 4:30 AM
Unknown Object (File)
Thu, Feb 19, 3:07 AM
Subscribers

Details

Summary

This patch restores/fixes some of the behavior present in pre-netlink ndp(8).

  1. Deleting a local address now correctly returns EPERM (instead of ENOENT)
  2. ndp -c no longer dumps the entire table while complaining about local addresses
  3. Return exit code when deleting entry (e.g. trying ndp -d on a local address is an error)

There is still an issue with ndp -s creating duplicate entries. That will be addressed in a separate patch.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rcm requested review of this revision.Oct 20 2023, 1:58 PM
rcm retitled this revision from ndp: improve -d and -c handling in ndp_netlink to ndp: improve -c and -d handling in ndp_netlink.Oct 20 2023, 2:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 23 2023, 8:59 PM
Closed by commit rG934a24e55a78: ndp: improve -c and -d handling in ndp_netlink (authored by rcm, committed by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.