Page MenuHomeFreeBSD
Differential D42307

netlink: fix potential llentry lock leak in newneigh handler
ClosedPublic
Actions

Authored by rcm on Oct 19 2023, 6:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 4:24 PM
Unknown Object (File)
Tue, Apr 30, 4:24 PM
Unknown Object (File)
Tue, Apr 30, 4:24 PM
Unknown Object (File)
Tue, Apr 30, 9:35 AM
Unknown Object (File)
Mon, Apr 29, 9:48 PM
Unknown Object (File)
Sat, Apr 27, 7:38 AM
Unknown Object (File)
Apr 9 2024, 1:50 AM
Unknown Object (File)
Dec 25 2023, 5:23 PM
View All 15 Files
Subscribers
glebius
imp
markj
pfsense

Details

Reviewers
kp
melifaro
markj
Group Reviewers
network
Commits
rG9abf60f5cebf: netlink: fix potential llentry lock leak in newneigh handler
rGeff832ae7b24: netlink: fix potential llentry lock leak in newneigh handler
rGae2ca32781a9: netlink: fix potential llentry lock leak in newneigh handler
Summary

The netlink newneigh handler has the potential to leak the lock on
llentry objects in the kernel. This patch (hopefully) reconciles several
paths through the newneigh handler that could result in a lock leak.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rcm created this revision.Oct 19 2023, 6:27 PM
Herald added subscribers: glebius, imp. · View Herald TranscriptOct 19 2023, 6:27 PM
rcm requested review of this revision.Oct 19 2023, 6:27 PM
markj accepted this revision as: markj.Oct 20 2023, 3:00 PM
markj added a subscriber: markj.
markj added inline comments.
sys/netlink/route/neigh.c
462

There's no need to set lle here since the next line is a return statement.

This revision is now accepted and ready to land.Oct 20 2023, 3:00 PM
rcm added inline comments.Oct 20 2023, 3:31 PM
sys/netlink/route/neigh.c
462

Ah yes thanks

rcm marked an inline comment as done.Oct 20 2023, 3:31 PM
Closed by commit rGae2ca32781a9: netlink: fix potential llentry lock leak in newneigh handler (authored by rcm, committed by kp). · Explain WhyOct 23 2023, 3:11 PM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rGae2ca32781a9: netlink: fix potential llentry lock leak in newneigh handler.
kp added a commit: rGeff832ae7b24: netlink: fix potential llentry lock leak in newneigh handler.Nov 1 2023, 9:06 AM
kp added a commit: rG9abf60f5cebf: netlink: fix potential llentry lock leak in newneigh handler.

Revision Contents
Changeset List

PathSize
sys/
netlink/
route/
22 lines

Diff 129244

View Options

sys/netlink/route/neigh.c

Loading...