Page MenuHomeFreeBSD

netlink: fix potential llentry lock leak in newneigh handler
ClosedPublic

Authored by rcm on Oct 19 2023, 6:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 13 2024, 3:30 AM
Unknown Object (File)
Oct 13 2024, 3:30 AM
Unknown Object (File)
Oct 13 2024, 3:30 AM
Unknown Object (File)
Oct 13 2024, 3:20 AM
Unknown Object (File)
Sep 9 2024, 7:19 AM
Unknown Object (File)
Aug 25 2024, 5:46 AM
Unknown Object (File)
Aug 9 2024, 1:42 AM
Unknown Object (File)
Aug 9 2024, 1:42 AM

Details

Summary

The netlink newneigh handler has the potential to leak the lock on
llentry objects in the kernel. This patch (hopefully) reconciles several
paths through the newneigh handler that could result in a lock leak.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rcm requested review of this revision.Oct 19 2023, 6:27 PM
markj added a subscriber: markj.
markj added inline comments.
sys/netlink/route/neigh.c
462

There's no need to set lle here since the next line is a return statement.

This revision is now accepted and ready to land.Oct 20 2023, 3:00 PM
sys/netlink/route/neigh.c
462

Ah yes thanks

rcm marked an inline comment as done.Oct 20 2023, 3:31 PM