Page MenuHomeFreeBSD

njain15_protonmail.com (Nimish Jain)
njain

Projects

User does not belong to any projects.

User Details

User Since
May 12 2026, 7:00 PM (13 w, 4 d)

Recent Activity

Thu, Aug 13

njain15_protonmail.com added inline comments to D58635: p9fs: add socket transport.
Thu, Aug 13, 6:48 PM
njain15_protonmail.com added inline comments to D58635: p9fs: add socket transport.
Thu, Aug 13, 6:38 PM
njain15_protonmail.com updated the diff for D58635: p9fs: add socket transport.
Thu, Aug 13, 6:36 PM
njain15_protonmail.com updated the summary of D57500: p9fs: Disallow directory unmounting if a session is in progress.
Thu, Aug 13, 6:15 PM
njain15_protonmail.com added inline comments to D58635: p9fs: add socket transport.
Thu, Aug 13, 6:08 PM

Tue, Aug 11

njain15_protonmail.com requested review of D58787: fbsdrun_virtio_msix(): update virtio_msix to virtio.msix.
Tue, Aug 11, 3:23 PM
njain15_protonmail.com added a reviewer for D58787: fbsdrun_virtio_msix(): update virtio_msix to virtio.msix: markj.
Tue, Aug 11, 3:22 PM
njain15_protonmail.com added a comment to D58390: bhyve: namescope virtio_msix to virtio.msix.

Hmm, doesn't fbsdrun_virtio_msix() need to be updated too?

Tue, Aug 11, 3:19 PM

Mon, Aug 10

njain15_protonmail.com updated the diff for D58704: amd64/vmm: allow static compilation.

Cross-compiled aarch64->amd64 and on an amd64 machine.

Mon, Aug 10, 10:51 PM
njain15_protonmail.com updated the diff for D58390: bhyve: namescope virtio_msix to virtio.msix.

Ok, I've updated the diff to be relative to the parent one (that one applies cleanly to main).

Mon, Aug 10, 8:55 PM
njain15_protonmail.com updated the diff for D58704: amd64/vmm: allow static compilation.
  • fixes the cycle in make
  • includes updated vmx.h
Mon, Aug 10, 7:57 PM
njain15_protonmail.com updated the diff for D58690: vmm: fix compilation errors for static kernel on arm64.

Could you try this? I will also updated the diff for amd64.

Mon, Aug 10, 7:34 PM

Sat, Aug 8

njain15_protonmail.com added a comment to D58635: p9fs: add socket transport.

Refactorted with following changes:

  • Migrate from msleep to mtx_sleep. Remove cond vars.
  • Remove module and bake the transport within p9fs.
Sat, Aug 8, 7:06 AM
njain15_protonmail.com updated the diff for D58635: p9fs: add socket transport.
Sat, Aug 8, 6:50 AM

Fri, Aug 7

njain15_protonmail.com requested review of D58704: amd64/vmm: allow static compilation.
Fri, Aug 7, 4:01 PM
njain15_protonmail.com updated the diff for D58635: p9fs: add socket transport.
Fri, Aug 7, 6:26 AM
njain15_protonmail.com added inline comments to D58635: p9fs: add socket transport.
Fri, Aug 7, 6:19 AM
njain15_protonmail.com updated the diff for D58635: p9fs: add socket transport.
Fri, Aug 7, 6:19 AM
njain15_protonmail.com updated the diff for D58635: p9fs: add socket transport.
Fri, Aug 7, 6:15 AM
njain15_protonmail.com requested review of D58697: riscv/vmm: allow vmm to be built in kernel.
Fri, Aug 7, 12:08 AM
njain15_protonmail.com updated the diff for D58690: vmm: fix compilation errors for static kernel on arm64.
Fri, Aug 7, 12:04 AM

Thu, Aug 6

njain15_protonmail.com added inline comments to D58690: vmm: fix compilation errors for static kernel on arm64.
Thu, Aug 6, 11:45 PM
njain15_protonmail.com added a comment to D58690: vmm: fix compilation errors for static kernel on arm64.
Thu, Aug 6, 11:44 PM
njain15_protonmail.com updated the diff for D58690: vmm: fix compilation errors for static kernel on arm64.
Thu, Aug 6, 11:41 PM
njain15_protonmail.com added a comment to D58390: bhyve: namescope virtio_msix to virtio.msix.

@ziaee Yes I think this should be noted in UPDATING.

RELNOTES would be more appropriate. UPDATING is for users tracking main.

LGTM with Relnotes: yes.

Thu, Aug 6, 6:28 PM
njain15_protonmail.com updated the summary of D58390: bhyve: namescope virtio_msix to virtio.msix.
Thu, Aug 6, 6:27 PM
njain15_protonmail.com added inline comments to D58690: vmm: fix compilation errors for static kernel on arm64.
Thu, Aug 6, 6:10 PM
njain15_protonmail.com requested review of D58690: vmm: fix compilation errors for static kernel on arm64.
Thu, Aug 6, 6:15 AM

Tue, Aug 4

njain15_protonmail.com added a comment to D58633: lib9p: fix mem leaks and use-after-free in socket.c.

Yes, sorry about that.

Tue, Aug 4, 9:06 PM
njain15_protonmail.com updated the diff for D58633: lib9p: fix mem leaks and use-after-free in socket.c.
Tue, Aug 4, 9:06 PM
njain15_protonmail.com added a reviewer for D58635: p9fs: add socket transport: markj.
Tue, Aug 4, 3:41 PM
njain15_protonmail.com added a comment to D58632: p9fs: fix panics in p9fs_vget_common.

Could you commit it as well?

Tue, Aug 4, 3:02 PM
njain15_protonmail.com updated the diff for D58389: virtio: add transitional drivers to bhyve.
Tue, Aug 4, 5:50 AM
njain15_protonmail.com updated the diff for D58390: bhyve: namescope virtio_msix to virtio.msix.

Updated per reviewer comments. D58636 is the parent revision, adding the deprecation warning function.

Tue, Aug 4, 3:06 AM
njain15_protonmail.com updated the diff for D58636: bhyve: add deprecation warning function.
Tue, Aug 4, 2:57 AM
njain15_protonmail.com requested review of D58636: bhyve: add deprecation warning function.
Tue, Aug 4, 2:55 AM
njain15_protonmail.com added a reviewer for D58634: lib9p: fix compilation errors in example server: markj.
Tue, Aug 4, 2:01 AM
njain15_protonmail.com added a reviewer for D58633: lib9p: fix mem leaks and use-after-free in socket.c: markj.
Tue, Aug 4, 1:54 AM
njain15_protonmail.com added a reviewer for D58632: p9fs: fix panics in p9fs_vget_common: kib.
Tue, Aug 4, 1:53 AM
njain15_protonmail.com removed a reviewer for D58633: lib9p: fix mem leaks and use-after-free in socket.c: bhyve.
Tue, Aug 4, 1:38 AM
njain15_protonmail.com requested review of D58635: p9fs: add socket transport.
Tue, Aug 4, 1:37 AM
njain15_protonmail.com requested review of D58634: lib9p: fix compilation errors in example server.
Tue, Aug 4, 1:31 AM
njain15_protonmail.com requested review of D58633: lib9p: fix mem leaks and use-after-free in socket.c.
Tue, Aug 4, 1:27 AM
njain15_protonmail.com requested review of D58632: p9fs: fix panics in p9fs_vget_common.
Tue, Aug 4, 1:21 AM

Wed, Jul 22

njain15_protonmail.com requested review of D58390: bhyve: namescope virtio_msix to virtio.msix.
Wed, Jul 22, 1:01 AM
njain15_protonmail.com requested review of D58389: virtio: add transitional drivers to bhyve.
Wed, Jul 22, 12:55 AM

Jun 22 2026

njain15_protonmail.com added a comment to D57096: Close files that were opened by guest VM via 9pfs.
In D57096#1323730, @kib wrote:

Is there some reference or a spec for the p9fs protocol?

Jun 22 2026, 10:45 AM
njain15_protonmail.com added inline comments to D57096: Close files that were opened by guest VM via 9pfs.
Jun 22 2026, 9:32 AM
njain15_protonmail.com updated the diff for D57096: Close files that were opened by guest VM via 9pfs.
Jun 22 2026, 9:29 AM

Jun 8 2026

njain15_protonmail.com updated the diff for D57096: Close files that were opened by guest VM via 9pfs.
Jun 8 2026, 9:06 AM
njain15_protonmail.com updated the diff for D57096: Close files that were opened by guest VM via 9pfs.

I have made the following changes:

Jun 8 2026, 6:45 AM
njain15_protonmail.com added a reviewer for D57500: p9fs: Disallow directory unmounting if a session is in progress: markj.
Jun 8 2026, 6:06 AM
njain15_protonmail.com requested review of D57500: p9fs: Disallow directory unmounting if a session is in progress.
Jun 8 2026, 6:04 AM
njain15_protonmail.com requested review of D57499: p9fs: Return FreeBSD error codes instead of Linux.
Jun 8 2026, 5:57 AM

May 27 2026

njain15_protonmail.com added a comment to D57096: Close files that were opened by guest VM via 9pfs.

Yes, but. I do not expect that it would be so drastic, and there is probably something else broken. VOP_INACTIVE() is skipped when the current lock in vput() is not exclusive and an immediate upgrade request failed because there are other shared lock owners. At very least this means that there are hold owners on the vnode without refs, which is not typical.

May 27 2026, 11:11 PM

May 25 2026

njain15_protonmail.com updated the diff for D57096: Close files that were opened by guest VM via 9pfs.
May 25 2026, 9:23 PM
njain15_protonmail.com added a comment to D57096: Close files that were opened by guest VM via 9pfs.

Generally VOP_INACTIVE() is a good place, but a (small) problem with it is that it might be skipped

May 25 2026, 8:40 PM
njain15_protonmail.com added a reviewer for D57096: Close files that were opened by guest VM via 9pfs: markj.
May 25 2026, 6:52 PM
njain15_protonmail.com edited reviewers for D57096: Close files that were opened by guest VM via 9pfs, added: delphij, arichardson, kib; removed: emaste.
May 25 2026, 6:44 PM

May 22 2026

njain15_protonmail.com added a reviewer for D57096: Close files that were opened by guest VM via 9pfs: emaste.
May 22 2026, 11:59 PM
njain15_protonmail.com updated the diff for D57096: Close files that were opened by guest VM via 9pfs.
May 22 2026, 11:55 PM
njain15_protonmail.com updated the diff for D57096: Close files that were opened by guest VM via 9pfs.
May 22 2026, 8:48 PM
njain15_protonmail.com updated the diff for D57096: Close files that were opened by guest VM via 9pfs.

@dave_freedave.net Could you try a bulk poudriere run now? I seem to have gotten a successful run.

May 22 2026, 5:58 PM

May 19 2026

njain15_protonmail.com retitled D57096: Close files that were opened by guest VM via 9pfs from Bug fix for PR294327 to Close files that were opened by guest VM via 9pfs.
May 19 2026, 5:15 PM
njain15_protonmail.com updated the summary of D57096: Close files that were opened by guest VM via 9pfs.
May 19 2026, 4:53 PM
njain15_protonmail.com updated the test plan for D57096: Close files that were opened by guest VM via 9pfs.
May 19 2026, 4:51 PM
njain15_protonmail.com updated the summary of D57096: Close files that were opened by guest VM via 9pfs.
May 19 2026, 4:47 PM
njain15_protonmail.com requested review of D57096: Close files that were opened by guest VM via 9pfs.
May 19 2026, 4:31 PM

May 13 2026

njain15_protonmail.com updated njain15_protonmail.com.
May 13 2026, 3:26 AM