Page MenuHomeFreeBSD

freebsd_dev.thsi.be (Benjamin Jacobs)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 13 2024, 4:58 AM (51 w, 4 d)

Recent Activity

Jan 5 2025

freebsd_dev.thsi.be updated the summary of D48228: OCaml update.
Jan 5 2025, 2:32 PM
freebsd_dev.thsi.be updated the summary of D48228: OCaml update.
Jan 5 2025, 1:12 PM
freebsd_dev.thsi.be updated the diff for D48228: OCaml update.

ocaml-zip ocaml:wash removal PR 283713 (timeout very likely)
ocaml-lablgtk2: ocaml:wash removal, misc improvements PR 283714 (timeout very likely)
Mk/Uses/ocaml.mk: removal of ocaml:wash.

Jan 5 2025, 12:43 PM
freebsd_dev.thsi.be updated the diff for D48228: OCaml update.

Rebased, refreshed and commit history cleaned-up.
I will refresh the summary later.

Jan 5 2025, 5:15 AM

Dec 29 2024

freebsd_dev.thsi.be updated the diff for D48228: OCaml update.

Unbreak/refresh lablgtk2 patch

Dec 29 2024, 4:34 PM
freebsd_dev.thsi.be updated the diff for D48228: OCaml update.
  • Uses/ocaml.mk change !empty to defined
Dec 29 2024, 1:16 PM
freebsd_dev.thsi.be updated the diff for D48228: OCaml update.
  • Uses/ocaml.mk documentation
Dec 29 2024, 12:43 PM
freebsd_dev.thsi.be updated the diff for D48228: OCaml update.
  • Uses/ocaml.mk documentation
Dec 29 2024, 12:20 PM
freebsd_dev.thsi.be updated the summary of D48228: OCaml update.
Dec 29 2024, 12:10 PM
freebsd_dev.thsi.be updated the summary of D48228: OCaml update.
Dec 29 2024, 11:48 AM
freebsd_dev.thsi.be updated the diff for D48228: OCaml update.
  • x11-toolkits/ocaml-lablgtk2: Improve port
  • */*: bump revision after ocaml update
  • USE_OCAML* -> USES=ocaml
Dec 29 2024, 11:37 AM
freebsd_dev.thsi.be updated the diff for D48228: OCaml update.
  • USE_OCAML* -> USES=ocaml
Dec 29 2024, 10:35 AM
freebsd_dev.thsi.be updated the diff for D48228: OCaml update.
  • USE_OCAML* -> USES=ocaml
Dec 29 2024, 1:01 AM
freebsd_dev.thsi.be updated the diff for D48228: OCaml update.
  • lang/ocaml: ld.conf trigger, switch ARMv7 to hard fp
  • Mk/Uses/ocaml.mk: USES=ocaml:ldconfig to use pkg trigger
  • ocaml-lacaml: Update to 11.1.1, improve port
  • devel/ocaml-ocamlbuild: Update to 0.15.0
  • devel/ocaml-camomile: Update to 2.0.0
  • devel/ocaml-cmdliner: Update to 1.3.0, improve port
  • devel/ocaml-topkg: Missing RUN_DEPENDS
  • devel/ocaml-dune: Update to 3.16.0
  • devel/ocaml-react: Take maintainership, improve port
  • devel/ocaml-lwt: Update to 5.9.0, fix ccache failure
  • math/coq: Update to 8.20.0
  • devel/ocaml-ocplib-endian: Improve port
  • graphics/ocaml-lablgl: Update to 1.07
  • graphics/ocaml-images: Update to 5.0.5
  • devel/ocaml-ppx_deriving: Update to 6.0.3
  • devel/ocaml-lsp: Update to 1.20.1
  • devel/ocaml-psmt2-frontend: Strip binary
  • devel/ocaml-mtime: Update to 2.1.0
  • devel/ocaml-trace: Update to 0.8
  • devel/ocaml-linol: Update to 0.7
  • devel/ocaml-dolmen: Update to 0.10
  • devel/ocaml-alcotest: New port, user-friendly unit testing for OCaml
  • devel/ocaml-qcheck: New port, property-based testing library for OCaml
  • math/alt-ergo: Update to 2.6.0, improve port
  • devel/ocaml-magic: Update to 0.7.4, take maintainership
  • math/abella: Fix build following ocaml-cmdliner update.
  • math/ocamlgsl: Update to 1.25.1
  • devel/ocaml-pcre: Update to 8.0.1, improve port
  • textproc/ocaml-text: Update to 0.8.1, improve port
  • devel/ocaml-xstrp4: kill USE_OCAMLFIND_PLIST
  • devel/ocaml-xstr: Kill USE_OCAMLFIND_PLIST
  • devel/ocaml-ulex: Kill USE_OCAMLFIND_PLIST, improve port
  • devel/ocaml-type_con: Kill USE_OCAMLFIND_PLIST
  • devel/ocaml-sdl: Kill USE_OCAMLFIND_PLIST
  • devel/ocaml-extlib: Update to 1.8.0, improve port
  • devel/ocaml-classes: Kill USE_OCAMLFIND_PLIST, improve port
  • security/ocaml-cryptgps: Kill USE_OCAMLFIND_PLIST
  • devel/ocaml-calendar: Update to 3.0.0, improve port
  • devel/ocaml-annexlib: Kill USE_OCAMLFIND_PLIST
  • databases/ocaml-mysql: Kill USE_OCAMLFIND_PLIST
  • ftp/ocaml-ocurl: Use proper OCAML_LDLIBS
  • lang/mtasc: Fix BUILD_DEPENDS after extlib update
  • archivers/ocaml-zip: drop USE_OCAML_WASH, set META version
  • x11-toolkits/ocaml-lablgtk2: drop USE_OCAML_WASH
  • */*: bump revision after ocaml update
  • USE_OCAML* -> USES=ocaml
Dec 29 2024, 12:55 AM

Dec 28 2024

freebsd_dev.thsi.be accepted D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.

I've created https://reviews.freebsd.org/D48228
You can see there how I intended to re-do the USE_OCAML_LDCONFIG. I've been testingthat patch on 15amd64 and 13.3 armv7, everything build fine with the exception of math/coq which fails to build the documentation on armv7...

One other thing in that patch is the removal of USE_OCAMLFIND_PLIST, which make the bsd.ocaml.mk to Uses/ocaml.mk transistion less complicated. USE_OCAMLFIND_PLIST isn't really that useful, to the contrary it makes packaging error more likely (e.g. disabling a feature, not noticing less files are packages), so i think it is better to remove it.

Thanks for the work. Unfortunately due to the holidays and everything it's difficult to count maintainer-timeout and commit some of those patches.

Dec 28 2024, 10:51 PM · portmgr
freebsd_dev.thsi.be added a comment to D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.

I've created https://reviews.freebsd.org/D48228
You can see there how I intended to re-do the USE_OCAML_LDCONFIG. I've been testingthat patch on 15amd64 and 13.3 armv7, everything build fine with the exception of math/coq which fails to build the documentation on armv7...

Dec 28 2024, 8:25 PM · portmgr
freebsd_dev.thsi.be added a comment to D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.

Hi,

We should have moved out of Mk/bsd.*.mk (except the obvious ones) maybe a decade ago and these are just some technical debts in the Mk directory. :)

So I am just trying to clear of the Mk directory and I plan to merge this before the next quarterly split. [...]

I am still trying to convert some other keywords into args.

Dec 28 2024, 8:20 PM · portmgr
freebsd_dev.thsi.be requested review of D48228: OCaml update.
Dec 28 2024, 7:57 PM
freebsd_dev.thsi.be added inline comments to D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.
Dec 28 2024, 6:21 PM · portmgr

May 19 2024

freebsd_dev.thsi.be requested review of D45254: lang/ocaml: Update to 4.14.2 with updates to various ocaml ports.
May 19 2024, 4:14 PM

Mar 10 2024

freebsd_dev.thsi.be updated the summary of D43861: OCaml 4.14.1 upgrade..
Mar 10 2024, 12:42 PM
freebsd_dev.thsi.be updated the diff for D43861: OCaml 4.14.1 upgrade..

squashed & rebased

Mar 10 2024, 12:22 PM
freebsd_dev.thsi.be updated the diff for D43861: OCaml 4.14.1 upgrade..
  • devel/ocaml-logs: Missing RUN_DEPENDS.
  • x11-toolkits/ocaml-graphics: Extraneous BUILD_DEPENDS.
  • devel/ocaml-fpath: Missing RUN_DEPENDS.
  • devel/ocaml-fmt: Missing RUN_DEPENDS.
  • devel/ocaml-camomile: Missing RUN_DEPENDS.
  • devel/ocaml-camlp-streams: Package version set.
  • devel/ocaml-csexp: Package version set.
  • devel/ocaml-pcre2: Package version set.
  • devel/ocaml-re: Package version set.
  • x11-toolkits/ocaml-graphics: Package version set.
  • Set WRK_ENV.
Mar 10 2024, 12:10 PM

Mar 2 2024

freebsd_dev.thsi.be added a comment to D43861: OCaml 4.14.1 upgrade..

Thank you again for the reviews. There had been a bit of fallover from the moving of labltk and lablGL to site-lib/, I should have catched them before...
All plist issues should be gone too, as I've learned to use -t with poudriere-bulk ;)

Mar 2 2024, 12:19 PM
freebsd_dev.thsi.be updated the diff for D43861: OCaml 4.14.1 upgrade..

Squashed, commit message preparation.

Mar 2 2024, 11:59 AM
freebsd_dev.thsi.be updated the diff for D43861: OCaml 4.14.1 upgrade..
  • Uses/ocaml.mk: Typo.
  • devel/ocaml-sdl: bad --with-lablgldir.
  • games/freetennis: LablGL moved to site-lib, tidy Makefile.
  • devel/ocaml-logs: PORTDOCS adoption (un-orphaning).
Mar 2 2024, 11:01 AM

Mar 1 2024

freebsd_dev.thsi.be updated the diff for D43861: OCaml 4.14.1 upgrade..
  • Mk/Uses/dune.mk: clean build environment
  • respect MAKE_ENV
  • USES=dune -> USES=ocaml:dune
  • devel/ocaml-dune: fix PORTREVISION increment
  • security/ocaml-ssl: PORTREVISION bump.
  • textproc/ocaml-text: PORTREVISION bump.
Mar 1 2024, 1:11 PM
freebsd_dev.thsi.be updated the diff for D43861: OCaml 4.14.1 upgrade..

ocaml-findlib fix, rebased&squashed.

Mar 1 2024, 3:48 AM

Feb 22 2024

freebsd_dev.thsi.be updated the diff for D43861: OCaml 4.14.1 upgrade..
  • lang/ocaml: Missing PKGNAMESUFFIX.
  • math/teyjus: redundant build dep.
  • devel/ocaml-camlp5: Plist fix.
  • sysutils/ledit: Plist fix, install native binary, manpage version patch.
  • x11-toolkits/ocaml-labltk: Fixes
  • devel/ocaml-findlib: Stop providing conflicting META.
  • devel/ocaml-findlib: Broken POST-DEINSTALL.
  • graphics/ocaml-lablgl: Labltk include path fix, OCAML_SITELIBDIR
  • x11-toolkits/ocaml-lablgtk2: LablGL in site-lib.
Feb 22 2024, 2:28 AM

Feb 21 2024

freebsd_dev.thsi.be added a comment to D43861: OCaml 4.14.1 upgrade..

Hi!

I tested your patch in poudriere. In general it is very good from my POV, congrats on your work.

Feb 21 2024, 10:56 PM
freebsd_dev.thsi.be updated the diff for D43861: OCaml 4.14.1 upgrade..
  • devel/ocaml-camlp5: Plist fix.
  • sysutils/ledit: Plist fix, install native binary, manpage version patch.
  • x11-toolkits/ocaml-labltk: Fixes
  • devel/ocaml-findlib: Stop providing conflicting META.
  • devel/ocaml-findlib: Broken POST-DEINSTALL.
  • graphics/ocaml-lablgl: Labltk include path fix, OCAML_SITELIBDIR, shared librairies stripped, missing GL dependencies
Feb 21 2024, 10:48 PM

Feb 15 2024

freebsd_dev.thsi.be updated the diff for D43861: OCaml 4.14.1 upgrade..
  • lang/ocaml: Missing PKGNAMESUFFIX.
  • math/teyjus: redundant build dep.
Feb 15 2024, 12:32 PM

Feb 13 2024

freebsd_dev.thsi.be added a reviewer for D43861: OCaml 4.14.1 upgrade.: hrs.
Feb 13 2024, 9:21 AM
freebsd_dev.thsi.be added a reviewer for D43861: OCaml 4.14.1 upgrade.: danfe.
Feb 13 2024, 9:10 AM
freebsd_dev.thsi.be added a reviewer for D43861: OCaml 4.14.1 upgrade.: yuri.
Feb 13 2024, 9:07 AM
freebsd_dev.thsi.be added a comment to D43861: OCaml 4.14.1 upgrade..

Hi,

Thanks for your work, this is a much needed update, and not an easy one!

At a cursory look the patch looks well composed, but before approval it requires some testing.

The first commits are preparation to individual ports which must be applied before applying the last commit. Those commits work on the current tree and should cause no regressions.

While I agree that keeping the commits separated in the revision is useful, especially for you, if the patches require updates, for the final commit to the ports tree I'd be more in favour of one big commit with a succinct description for the individual changes (as in a list of one line descriptions). There are reasons for this.

Every commit would require the commit message to be modified to add our standard tags, referencing this revision and all approved by/tested by lines.

This is my opinion, maybe other involved committers have different ideas.

Feb 13 2024, 8:59 AM
freebsd_dev.thsi.be updated subscribers of D43861: OCaml 4.14.1 upgrade..
Feb 13 2024, 7:31 AM
freebsd_dev.thsi.be updated subscribers of D43861: OCaml 4.14.1 upgrade..
Feb 13 2024, 6:35 AM
freebsd_dev.thsi.be updated subscribers of D43861: OCaml 4.14.1 upgrade..
Feb 13 2024, 6:20 AM
freebsd_dev.thsi.be requested review of D43861: OCaml 4.14.1 upgrade..
Feb 13 2024, 6:13 AM