Page MenuHomeFreeBSD

freebsd_dev.thsi.be (Benjamin Jacobs)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 13 2024, 4:58 AM (10 w, 1 d)

Recent Activity

Mar 10 2024

freebsd_dev.thsi.be updated the summary of D43861: OCaml 4.14.1 upgrade..
Mar 10 2024, 12:42 PM
freebsd_dev.thsi.be updated the diff for D43861: OCaml 4.14.1 upgrade..

squashed & rebased

Mar 10 2024, 12:22 PM
freebsd_dev.thsi.be updated the diff for D43861: OCaml 4.14.1 upgrade..
  • devel/ocaml-logs: Missing RUN_DEPENDS.
  • x11-toolkits/ocaml-graphics: Extraneous BUILD_DEPENDS.
  • devel/ocaml-fpath: Missing RUN_DEPENDS.
  • devel/ocaml-fmt: Missing RUN_DEPENDS.
  • devel/ocaml-camomile: Missing RUN_DEPENDS.
  • devel/ocaml-camlp-streams: Package version set.
  • devel/ocaml-csexp: Package version set.
  • devel/ocaml-pcre2: Package version set.
  • devel/ocaml-re: Package version set.
  • x11-toolkits/ocaml-graphics: Package version set.
  • Set WRK_ENV.
Mar 10 2024, 12:10 PM

Mar 2 2024

freebsd_dev.thsi.be added a comment to D43861: OCaml 4.14.1 upgrade..

Thank you again for the reviews. There had been a bit of fallover from the moving of labltk and lablGL to site-lib/, I should have catched them before...
All plist issues should be gone too, as I've learned to use -t with poudriere-bulk ;)

Mar 2 2024, 12:19 PM
freebsd_dev.thsi.be updated the diff for D43861: OCaml 4.14.1 upgrade..

Squashed, commit message preparation.

Mar 2 2024, 11:59 AM
freebsd_dev.thsi.be updated the diff for D43861: OCaml 4.14.1 upgrade..
  • Uses/ocaml.mk: Typo.
  • devel/ocaml-sdl: bad --with-lablgldir.
  • games/freetennis: LablGL moved to site-lib, tidy Makefile.
  • devel/ocaml-logs: PORTDOCS adoption (un-orphaning).
Mar 2 2024, 11:01 AM

Mar 1 2024

freebsd_dev.thsi.be updated the diff for D43861: OCaml 4.14.1 upgrade..
  • Mk/Uses/dune.mk: clean build environment
  • respect MAKE_ENV
  • USES=dune -> USES=ocaml:dune
  • devel/ocaml-dune: fix PORTREVISION increment
  • security/ocaml-ssl: PORTREVISION bump.
  • textproc/ocaml-text: PORTREVISION bump.
Mar 1 2024, 1:11 PM
freebsd_dev.thsi.be updated the diff for D43861: OCaml 4.14.1 upgrade..

ocaml-findlib fix, rebased&squashed.

Mar 1 2024, 3:48 AM

Feb 22 2024

freebsd_dev.thsi.be updated the diff for D43861: OCaml 4.14.1 upgrade..
  • lang/ocaml: Missing PKGNAMESUFFIX.
  • math/teyjus: redundant build dep.
  • devel/ocaml-camlp5: Plist fix.
  • sysutils/ledit: Plist fix, install native binary, manpage version patch.
  • x11-toolkits/ocaml-labltk: Fixes
  • devel/ocaml-findlib: Stop providing conflicting META.
  • devel/ocaml-findlib: Broken POST-DEINSTALL.
  • graphics/ocaml-lablgl: Labltk include path fix, OCAML_SITELIBDIR
  • x11-toolkits/ocaml-lablgtk2: LablGL in site-lib.
Feb 22 2024, 2:28 AM

Feb 21 2024

freebsd_dev.thsi.be added a comment to D43861: OCaml 4.14.1 upgrade..

Hi!

I tested your patch in poudriere. In general it is very good from my POV, congrats on your work.

Feb 21 2024, 10:56 PM
freebsd_dev.thsi.be updated the diff for D43861: OCaml 4.14.1 upgrade..
  • devel/ocaml-camlp5: Plist fix.
  • sysutils/ledit: Plist fix, install native binary, manpage version patch.
  • x11-toolkits/ocaml-labltk: Fixes
  • devel/ocaml-findlib: Stop providing conflicting META.
  • devel/ocaml-findlib: Broken POST-DEINSTALL.
  • graphics/ocaml-lablgl: Labltk include path fix, OCAML_SITELIBDIR, shared librairies stripped, missing GL dependencies
Feb 21 2024, 10:48 PM

Feb 15 2024

freebsd_dev.thsi.be updated the diff for D43861: OCaml 4.14.1 upgrade..
  • lang/ocaml: Missing PKGNAMESUFFIX.
  • math/teyjus: redundant build dep.
Feb 15 2024, 12:32 PM

Feb 13 2024

freebsd_dev.thsi.be added a reviewer for D43861: OCaml 4.14.1 upgrade.: hrs.
Feb 13 2024, 9:21 AM
freebsd_dev.thsi.be added a reviewer for D43861: OCaml 4.14.1 upgrade.: danfe.
Feb 13 2024, 9:10 AM
freebsd_dev.thsi.be added a reviewer for D43861: OCaml 4.14.1 upgrade.: yuri.
Feb 13 2024, 9:07 AM
freebsd_dev.thsi.be added a comment to D43861: OCaml 4.14.1 upgrade..

Hi,

Thanks for your work, this is a much needed update, and not an easy one!

At a cursory look the patch looks well composed, but before approval it requires some testing.

The first commits are preparation to individual ports which must be applied before applying the last commit. Those commits work on the current tree and should cause no regressions.

While I agree that keeping the commits separated in the revision is useful, especially for you, if the patches require updates, for the final commit to the ports tree I'd be more in favour of one big commit with a succinct description for the individual changes (as in a list of one line descriptions). There are reasons for this.

Every commit would require the commit message to be modified to add our standard tags, referencing this revision and all approved by/tested by lines.

This is my opinion, maybe other involved committers have different ideas.

Feb 13 2024, 8:59 AM
freebsd_dev.thsi.be updated subscribers of D43861: OCaml 4.14.1 upgrade..
Feb 13 2024, 7:31 AM
freebsd_dev.thsi.be updated subscribers of D43861: OCaml 4.14.1 upgrade..
Feb 13 2024, 6:35 AM
freebsd_dev.thsi.be updated subscribers of D43861: OCaml 4.14.1 upgrade..
Feb 13 2024, 6:20 AM
freebsd_dev.thsi.be requested review of D43861: OCaml 4.14.1 upgrade..
Feb 13 2024, 6:13 AM