sound: use device_set_descf() to set device descriptions
ClosedPublic
Actions

Authored by christos on Jan 16 2024, 5:11 PM.

Details

Reviewers

markj
imp
dev_submerge.ch

Commits

rG406d5c58148c: sound: use device_set_descf() to set device descriptions
rGf7d3d0a4ded3: sound: use device_set_descf() to set device descriptions

Summary

Commit 6b6914c1e21b introduced a printf-like version of
device_set_desc(), so use it to simplify device description setting in
the audio stack.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks

Test Plan

The whole audio stack builds fine.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos requested review of this revision.Jan 16 2024, 5:11 PM

christos created this revision.

Harbormaster completed remote builds in B55457: Diff 132835.Jan 16 2024, 5:11 PM

@dev_submerge.ch This patch modifies part of your latest HDSPe commit. Since I do not have an HDSPe card to test, can you make sure this works fine?

christos edited the test plan for this revision. (Show Details)Jan 16 2024, 5:12 PM

Nice cleanup.

This revision is now accepted and ready to land.Jan 16 2024, 10:19 PM

Looks good to me, /dev/sndstat output is

pcm3: <HDSPe RayDAT [aes]> (play/rec)
pcm4: <HDSPe RayDAT [s/pdif]> (play/rec)
pcm5: <HDSPe RayDAT [adat1]> (play/rec)
pcm6: <HDSPe RayDAT [adat2]> (play/rec)
pcm7: <HDSPe RayDAT [adat3]> (play/rec)
pcm8: <HDSPe RayDAT [adat4]> (play/rec)

as expected.

Please note that this commit depends on rGd7fde2c9eccf, and thus also on rGb6052c10fb4ad. These were not marked for MFC. Don't know much about MFC procedures, but cherry-picking this commit without the others will probably fail. Feel free to MFC them as well if needed.

In D43467#991014, @dev_submerge.ch wrote:

Please note that this commit depends on rGd7fde2c9eccf, and thus also on rGb6052c10fb4ad. These were not marked for MFC. Don't know much about MFC procedures, but cherry-picking this commit without the others will probably fail. Feel free to MFC them as well if needed.

Thank you.

Closed by commit rGf7d3d0a4ded3: sound: use device_set_descf() to set device descriptions (authored by christos). · Explain WhyJan 22 2024, 9:46 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGf7d3d0a4ded3: sound: use device_set_descf() to set device descriptions.

christos added a commit: rG406d5c58148c: sound: use device_set_descf() to set device descriptions.Jan 30 2024, 11:10 AM

dev_submerge.ch mentioned this in D47325: sound: Make device registration more intuitive.Tue, Oct 29, 5:20 PM