Page MenuHomeFreeBSD

sound: use device_set_descf() to set device descriptions
ClosedPublic

Authored by christos on Jan 16 2024, 5:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 16 2024, 5:38 PM
Unknown Object (File)
Nov 1 2024, 10:32 PM
Unknown Object (File)
Nov 1 2024, 10:32 PM
Unknown Object (File)
Nov 1 2024, 1:23 PM
Unknown Object (File)
Nov 1 2024, 8:11 AM
Unknown Object (File)
Oct 24 2024, 10:55 PM
Unknown Object (File)
Oct 24 2024, 10:54 PM
Unknown Object (File)
Oct 24 2024, 10:54 PM
Subscribers
None

Details

Summary

Commit 6b6914c1e21b introduced a printf-like version of
device_set_desc(), so use it to simplify device description setting in
the audio stack.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks

Test Plan

The whole audio stack builds fine.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55457
Build 52346: arc lint + arc unit

Event Timeline

christos created this revision.

@dev_submerge.ch This patch modifies part of your latest HDSPe commit. Since I do not have an HDSPe card to test, can you make sure this works fine?

This revision is now accepted and ready to land.Jan 16 2024, 10:19 PM

Looks good to me, /dev/sndstat output is

pcm3: <HDSPe RayDAT [aes]> (play/rec)
pcm4: <HDSPe RayDAT [s/pdif]> (play/rec)
pcm5: <HDSPe RayDAT [adat1]> (play/rec)
pcm6: <HDSPe RayDAT [adat2]> (play/rec)
pcm7: <HDSPe RayDAT [adat3]> (play/rec)
pcm8: <HDSPe RayDAT [adat4]> (play/rec)

as expected.

Please note that this commit depends on rGd7fde2c9eccf, and thus also on rGb6052c10fb4ad. These were not marked for MFC. Don't know much about MFC procedures, but cherry-picking this commit without the others will probably fail. Feel free to MFC them as well if needed.

Please note that this commit depends on rGd7fde2c9eccf, and thus also on rGb6052c10fb4ad. These were not marked for MFC. Don't know much about MFC procedures, but cherry-picking this commit without the others will probably fail. Feel free to MFC them as well if needed.

Thank you.