HomeFreeBSD

sound: Remove redundant refcount checks in vchan_setnew()

Description

sound: Remove redundant refcount checks in vchan_setnew()

When adding a new vchan, we are looking for a parent channel which
either already has vchans (i.e CHN_F_HAS_VCHAN), or does not, but is
also not being used (i.e !CHN_F_BUSY). Since CHN_F_BUSY essentially
tells us if the channel is currently being used or not, there is no need
to check if the channel's refcount is 0 as well.

When removing a vchan, we first check if we have only 1 vchan allocated
that is also being used (so we cannot remove it at the moment), and then
we check if the vchan is not busy and remove it. Again, checking
CHN_F_BUSY is enough.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days
Reviewed by: dev_submerge.ch
Differential Revision: https://reviews.freebsd.org/D47268

(cherry picked from commit 43c0b593c2c3b2c07009c031a0e7e8190a45b31a)

Details

Provenance
christosAuthored on Oct 25 2024, 11:36 AM
Reviewer
dev_submerge.ch
Differential Revision
D47268: sound: Remove redundant refcount checks in vchan_setnew()
Parents
rGf3449b1a2115: sound: Untangle dsp_cdevs[] and dsp_unit2name() confusion
Branches
Unknown
Tags
Unknown