Differential D59076

sound: Do not set a recording source in mixer_uninit()
Needs ReviewPublic
Actions

Authored by christos on Fri, Aug 21, 12:46 PM.

Tags

None

Referenced Files

	F167526306: D59076.id184642.diff
	Sat, Aug 22, 12:07 PM

	F167524805: D59076.id.diff
	Sat, Aug 22, 11:53 AM

	F167524038: D59076.diff
	Sat, Aug 22, 11:42 AM

	Unknown Object (File)
	Fri, Aug 21, 2:29 PM

	Unknown Object (File)
	Fri, Aug 21, 1:35 PM

	Unknown Object (File)
	Fri, Aug 21, 1:16 PM

Subscribers

Details

Reviewers

markj
emaste
kib

Summary

We currently set the recording source to SOUND_MIXER_MIC during mixer
deletion. Apart from the fact that this control might not be present on
all devices, it is unnecessary to do that, plus we already set all the
volumes to 0 in the mixer_set() call above.

Sponsored by: The FreeBSD Foundation
MFC after: 1 month

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75941
Build 72824: arc lint + arc unit

Event Timeline

christos created this revision.Fri, Aug 21, 12:46 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Aug 21, 12:46 PM

christos requested review of this revision.Fri, Aug 21, 12:46 PM

Harbormaster completed remote builds in B75941: Diff 184642.Fri, Aug 21, 12:46 PM

christos added a parent revision: D59075: sound: Retire mixer_hwvol locked variants.Fri, Aug 21, 12:46 PM

christos added a child revision: D59077: sound: Reuse mixer_delete() in mixer_uninit().

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

2 lines

Diff 184642

sys/dev/sound/pcm/mixer.c

Loading...