Differential D59076

sound: Do not set a recording source in mixer_uninit()
ClosedPublic
Actions

Authored by christos on Aug 21 2026, 12:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 5, 8:57 AM

	Unknown Object (File)
	Sun, Oct 4, 2:34 PM

	Unknown Object (File)
	Sun, Oct 4, 2:33 PM

	Unknown Object (File)
	Sat, Oct 3, 8:42 PM

	Unknown Object (File)
	Sat, Oct 3, 12:07 AM

	Unknown Object (File)
	Thu, Oct 1, 9:34 AM

	Unknown Object (File)
	Tue, Sep 29, 5:25 PM

	Unknown Object (File)
	Tue, Sep 29, 3:26 AM

View All 68 Files

Subscribers

Details

Reviewers

markj
emaste
kib

Commits

rG03b59d2e7df2: sound: Do not set a recording source in mixer_uninit()

Summary

We currently set the recording source to SOUND_MIXER_MIC during mixer
deletion. Apart from the fact that this control might not be present on
all devices, it is unnecessary to do that, plus we already set all the
volumes to 0 in the mixer_set() call above.

Sponsored by: The FreeBSD Foundation
MFC after: 1 month

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Aug 21 2026, 12:46 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 21 2026, 12:46 PM

christos requested review of this revision.Aug 21 2026, 12:46 PM

Harbormaster completed remote builds in B75941: Diff 184642.Aug 21 2026, 12:46 PM

christos added a parent revision: D59075: sound: Retire mixer_hwvol locked variants.Aug 21 2026, 12:46 PM

christos added a child revision: D59077: sound: Reuse mixer_delete() in mixer_uninit().

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Sep 18, 6:19 PM

Closed by commit rG03b59d2e7df2: sound: Do not set a recording source in mixer_uninit() (authored by christos). · Explain Why

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG03b59d2e7df2: sound: Do not set a recording source in mixer_uninit().

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

2 lines

Diff 187129

sys/dev/sound/pcm/mixer.c

Loading...